Page MenuHomePhabricator

Open Tasks

Unbreak Now! (1)

Needs Triage (14)

Recent Activity

Mon, Jul 8

CLOVIS added a comment to T319: Multi factor Auth.

TOTP should be prioritized.

Mon, Jul 8, 6:40 PM · Client, Server API
WyldBot added a comment to T319: Multi factor Auth.

Use email over username for admin login

Mon, Jul 8, 4:01 PM · Client, Server API

Wed, Jul 3

Hackintosh5 added a comment to T291: Cache management V2.

I meant a callback. So you pass a callback into the code to request an object, and it is called with the new object as the only parameter when the cache update is complete, if and only if the object is actually different

Wed, Jul 3, 4:23 PM · LibWF-java
CLOVIS added a comment to T291: Cache management V2.

Maybe a variable could be added to the objects to get its new version if there is one? So the UI can know when a new one is created

Wed, Jul 3, 4:06 PM · LibWF-java
CLOVIS added a comment to T291: Cache management V2.

The idea here would be to never modify the objects, but instead just generate a new one and discard the old one, this way it can be done in parallel extremely easily

Wed, Jul 3, 4:05 PM · LibWF-java
Hackintosh5 added a comment to T291: Cache management V2.

Tbh I think we need some system to inform the client when an object has been updated. So that the UI can be updated when an update is performed without closing and reopening something (if you close and reopen a page the old data is displayed because the UI is loaded before the cache is refreshed

Wed, Jul 3, 4:02 PM · LibWF-java
CLOVIS updated subscribers of T291: Cache management V2.

@Hackintosh5 you didn't comment on this yet, what do you think?

Wed, Jul 3, 3:56 PM · LibWF-java
WyldBot accepted D256: Increase coverage to 70%.
Wed, Jul 3, 1:37 PM
WyldBot committed rWCL18485a47ac5c: Fix Android ANR's (authored by WyldBot).
Fix Android ANR's
Wed, Jul 3, 1:35 PM
WyldBot closed D258: Fix Android ANR's.
Wed, Jul 3, 1:35 PM
CLOVIS accepted D256: Increase coverage to 70%.
Wed, Jul 3, 1:33 PM
WyldBot added a comment to D258: Fix Android ANR's.

It's an issue with a specific chrome browaer version, this is a hack that ahould fix the issue for now

Wed, Jul 3, 12:12 PM
Hackintosh5 added a comment to D256: Increase coverage to 70%.

All resolved.

Wed, Jul 3, 12:10 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Wed, Jul 3, 12:03 PM
Hackintosh5 added a comment to D258: Fix Android ANR's.

Oh, I understand. It's committed to webcl (web client), but its a fix for the webview app, which loads webcl.

Wed, Jul 3, 12:00 PM
CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Good catch

Wed, Jul 3, 11:59 AM · LibWF-java
Hackintosh5 added a comment to D258: Fix Android ANR's.
In D258#6561, @CLOVIS wrote:

Wait, we have an Android app now? And it uses React?

I think it's about the currently used webapp?

Wed, Jul 3, 11:59 AM
CLOVIS requested changes to D256: Increase coverage to 70%.

After these it'll be OK for me

Wed, Jul 3, 11:57 AM
CLOVIS accepted D258: Fix Android ANR's.

Looks good to me but I honestly don't understand half of it, so I'm trusting you on that one

Wed, Jul 3, 11:47 AM
CLOVIS added a comment to D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Wed, Jul 3, 11:46 AM
Hackintosh5 abandoned D257: Ignore captcha failures in development mode.

Anyway this doesn't actually fix the issue. Other stuff fails and I won't bother.

Wed, Jul 3, 7:37 AM
Hackintosh5 updated the diff for D256: Increase coverage to 70%.
  • Remove extraneous System.out.println
Wed, Jul 3, 7:27 AM
Hackintosh5 resigned from D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Wed, Jul 3, 6:27 AM
WyldBot updated the diff for D258: Fix Android ANR's.

Added opacity

Wed, Jul 3, 4:08 AM
WyldBot updated the summary of D258: Fix Android ANR's.
Wed, Jul 3, 4:08 AM
WyldBot updated the summary of D258: Fix Android ANR's.
Wed, Jul 3, 4:07 AM
WyldBot created D258: Fix Android ANR's.
Wed, Jul 3, 4:05 AM

Tue, Jul 2

Hackintosh5 removed 1 blocking reviewer(s) for D254: Able to retrieve queue of posts: Info-Screen.
Tue, Jul 2, 8:43 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Tue, Jul 2, 8:39 PM
WyldBot accepted D254: Able to retrieve queue of posts.
Tue, Jul 2, 8:25 PM
WyldBot accepted D255: Fix bad logic in Draft isOnlyLocal.
Tue, Jul 2, 8:25 PM
WyldBot accepted D247: Migrating from FindBugs to SpotBugs.
Tue, Jul 2, 8:24 PM
WyldBot requested changes to D256: Increase coverage to 70%.
Tue, Jul 2, 8:23 PM
Hackintosh5 added a comment to D257: Ignore captcha failures in development mode.

Because I'm lazy

Tue, Jul 2, 8:21 PM
WyldBot accepted D253: Update gradle to 5.5.
Tue, Jul 2, 8:21 PM
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

Try making a test to edit the server draft (.save().setText().save()) and check the coverage. The method to edit server draft is never called.

Tue, Jul 2, 8:21 PM · LibWF-java
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

isLocalOnly is only set to false in the else clause.
So it's set to false (meaning uploaded to server) only if we edit the server draft. And we only edit the server draft if it's set to false! So it's never changed.

Tue, Jul 2, 8:20 PM · LibWF-java
CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Can you explain what the problem exactly is? I don't see it

Tue, Jul 2, 2:34 PM · LibWF-java
Info-Screen requested changes to D257: Ignore captcha failures in development mode.
Tue, Jul 2, 2:27 PM
Hackintosh5 closed T329: Minimal-json is missing from the archive as Resolved.

Fixed in D225

Tue, Jul 2, 12:46 PM · LibWF-java