Details

Reviewers

Info-Screen

Group Reviewers

Security

Maniphest Tasks

T208: Deprecate external images
T204: Left align post.text
T133: Allow user uploaded images in posts and comments

Commits

rWCLde27314439ac: Images

Summary

Updates regex for drafts, userposts, and create usecases
Implements comment validation
Implements new creation and mini-creation editor button for images
Changes current picture system for posts and comments to support images on posts and comments
Adds additional images within the fold for posts
Ensures there are no duplicates, hot links, or too many images within posts and comments
Auto removes hot links on posts and comments, does not auto remove duplicates
Lefts align post.text
Changes markdown engine from marked to markdown-it
New custom image markdown for user uploaded images
Old image markdown is no longer supported
Makes post and comment images smaller on larger screens
Updates NOTICE file for new copyrights

Fixes T133, T204

Test Plan

Make a post with no images
Make a post with images
Make a comment with an image
Make a comment without an image
Save drafts
Delete drafts
Delete post from postview

Diff Detail

Repository

rWCL Web Client

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Herald added 1 blocking reviewer(s): Info-Screen. · View Herald TranscriptMay 20 2018, 1:13 AM

Harbormaster completed remote builds in B399: Diff 535.May 20 2018, 1:13 AM

WyldBot planned changes to this revision.May 20 2018, 1:13 AM

Main images done

Harbormaster completed remote builds in B401: Diff 538.May 20 2018, 4:41 PM

WyldBot planned changes to this revision.May 20 2018, 4:41 PM

Saving

Harbormaster completed remote builds in B402: Diff 539.May 27 2018, 1:59 AM

WyldBot planned changes to this revision.May 27 2018, 1:59 AM

Client side filter implemented, Still to add/fix: comment images, hotlink auto removal, and fix when not a draft

Harbormaster completed remote builds in B403: Diff 540.May 28 2018, 11:29 PM

WyldBot planned changes to this revision.May 28 2018, 11:30 PM

WyldBot edited the summary of this revision. (Show Details)May 28 2018, 11:43 PM

WyldBot edited the test plan for this revision. (Show Details)

WyldBot added a task: T133: Allow user uploaded images in posts and comments.

Just have to add automatic hotlinking removal, and copy code from postview to home

Harbormaster completed remote builds in B404: Diff 541.May 29 2018, 1:44 AM

Final diff before phabricator review

Harbormaster completed remote builds in B405: Diff 542.May 30 2018, 12:05 AM

WyldBot edited the summary of this revision. (Show Details)May 30 2018, 12:07 AM

WyldBot added a task: T204: Left align post.text.

Left align posts

Harbormaster completed remote builds in B406: Diff 543.May 30 2018, 12:07 AM

WyldBot edited the summary of this revision. (Show Details)May 30 2018, 12:08 AM

WyldBot added a task: T204: Left align post.text.

WyldBot edited the summary of this revision. (Show Details)May 30 2018, 1:17 AM

Added comment data to the bottom of images

Harbormaster completed remote builds in B407: Diff 544.Jun 2 2018, 10:08 PM

Info-Screen added a reviewer: Security.Jun 3 2018, 2:35 PM

Comment input validation

Harbormaster completed remote builds in B408: Diff 545.Jun 3 2018, 3:27 PM

WyldBot edited the summary of this revision. (Show Details)Jun 3 2018, 3:27 PM

WyldBot edited the test plan for this revision. (Show Details)

Marked audit

Harbormaster completed remote builds in B409: Diff 546.Jun 3 2018, 3:35 PM

Compile

Harbormaster completed remote builds in B414: Diff 551.Jun 3 2018, 6:51 PM

rebase

Harbormaster completed remote builds in B417: Diff 555.Jun 4 2018, 10:57 PM

Duplicate Regex /\[?(!\s*\[[^\]]*\]\s*\((.*?)\s*("(?:.*[^"])?")?\s*\))\s*\]?\s*(?:(\(.*?\)))?/g: 10 times
Images are way to big on desktop
The upload uri is not guaranteed to stay this way (chances are actually pretty high that it won't), do not post the exact image location to the api.

It would be best to add a new tag (e.g. [img:<id>] and then configure the marked parser and lexer to understand that tag and pull the required information form the additional_images array (see: https://marked.js.org/#/USING_PRO.md)

This revision now requires changes to proceed.Jun 6 2018, 10:34 PM

Info-Screen mentioned this in T208: Deprecate external images.Jun 6 2018, 11:06 PM

Fixes

Harbormaster completed remote builds in B423: Diff 562.Jun 10 2018, 9:04 PM

WyldBot edited the summary of this revision. (Show Details)Jun 10 2018, 9:06 PM

WyldBot edited the summary of this revision. (Show Details)

WyldBot edited the summary of this revision. (Show Details)Jun 10 2018, 9:09 PM

WyldBot edited the summary of this revision. (Show Details)

WyldBot edited the summary of this revision. (Show Details)Jun 10 2018, 9:14 PM

WyldBot added inline comments.Jun 10 2018, 11:14 PM

src/app/home/home.component.html
60	Target _blank
src/app/postView/postView.component.html
58	Target blank
src/app/userPosts/userPosts.component.ts
81	Add wf image markdown like notification archive

fixes

Harbormaster completed remote builds in B424: Diff 563.Jun 10 2018, 11:41 PM

WyldBot marked 2 inline comments as done.Jun 10 2018, 11:42 PM

WyldBot marked an inline comment as done.Jun 11 2018, 3:17 AM

Regex fix

Harbormaster completed remote builds in B425: Diff 564.Jun 13 2018, 12:08 AM

Removed uneeded constructor

Harbormaster completed remote builds in B426: Diff 565.Jun 13 2018, 12:14 AM

Image in attachment area is way to big. Crop them down.

Could we edit the error a bit. Inform the user that they try to insert an image that doesn't exist etc not just say the "markdown does not exist".

src/app/_models/constants.ts
3	use `\d*` to allow larger image nums (unlikely to happen but not excluded by docs) and I don't really like that there has to be a space.
3	multiline flag seems not useful here
src/app/home/home.component.html
60	Consider adding `rel="noopener noreferrer"` to avoid later copy paste issues (and it might also bring some small performance benefits). Same for other uses of `target`.

This revision now requires changes to proceed.Jun 17 2018, 9:13 PM

WyldBot marked 3 inline comments as done.Jun 18 2018, 12:43 AM

Fixes

Harbormaster completed remote builds in B430: Diff 569.Jun 18 2018, 12:44 AM

Info-Screen accepted this revision.Jun 18 2018, 12:00 PM

This revision is now accepted and ready to land.Jun 18 2018, 12:00 PM

Closed by commit rWCLde27314439ac: Images (authored by WyldBot). · Explain WhyJun 20 2018, 1:17 PM

This revision was automatically updated to reflect the committed changes.

Info-Screen added a task: T208: Deprecate external images.Jun 21 2018, 10:49 PM

Images
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 574

NOTICE

package-lock.json

package.json

src/app/_dialogs/avatar.dialog.component.ts

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_dialogs/youtube.dialog.component.ts

src/app/_models/comment.ts

src/app/_models/constants.ts

src/app/_models/image.ts

src/app/_models/post.ts

src/app/_pipes/marked.pipe.ts

src/app/_services/http.service.ts

src/app/_services/post.service.ts

src/app/app.module.ts

src/app/createPost/createPost.component.html

src/app/createPost/createPost.component.ts

src/app/drafts/drafts.component.html

src/app/drafts/drafts.component.spec.ts

src/app/drafts/drafts.component.ts

src/app/home/home.component.html

src/app/home/home.component.spec.ts

src/app/home/home.component.ts

src/app/notificationArchive/notificationArchive.component.html

src/app/notificationArchive/notificationArchive.component.spec.ts

src/app/notificationArchive/notificationArchive.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.spec.ts

src/app/postView/postView.component.ts

src/app/userPosts/userPosts.component.html

src/app/userPosts/userPosts.component.spec.ts

src/app/userPosts/userPosts.component.ts

src/styles.css

ImagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 574

NOTICE

package-lock.json

package.json

src/app/_dialogs/avatar.dialog.component.ts

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_dialogs/youtube.dialog.component.ts

src/app/_models/comment.ts

src/app/_models/constants.ts

src/app/_models/image.ts

src/app/_models/post.ts

src/app/_pipes/marked.pipe.ts

src/app/_services/http.service.ts

src/app/_services/post.service.ts

src/app/app.module.ts

src/app/createPost/createPost.component.html

src/app/createPost/createPost.component.ts

src/app/drafts/drafts.component.html

src/app/drafts/drafts.component.spec.ts

src/app/drafts/drafts.component.ts

src/app/home/home.component.html

src/app/home/home.component.spec.ts

src/app/home/home.component.ts

src/app/notificationArchive/notificationArchive.component.html

src/app/notificationArchive/notificationArchive.component.spec.ts

src/app/notificationArchive/notificationArchive.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.spec.ts

src/app/postView/postView.component.ts

src/app/userPosts/userPosts.component.html

src/app/userPosts/userPosts.component.spec.ts

src/app/userPosts/userPosts.component.ts

src/styles.css

Images
ClosedPublic
Actions

Revision Contents
Changeset List