Page MenuHomePhabricator

Apple Fix, clean up, and flagging fix
ClosedPublic

Authored by WyldBot on Jun 17 2018, 10:31 PM.

Details

Summary

Fixes apple bug and reorganizes how we handle comment input
Cleans up unused code
Standardizes and fixes flag system
Fixes T196

Test Plan

Try to emulate on crossbrowsertesting or browserstack, it works
Test flagging

Diff Detail

Repository
rWCL Web Client
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/app/_dialogs/picture.dialog.component.ts
82

why this?

WyldBot added inline comments.
src/app/_dialogs/picture.dialog.component.ts
82

we depended on the post id for the name, now using a randomly created file name to kill the dependency

src/app/_dialogs/picture.dialog.component.ts
82

why not a static name, instead of some 'random' calculation.

WyldBot retitled this revision from Apple Fix to Apple Fix, clean up, and flagging fix.Jun 24 2018, 1:11 AM
WyldBot marked an inline comment as done.
WyldBot retitled this revision from Apple Fix, clean up, and flagging fix to Apple Fix.

Fixes, plus removes uneeded vars and elements, fixes flagging

WyldBot retitled this revision from Apple Fix to Apple Fix, clean up, and flagging fix .Jun 24 2018, 1:11 AM
WyldBot edited the test plan for this revision. (Show Details)
WyldBot edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 29 2018, 2:31 PM
This revision was automatically updated to reflect the committed changes.