Details

Reviewers

Info-Screen
CLOVIS

Maniphest Tasks

T196: Seriously fix the apple bug

Commits

rWCL531ef845d8f4: Apple Fix, clean up, and flagging fix

Summary

Fixes apple bug and reorganizes how we handle comment input
Cleans up unused code
Standardizes and fixes flag system
Fixes T196

Test Plan

Try to emulate on crossbrowsertesting or browserstack, it works
Test flagging

Diff Detail

Repository

rWCL Web Client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

WyldBot created this revision.Jun 17 2018, 10:31 PM

Herald added 1 blocking reviewer(s): Info-Screen. · View Herald TranscriptJun 17 2018, 10:31 PM

Harbormaster completed remote builds in B428: Diff 567.Jun 17 2018, 10:31 PM

WyldBot edited the test plan for this revision. (Show Details)Jun 18 2018, 12:31 AM

Changes

Harbormaster completed remote builds in B429: Diff 568.Jun 18 2018, 12:33 AM

Rebase, fixing head

Harbormaster completed remote builds in B431: Diff 570.Jun 18 2018, 9:41 PM

Info-Screen added inline comments.Jun 23 2018, 8:14 AM

src/app/_dialogs/picture.dialog.component.ts
82	why this?

WyldBot marked an inline comment as done.Jun 23 2018, 1:27 PM

WyldBot added inline comments.

src/app/_dialogs/picture.dialog.component.ts
82	we depended on the post id for the name, now using a randomly created file name to kill the dependency

Info-Screen added inline comments.Jun 23 2018, 7:26 PM

src/app/_dialogs/picture.dialog.component.ts
82	why not a static name, instead of some 'random' calculation.

WyldBot retitled this revision from Apple Fix to Apple Fix, clean up, and flagging fix.Jun 24 2018, 1:11 AM

Fixes, plus removes uneeded vars and elements, fixes flagging

Harbormaster completed remote builds in B441: Diff 585.Jun 24 2018, 1:11 AM

WyldBot retitled this revision from Apple Fix to Apple Fix, clean up, and flagging fix .Jun 24 2018, 1:11 AM

WyldBot edited the test plan for this revision. (Show Details)

WyldBot edited the summary of this revision. (Show Details)

WyldBot marked 2 inline comments as done.Jun 24 2018, 1:17 AM

WyldBot mentioned this in D163: Angular 5.Jun 24 2018, 5:07 PM

WyldBot added a reviewer: CLOVIS.Jun 24 2018, 5:33 PM

Info-Screen accepted this revision.Jun 29 2018, 2:31 PM

This revision is now accepted and ready to land.Jun 29 2018, 2:31 PM

Requires Rebase

Closed by commit rWCL531ef845d8f4: Apple Fix, clean up, and flagging fix (authored by WyldBot). · Explain WhyJun 29 2018, 5:29 PM

This revision was automatically updated to reflect the committed changes.

WyldBot mentioned this in rWCL4a7948365433: Angular 5.Jul 11 2018, 10:43 PM

Apple Fix, clean up, and flagging fix
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 606

src/app/_dialogs/flag.dialog.component.ts

src/app/_dialogs/password.dialog.component.ts

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_models/commentData.ts

src/app/_services/comment.service.ts

src/app/_services/flag.service.ts

src/app/_services/http.service.ts

src/app/_services/navBar.service.ts

src/app/_services/post.service.ts

src/app/app.module.ts

src/app/createPost/createPost.component.ts

src/app/home/home.component.html

src/app/home/home.component.spec.ts

src/app/home/home.component.ts

src/app/navBar/navBar.component.html

src/app/navBar/navBar.component.spec.ts

src/app/navBar/navBar.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.ts

src/styles.css

Apple Fix, clean up, and flagging fix ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 606

src/app/_dialogs/flag.dialog.component.ts

src/app/_dialogs/password.dialog.component.ts

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_models/commentData.ts

src/app/_services/comment.service.ts

src/app/_services/flag.service.ts

src/app/_services/http.service.ts

src/app/_services/navBar.service.ts

src/app/_services/post.service.ts

src/app/app.module.ts

src/app/createPost/createPost.component.ts

src/app/home/home.component.html

src/app/home/home.component.spec.ts

src/app/home/home.component.ts

src/app/navBar/navBar.component.html

src/app/navBar/navBar.component.spec.ts

src/app/navBar/navBar.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.ts

src/styles.css

Apple Fix, clean up, and flagging fix
ClosedPublic
Actions

Revision Contents
Changeset List