Page MenuHomePhabricator

Angular 5
ClosedPublic

Authored by WyldBot on Jun 24 2018, 5:02 PM.

Details

Summary

*Delete node_modules and package-lock.json*
*Run npm install*

Based on D158
The long awaited Angular 5!

Removes prismjs as we dont use it
Updates from angular 4.4.4 to 5.2.11
Updates material to latest compatible and changes all md tags to mat
Updates typescript version
Adds workaround for navbar back button, due to new navbar styling
Updates http and httpmodule to their new respective objects; httpclient, and httpclientmodule
Response is now a json object

Updates request headers

Implements ng2share as an internal module
Fixes T149

Test Plan

Test all functionality

Diff Detail

Repository
rWCL Web Client
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

WyldBot created this revision.Jun 24 2018, 5:02 PM
WyldBot edited the summary of this revision. (Show Details)Jun 24 2018, 5:07 PM
WyldBot added a reviewer: CLOVIS.
WyldBot edited the summary of this revision. (Show Details)Jun 24 2018, 5:10 PM
WyldBot edited the summary of this revision. (Show Details)

Clicking rapidly on comment button causes comment to be posted multiple times. It shouldn't be possible to post a comment, that is currently being posted.

Similar, to how it is not possible, to post a post twice, because the button is disabled

Could we get a rebase?

WyldBot updated this revision to Diff 612.Jun 30 2018, 1:52 PM

Rebase, and fixes comment disabling

This revision is now accepted and ready to land.Jul 11 2018, 10:36 PM
This revision was automatically updated to reflect the committed changes.