Details

Reviewers

Info-Screen
CLOVIS

Maniphest Tasks

T129: Service Worker Rewrite

Summary

Based on D163

NOTE: Must be on prod for the service worker to work

NOTE: Delete node_modules and package-lock.json npm i, ng build -prod, npm install http-server -g (In dist folder) http-server Go to localhost:8080

Prod build will be located at http://localhost:8080/

Updates angular cli and webpack

Reimplements the service worker
Adds new angular.json format
Fixes manifest

Fixes T129

Test Plan

Test out the service worker
Look at ngsw-config.json and tell me if those are correct caching settings
Note: each migration on the api side will require the version number to increment

Diff Detail

Repository

rWCL Web Client

Branch

arcpatch-D171

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 510
Build 510: arc lint + arc unit

Event Timeline

WyldBot created this revision.Jul 1 2018, 5:01 PM

Herald added 1 blocking reviewer(s): Info-Screen. · View Herald TranscriptJul 1 2018, 5:01 PM

Harbormaster completed remote builds in B463: Diff 613.Jul 1 2018, 5:02 PM

WyldBot edited the summary of this revision. (Show Details)Jul 1 2018, 5:03 PM

WyldBot added a task: T129: Service Worker Rewrite.

WyldBot edited the summary of this revision. (Show Details)Jul 1 2018, 5:05 PM

Info-Screen added inline comments.Jul 1 2018, 5:05 PM

angular.json
138	LF

Info-Screen added inline comments.Jul 1 2018, 5:08 PM

src/index.html
33–34	What is wrong with the current manifest?

WyldBot marked an inline comment as done.Jul 1 2018, 5:10 PM

WyldBot added inline comments.

angular.json
138	God damnit
src/index.html
33–34	Ah, the command added this

Fixes

Harbormaster completed remote builds in B464: Diff 615.Jul 1 2018, 5:11 PM

WyldBot added a reviewer: CLOVIS.Jul 1 2018, 5:15 PM

Doesn't work at all.

No service worker is registered when running ng serve and accessing localhost:4200

This revision now requires changes to proceed.Jul 4 2018, 2:09 PM

Info-Screen added a comment.Jul 4 2018, 2:13 PM

This comment was removed by Info-Screen.

WyldBot requested review of this revision.Jul 4 2018, 2:35 PM

WyldBot edited the summary of this revision. (Show Details)

Info-Screen edited the summary of this revision. (Show Details)Jul 4 2018, 2:40 PM

WyldBot edited the summary of this revision. (Show Details)Jul 7 2018, 8:56 PM

WyldBot edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B481: Diff 638.Jul 11 2018, 10:44 PM

I really don't know anything about this, I'll stay as a subscriber

WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:11 PM

WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:20 PM

WyldBot edited the summary of this revision. (Show Details)

YTep - Fix docker ignore file

Harbormaster completed remote builds in B509: Diff 682.Oct 6 2018, 6:25 PM

Fix the fix

Harbormaster completed remote builds in B510: Diff 683.Oct 6 2018, 6:28 PM

WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:32 PM

WyldBot edited the summary of this revision. (Show Details)Jan 22 2019, 4:26 PM

Going to rewrite after transition to Angular 7

		Path
D	M	.angular-cli.json (60 lines)
M		.dockerignore (1 line)
A	M	angular.json (137 lines)
M		karma.conf.js (14 lines)
A	M	ngsw-config.json (37 lines)
M		package-lock.json (6996 lines)
M		package.json (12 lines)
M		src/app/app.module.ts (4 lines)
M		src/assets/manifest.json (58 lines)
M		src/index.html (11 lines)
M		src/tsconfig.spec.json (3 lines)
D	M	sw-precache-config.js (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	613	ca4264b		Jul 1 2018, 5:01 PM	★	★
Diff 2	615	ca4264b	Fixes	Jul 1 2018, 5:11 PM	★	★
Diff 3	638	4a79483	rebase	Jul 11 2018, 10:44 PM	★	★
Diff 4	682	4a79483	YTep - Fix docker ignore file	Oct 6 2018, 6:25 PM	★	★
Diff 5	683	4a79483	- Fix the fix	Oct 6 2018, 6:28 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
115eb106718e	7a7e159c5893	f4badbe8b536	Cameron Gilbert	Fix the fix	Oct 6 2018, 6:27 PM
f4badbe8b536	19fb05b04b01	d5699687d9c7	Cameron Gilbert	Fix docker ignore file	Oct 6 2018, 6:25 PM
d5699687d9c7	4e8db9cb2770	4a7948365433	Cameron Gilbert	Service worker (Show More…)	Oct 6 2018, 6:10 PM

Service worker
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 683

.angular-cli.json

.dockerignore

angular.json

karma.conf.js

ngsw-config.json

package-lock.json

package.json

src/app/app.module.ts

src/assets/manifest.json

src/index.html

src/tsconfig.spec.json

sw-precache-config.js

Service workerAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 683

.angular-cli.json

.dockerignore

angular.json

karma.conf.js

ngsw-config.json

package-lock.json

package.json

src/app/app.module.ts

src/assets/manifest.json

src/index.html

src/tsconfig.spec.json

sw-precache-config.js

Service worker
AbandonedPublic
Actions

Revision Contents
Changeset List