Page MenuHomePhabricator

Service worker
AbandonedPublic

Authored by WyldBot on Jul 1 2018, 5:01 PM.

Details

Summary

Based on D163

NOTE: Must be on prod for the service worker to work
NOTE: Delete node_modules and package-lock.json npm i, ng build -prod, npm install http-server -g (In dist folder) http-server Go to localhost:8080

Prod build will be located at http://localhost:8080/

Updates angular cli and webpack

Reimplements the service worker
Adds new angular.json format
Fixes manifest

Fixes T129

Test Plan

Test out the service worker
Look at ngsw-config.json and tell me if those are correct caching settings
Note: each migration on the api side will require the version number to increment

Diff Detail

Repository
rWCL Web Client
Branch
arcpatch-D171
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 510
Build 510: arc lint + arc unit

Event Timeline

WyldBot created this revision.Jul 1 2018, 5:01 PM
WyldBot edited the summary of this revision. (Show Details)Jul 1 2018, 5:03 PM
WyldBot edited the summary of this revision. (Show Details)Jul 1 2018, 5:05 PM
Info-Screen added inline comments.Jul 1 2018, 5:05 PM
angular.json
138

LF

Info-Screen added inline comments.Jul 1 2018, 5:08 PM
src/index.html
33–34

What is wrong with the current manifest?

WyldBot marked an inline comment as done.Jul 1 2018, 5:10 PM
WyldBot added inline comments.
angular.json
138

God damnit

src/index.html
33–34

Ah, the command added this

WyldBot updated this revision to Diff 615.Jul 1 2018, 5:11 PM
WyldBot marked 4 inline comments as done.

Fixes

Info-Screen requested changes to this revision.Jul 4 2018, 2:09 PM

Doesn't work at all.

No service worker is registered when running ng serve and accessing localhost:4200

This revision now requires changes to proceed.Jul 4 2018, 2:09 PM
This comment was removed by Info-Screen.
WyldBot requested review of this revision.Jul 4 2018, 2:35 PM
WyldBot edited the summary of this revision. (Show Details)
WyldBot edited the summary of this revision. (Show Details)
Info-Screen edited the summary of this revision. (Show Details)Jul 4 2018, 2:40 PM
WyldBot edited the summary of this revision. (Show Details)Jul 7 2018, 8:56 PM
WyldBot edited the summary of this revision. (Show Details)
CLOVIS resigned from this revision.Jul 29 2018, 9:00 PM

I really don't know anything about this, I'll stay as a subscriber

WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:11 PM
WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:20 PM
WyldBot edited the summary of this revision. (Show Details)
WyldBot updated this revision to Diff 682.Oct 6 2018, 6:25 PM

YTep - Fix docker ignore file

WyldBot updated this revision to Diff 683.Oct 6 2018, 6:28 PM
  • Fix the fix
WyldBot edited the summary of this revision. (Show Details)Oct 6 2018, 6:32 PM
WyldBot edited the summary of this revision. (Show Details)Jan 22 2019, 4:26 PM
WyldBot abandoned this revision.Jan 23 2019, 6:56 PM

Going to rewrite after transition to Angular 7