Page MenuHomePhabricator

Bugfixes for 4a7948365433
ClosedPublic

Authored by WyldBot on Jul 14 2018, 5:35 PM.

Details

Summary

Fixes bugs introduced in 4a7948365433 (D163)

Fixes people being unable to register
Fixes login logic, instead of freezing on incorrect credentials we now respond with a generic error message.

Fixes a lot of minor bugs:
Fixes asterisks on input fields
Adds Open Source link to side navbar
Implements somewhat of a fix for flashing back button (Still performs slowly on post view)
Fixes bottom navbar highlight(sometimes the highlight was on the wrong section(or not working))
Fixes notification archive and user posts not taking into account its main image(for image icon)
Fixes weird offset background color
Fixes 2px space between navbar and top navbar(desktop only)
Removes odd highlight to the left of pictures(desktop only)
Fully center aligns area drop down
Changes pointer cursor on back button to better reflect its use
Fixes offset comment send button(desktop only)

Fixes T163, T203

Test Plan

Look at fixes?

Diff Detail

Repository
rWCL Web Client
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

WyldBot retitled this revision from Bug Fixes to I do not have a good title for this because it has a lot of fixes, but I am tired of looking at them so you can find them all here, future me, look here for lots of bug fixes.Jul 14 2018, 5:45 PM
WyldBot edited the summary of this revision. (Show Details)
WyldBot edited the summary of this revision. (Show Details)
Info-Screen retitled this revision from I do not have a good title for this because it has a lot of fixes, but I am tired of looking at them so you can find them all here, future me, look here for lots of bug fixes to Bugfixes for 4a7948365433.Jul 18 2018, 5:09 PM
Info-Screen edited the summary of this revision. (Show Details)

Going to accept this now, but I want test cases for all the bugs fixed in this revision.

This revision is now accepted and ready to land.Jul 18 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.