Page MenuHomePhabricator

Translating Areas to Kotlin
ClosedPublic

Authored by CLOVIS on Jan 4 2019, 11:11 PM.

Details

Summary
  • Added encodings IDEA settings file
  • Merging from master
  • Adding the cause as an optional parameter to ProgrammingException
  • Making the warning "Usage of Kotlin internal..." weak in tests because of an IntelliJ inspection bug
  • Adding support for Dokka (Kotlin documentation)
  • Method & Request are now internal
  • Helper methods Request.getJsonObject & getJsonArray
  • Translating Area to Kotlin
  • Using @JvmOverloads on ProgrammingException to make it easy to use
  • Translating IssueInTransferException to Kotlin

Fixes T271

Test Plan

Run the tests to check that nothing was broken

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Translating Areas to Kotlin
  • Fixed various issues found by FindBugs
src/main/java/net/wildfyre/areas/Area.kt
102 ↗(On Diff #720)

Only fun area?

src/main/java/net/wildfyre/areas/Areas.kt
52 ↗(On Diff #720)

Are we only targeting the "fun" area?

CLOVIS added inline comments.
src/main/java/net/wildfyre/areas/Area.kt
102 ↗(On Diff #720)

"fun" is the keyword for "function" in Kotlin :)

Updated because it was diverging from master.

  • Merge branch 'master' into T271-kotlin-areas
This revision is now accepted and ready to land.Jan 28 2019, 11:04 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.