Page MenuHomePhabricator

Fixes FF. slide out, area name, show posts on area
ClosedPublic

Authored by WyldBot on Jan 10 2019, 3:16 AM.

Details

Summary

Partially rewrites how we handle areas in general, removed AreaList model
Client now defaults to first area received from API as the first area to show to the user
Updated copyright
Fixes large ass margin on desktop
Fixes T300, T294, T301, T305 T303, and T299

Test Plan

Check out the fixes and updated UI

Diff Detail

Repository
rWCL Web Client
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

WyldBot edited the summary of this revision. (Show Details)
src/app/drafts/drafts.component.ts
112

This looks similar to createPost.components.js:46

src/app/home/home.component.ts
186

This looks similar to the two others too

src/app/notificationArchive/notificationArchive.component.ts
114

This looks similar too

src/app/userPosts/userPosts.component.ts
114

This too

WyldBot added inline comments.
src/app/userPosts/userPosts.component.ts
114

All of these calls have to be made at a component level to get the shared data

WyldBot marked an inline comment as done.
  • Change icon
src/app/userPosts/userPosts.component.ts
114

Sorry I'm not very knowledgeable about JS... Can you send me a link to the docs or to a SO question so I understand the problem better?

Well if you're confident that's the better way, I don't see anything else.

  • console.log
  • Change icon
  • More bug fixes
This revision is now accepted and ready to land.Jan 17 2019, 4:15 PM
This revision was automatically updated to reflect the committed changes.