Page MenuHomePhabricator

Fix test password
AbandonedPublic

Authored by Hackintosh5 on Jan 31 2019, 8:20 PM.

Details

Reviewers
CLOVIS
WyldBot
Maniphest Tasks
T313: Update tests after D203
Required Signatures
Restricted Legalpad Document
Summary

Change password to the new password after D203

Fixes T313

Test Plan

Check if RequestTest now passes

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 551
Build 551: arc lint + arc unit

Event Timeline

Hackintosh5 created this revision.Jan 31 2019, 8:20 PM
Herald added a required legal document: Restricted Legalpad Document. · View Herald TranscriptJan 31 2019, 8:20 PM
Harbormaster completed remote builds in B551: Diff 749.
CLOVIS retitled this revision from Fix test password Fixes T313 to Fix test passwordFixes T313.Jan 31 2019, 8:23 PM
CLOVIS added reviewers: CLOVIS, WyldBot.
CLOVIS retitled this revision from Fix test passwordFixes T313 to Fix test password.
CLOVIS edited the summary of this revision. (Show Details)
CLOVIS requested changes to this revision.Jan 31 2019, 8:36 PM

I guess you pull'd the api submodule to run the tests? If you did, you need to commit the api directory so it takes into account the lib upgrade. If you didn't pull the api submodule... Well, you need to do it ^^

Sorry if I didn't explain what this task was about, I was planning to do it myself so I didn't really bothered. More info on submodules: https://git-scm.com/book/en/v2/Git-Tools-Submodules

This revision now requires changes to proceed.Jan 31 2019, 8:36 PM

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

CLOVIS added a comment.Feb 1 2019, 1:53 PM

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

That's weird. How did you manage to push this diff then? Arcanist doesn't normally let you diff when the tests do not pass. Please tell me what you did, there might a bug there.

Other than that, the procedure for the lib on Linux is:

  • ./api.sh (let it run in the background)
  • ./gradlew build

On Windows:

  • git submodule init
  • git submodule update
  • Run the API by following the steps on the wiki (or the contents of the script api.sh)
  • gradlew.bat build

Again, if you did not do this, there's a big problem because it shouldn't be possible to diff without doing those.

WyldBot added 1 blocking reviewer(s): CLOVIS.Feb 1 2019, 5:52 PM
This revision now requires review to proceed.Feb 1 2019, 5:52 PM
WyldBot removed 1 blocking reviewer(s): WyldBot.Feb 1 2019, 5:52 PM
In D211#5079, @CLOVIS wrote:

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

That's weird. How did you manage to push this diff then? Arcanist doesn't normally let you diff when the tests do not pass. Please tell me what you did, there might a bug there.
Other than that, the procedure for the lib on Linux is:

  • ./api.sh (let it run in the background)
  • ./gradlew build

On Windows:

  • git submodule init
  • git submodule update
  • Run the API by following the steps on the wiki (or the contents of the script api.sh)
  • gradlew.bat build

Again, if you did not do this, there's a big problem because it shouldn't be possible to diff without doing those.

All I did is arc diff as shown in the user guide... If you scroll up, it says under Diff Detail, Unit Test Coverage is none, maybe it's because I didn't modify a main source file, so it was looking for a test test?

CLOVIS added a comment.Feb 1 2019, 9:29 PM

Yes and no, because of how Arc works, unit tests are categorized as "lint", it's normal (as of now, I will try to change that someday if I get time). It's possible that it doesn't run tests because you only modified tests? I need to check into that.

CLOVIS added a comment.Feb 9 2019, 9:46 PM

Because that revision requires submodule meddling, I've made D220. This one won't be merged.

CLOVIS requested changes to this revision.Feb 9 2019, 9:46 PM

I can't close the revision, so I'm just going to request changes :/

This revision now requires changes to proceed.Feb 9 2019, 9:46 PM
Hackintosh5 abandoned this revision.Feb 20 2019, 9:05 PM
Hackintosh5 added 1 blocking reviewer(s): CLOVIS.