- Updated the copyrights for 2019
Details
- Reviewers
WyldBot Info-Screen - Maniphest Tasks
- T308: Update Copyrights
- Commits
- rLIBWFJVA4abf82c445d0: Copyright update
rLIBWFJVA3aa3e3e7920c: Updating copyrights for 2019
Nothing, no actual change was done
Diff Detail
- Repository
- rLIBWFJVA WildFyre Java Libary
- Branch
- T308-update-copyrights (branched from master)
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 628 Build 628: arc lint + arc unit
Event Timeline
You can accept it if you want, but arc lint reports some errors for some reason, this is not getting merged until I completely understand where that comes from.
And, yes, when I manually run the build scripts, there are no errors.
Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.
Latest history diff between your last diff and the one before that shows this: https://phabricator.wildfyre.net/D212?vs=782&id=831#toc
That's weird because the files do have the file definitely has the expected year: https://phabricator-wildfyre-net.info-screen-usercontent.me/file/data/mrntat352z5t7wakas3l/PHID-FILE-me5u4evgkfoqlch3pkrh/src_test_java_net_wildfyre_users_UserTest.java
GitLab too confirms that the diff shown by @Info-Screen is buggy: RequestTest.kt and UserTest.java
I don't know what's going on here, Phabricator (when displaying the files), GitLab and my local version all agree that the copyright in those files is for 2019. Maybe the Phabricator diff tool didn't like some rebase at some point?