Copyright update
ClosedPublic
Actions

Authored by CLOVIS on Feb 1 2019, 8:06 PM.

Details

Reviewers

WyldBot
Info-Screen

Maniphest Tasks

T308: Update Copyrights

Commits

rLIBWFJVA4abf82c445d0: Copyright update
rLIBWFJVA3aa3e3e7920c: Updating copyrights for 2019

Summary

Updated the copyrights for 2019

Test Plan

Nothing, no actual change was done

Diff Detail

Repository

rLIBWFJVA WildFyre Java Libary

Branch

T308-update-copyrights (branched from master)

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 628
Build 628: arc lint + arc unit

Event Timeline

CLOVIS created this revision.Feb 1 2019, 8:06 PM

Harbormaster completed remote builds in B553: Diff 751.Feb 1 2019, 8:06 PM

Info-Screen accepted this revision.Feb 2 2019, 12:22 PM

This revision is now accepted and ready to land.Feb 2 2019, 12:22 PM

WyldBot accepted this revision.Feb 2 2019, 3:11 PM

You can accept it if you want, but arc lint reports some errors for some reason, this is not getting merged until I completely understand where that comes from.

And, yes, when I manually run the build scripts, there are no errors.

Rebasing to master to get the new unit tester that is not buggy

Harbormaster completed remote builds in B578: Diff 782.Feb 9 2019, 8:45 PM

WyldBot accepted this revision.Feb 20 2019, 4:41 PM

This revision is now accepted and ready to land.Feb 20 2019, 4:41 PM

Rebasing on master

This revision now requires review to proceed.Apr 8 2019, 11:33 AM

Harbormaster completed remote builds in B613: Diff 831.Apr 8 2019, 11:33 AM

Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.

WyldBot requested changes to this revision.Apr 8 2019, 4:41 PM

This revision now requires changes to proceed.Apr 8 2019, 4:41 PM

In D212#5686, @Info-Screen wrote:

Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.

CLOVIS requested review of this revision.Apr 10 2019, 3:05 AM

Latest history diff between your last diff and the one before that shows this: https://phabricator.wildfyre.net/D212?vs=782&id=831#toc

Please re arc diff

This revision now requires changes to proceed.Apr 11 2019, 2:37 AM

That's weird because the files do have the file definitely has the expected year: https://phabricator-wildfyre-net.info-screen-usercontent.me/file/data/mrntat352z5t7wakas3l/PHID-FILE-me5u4evgkfoqlch3pkrh/src_test_java_net_wildfyre_users_UserTest.java

Trying to update the diff to see if the display bug is fixed

Harbormaster completed remote builds in B628: Diff 849.Apr 18 2019, 4:13 PM

Harbormaster completed remote builds in B628: Diff 849.

GitLab too confirms that the diff shown by @Info-Screen is buggy: RequestTest.kt and UserTest.java

I don't know what's going on here, Phabricator (when displaying the files), GitLab and my local version all agree that the copyright in those files is for 2019. Maybe the Phabricator diff tool didn't like some rebase at some point?

WyldBot accepted this revision.Apr 18 2019, 6:16 PM

This revision is now accepted and ready to land.Apr 18 2019, 6:16 PM

CLOVIS closed this revision.Apr 19 2019, 2:09 AM