Page MenuHomePhabricator
Differential D212

Copyright update
ClosedPublic
Actions

Authored by CLOVIS on Feb 1 2019, 8:06 PM.
Tags
None
Referenced Files
F448698: D212.id751.diff
Thu, Oct 6, 2:00 AM
Unknown Object (File)
Wed, Sep 28, 8:11 PM
Unknown Object (File)
Wed, Sep 28, 11:22 AM
Unknown Object (File)
Tue, Sep 27, 4:30 AM
Unknown Object (File)
Tue, Sep 27, 4:29 AM
Unknown Object (File)
Tue, Sep 27, 4:29 AM
Unknown Object (File)
Tue, Sep 27, 4:29 AM
Unknown Object (File)
Tue, Sep 27, 4:29 AM
View All Files
Subscribers
Hackintosh5

Details

Reviewers
WyldBot
Info-Screen
Maniphest Tasks
T308: Update Copyrights
Commits
rLIBWFJVA4abf82c445d0: Copyright update
rLIBWFJVA3aa3e3e7920c: Updating copyrights for 2019
Summary
  • Updated the copyrights for 2019
Test Plan

Nothing, no actual change was done

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Branch
T308-update-copyrights (branched from master)
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 628
Build 628: arc lint + arc unit

Event Timeline

CLOVIS created this revision.Feb 1 2019, 8:06 PM
Harbormaster completed remote builds in B553: Diff 751.Feb 1 2019, 8:06 PM
Info-Screen accepted this revision.Feb 2 2019, 12:22 PM
This revision is now accepted and ready to land.Feb 2 2019, 12:22 PM
WyldBot accepted this revision.Feb 2 2019, 3:11 PM
CLOVIS planned changes to this revision.Feb 2 2019, 6:20 PM

You can accept it if you want, but arc lint reports some errors for some reason, this is not getting merged until I completely understand where that comes from.

And, yes, when I manually run the build scripts, there are no errors.

CLOVIS updated this revision to Diff 782.Feb 9 2019, 8:45 PM
CLOVIS edited the summary of this revision. (Show Details)

Rebasing to master to get the new unit tester that is not buggy

Harbormaster completed remote builds in B578: Diff 782.Feb 9 2019, 8:45 PM
WyldBot accepted this revision.Feb 20 2019, 4:41 PM
This revision is now accepted and ready to land.Feb 20 2019, 4:41 PM
CLOVIS updated this revision to Diff 831.Apr 8 2019, 11:33 AM

Rebasing on master

This revision now requires review to proceed.Apr 8 2019, 11:33 AM
Harbormaster completed remote builds in B613: Diff 831.Apr 8 2019, 11:33 AM
Info-Screen added a comment.Apr 8 2019, 1:24 PM

Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.

WyldBot requested changes to this revision.Apr 8 2019, 4:41 PM
This revision now requires changes to proceed.Apr 8 2019, 4:41 PM
CLOVIS added a comment.Apr 10 2019, 3:05 AM
In D212#5686, @Info-Screen wrote:

Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.

Both files are marked with copyright 2019, I don't understand your comment

CLOVIS requested review of this revision.Apr 10 2019, 3:05 AM
WyldBot added a comment.Apr 11 2019, 2:36 AM

Latest history diff between your last diff and the one before that shows this: https://phabricator.wildfyre.net/D212?vs=782&id=831#toc

WyldBot requested changes to this revision.Apr 11 2019, 2:37 AM

Please re arc diff

This revision now requires changes to proceed.Apr 11 2019, 2:37 AM
CLOVIS added a comment.Apr 11 2019, 7:21 AM

That's weird because the files do have the file definitely has the expected year: https://phabricator-wildfyre-net.info-screen-usercontent.me/file/data/mrntat352z5t7wakas3l/PHID-FILE-me5u4evgkfoqlch3pkrh/src_test_java_net_wildfyre_users_UserTest.java

CLOVIS updated this revision to Diff 849.Apr 18 2019, 4:13 PM
  • Trying to update the diff to see if the display bug is fixed
Harbormaster completed remote builds in B628: Diff 849.Apr 18 2019, 4:13 PM
Harbormaster completed remote builds in B628: Diff 849.
CLOVIS added a comment.Apr 18 2019, 4:17 PM

GitLab too confirms that the diff shown by @Info-Screen is buggy: RequestTest.kt and UserTest.java

I don't know what's going on here, Phabricator (when displaying the files), GitLab and my local version all agree that the copyright in those files is for 2019. Maybe the Phabricator diff tool didn't like some rebase at some point?

WyldBot accepted this revision.Apr 18 2019, 6:16 PM
This revision is now accepted and ready to land.Apr 18 2019, 6:16 PM
CLOVIS closed this revision.Apr 19 2019, 2:09 AM

Revision Contents
Changeset List

PathSize
16 lines
gradle/
wrapper/
16 lines
16 lines
src/
main/
java/
net/
wildfyre/
api/
2 lines
16 lines
areas/
2 lines
2 lines
descriptors/
2 lines
2 lines
2 lines
http/
2 lines
2 lines
2 lines
2 lines
posts/
2 lines
2 lines
2 lines
2 lines
users/
2 lines
2 lines
2 lines
utils/
2 lines
2 lines
2 lines
2 lines
test/
java/
net/
wildfyre/
areas/
2 lines
posts/
2 lines

Diff 849

View Options

build.gradle

Loading...
View Options

gradle/wrapper/gradle-wrapper.properties

Loading...
View Options

settings.gradle

Loading...
View Options

src/main/java/net/wildfyre/api/Internal.java

Loading...
View Options

src/main/java/net/wildfyre/api/WildFyre.java

Loading...
View Options

src/main/java/net/wildfyre/areas/Area.kt

Loading...
View Options

src/main/java/net/wildfyre/areas/Areas.kt

Loading...
View Options

src/main/java/net/wildfyre/descriptors/CacheManager.java

Loading...
View Options

src/main/java/net/wildfyre/descriptors/Descriptor.java

Loading...
View Options

src/main/java/net/wildfyre/descriptors/NoSuchEntityException.java

Loading...
View Options

src/main/java/net/wildfyre/http/DataType.java

Loading...
View Options

src/main/java/net/wildfyre/http/IssueInTransferException.kt

Loading...
View Options

src/main/java/net/wildfyre/http/Method.kt

Loading...
View Options

src/main/java/net/wildfyre/http/Request.kt

Loading...
View Options

src/main/java/net/wildfyre/posts/Comment.java

Loading...
View Options

src/main/java/net/wildfyre/posts/Draft.java

Loading...
View Options

src/main/java/net/wildfyre/posts/Post.java

Loading...
View Options

src/main/java/net/wildfyre/posts/PostData.java

Loading...
View Options

src/main/java/net/wildfyre/users/LoggedUser.java

Loading...
View Options

src/main/java/net/wildfyre/users/User.java

Loading...
View Options

src/main/java/net/wildfyre/users/Users.java

Loading...
View Options

src/main/java/net/wildfyre/utils/InvalidCredentialsException.java

Loading...
View Options

src/main/java/net/wildfyre/utils/InvalidJsonException.java

Loading...
View Options

src/main/java/net/wildfyre/utils/LazyMap.java

Loading...
View Options

src/main/java/net/wildfyre/utils/ProgrammingException.kt

Loading...
View Options

src/test/java/net/wildfyre/areas/AreaTest.java

Loading...
View Options

src/test/java/net/wildfyre/posts/PostTest.java

Loading...
Copyright WildFyre · Privacy Policy · Terms and Conditions