Fix for Ubuntu 18.04
ClosedPublic
Actions

Authored by Hackintosh5 on Feb 2 2019, 8:01 AM.

Details

Reviewers

CLOVIS
WyldBot

Commits

rLIBWFJVA46200011c189: Fix for Ubuntu 18.04
rLIBWFJVA21af00520a64: Fix for Ubuntu 18.04

Summary

Fix api.sh dependency installation OOTB on Ubuntu 18.04

Test Plan

See if api.sh works properly OOTB on Ubuntu 18.04

Diff Detail

Repository

rLIBWFJVA WildFyre Java Libary

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Hackintosh5 created this revision.Feb 2 2019, 8:01 AM

Harbormaster completed remote builds in B554: Diff 752.Feb 2 2019, 8:01 AM

CLOVIS added a reviewer: CLOVIS.Feb 2 2019, 8:17 AM

WyldBot added a reviewer: WyldBot.Feb 2 2019, 3:11 PM

@CLOVIS why have you rejected this?

Hackintosh5 added reviewers: CLOVIS, WyldBot.Feb 5 2019, 10:00 AM

In D213#5219, @Hackintosh5 wrote:

@CLOVIS why have you rejected this?

I didn't so far, I just added myself as a reviewer. Are you sure this change works everywhere?

In D213#5247, @CLOVIS wrote:

In D213#5219, @Hackintosh5 wrote:

@CLOVIS why have you rejected this?

I didn't so far, I just added myself as a reviewer. Are you sure this change works everywhere?

Oh, it shows as you blocking it. I really don't understand Phabricator, meh
Yes, it works everywhere the old version works (places with python3.6 installed) and more (places without the alias). The pip binary is literally just a shortcut to this syntax, iirc