Page MenuHomePhabricator

Fix compilation for users without nexus authentication
ClosedPublic

Authored by Hackintosh5 on Mon, Feb 4, 12:37 PM.

Details

Summary

Set nexusUsername and nexusPassword to '' if missing

Test Plan

Check if build can be completed without nexus authentication

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hackintosh5 created this revision.Mon, Feb 4, 12:37 PM
Harbormaster completed remote builds in B561: Diff 759.
Harbormaster completed remote builds in B561: Diff 759.

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Hackintosh5 updated this revision to Diff 764.Mon, Feb 4, 8:19 PM
This comment was removed by Hackintosh5.
Hackintosh5 updated this revision to Diff 766.Mon, Feb 4, 8:28 PM

Undo accidental push, I'm still a noob

In D216#5160, @CLOVIS wrote:

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Otherwise there's a parse time error; gradle is evaluating the ext.nexusUsername and since it can't be resolved, it fails to parse the build.gradle, leading to me being unable to build. This just delays that error until deployment time (which is impossible without nexusUsername/Password)

CLOVIS added a comment.Tue, Feb 5, 6:37 AM
In D216#5160, @CLOVIS wrote:

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Otherwise there's a parse time error; gradle is evaluating the ext.nexusUsername and since it can't be resolved, it fails to parse the build.gradle, leading to me being unable to build. This just delays that error until deployment time (which is impossible without nexusUsername/Password)

Ok

CLOVIS accepted this revision.Tue, Feb 5, 6:38 AM
This revision is now accepted and ready to land.Tue, Feb 5, 6:38 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.