Page MenuHomePhabricator

Internal to Kotlin
Needs RevisionPublic

Authored by CLOVIS on Feb 10 2019, 6:31 PM.

Details

Summary

Converting Internal to Kotlin

Closes T272

Test Plan

Run the tests

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Branch
T272-convert-internals
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 651
Build 651: arc lint + arc unit

Event Timeline

CLOVIS created this revision.Feb 10 2019, 6:31 PM
WyldBot accepted this revision.Wed, Mar 27, 3:34 PM
This revision is now accepted and ready to land.Wed, Mar 27, 3:34 PM
CLOVIS updated this revision to Diff 848.Thu, Apr 18, 4:05 PM
  • Rename .java to .kt
  • Converting Internal to Kotlin
This revision now requires review to proceed.Thu, Apr 18, 4:05 PM
WyldBot accepted this revision.Fri, Apr 19, 10:08 PM
This revision is now accepted and ready to land.Fri, Apr 19, 10:08 PM
Hackintosh5 requested changes to this revision.Sat, Apr 20, 2:31 AM

Can you check that the unit tests pass? Gradle skipped them so I guess they do but just to be sure

This revision now requires changes to proceed.Sat, Apr 20, 2:31 AM
CLOVIS updated this revision to Diff 878.Wed, Apr 24, 9:12 AM
  • Updating copyrights
  • Rename .java to .kt
  • Converting Internal to Kotlin
Harbormaster completed remote builds in B647: Diff 878.
CLOVIS updated this revision to Diff 882.Wed, Apr 24, 9:40 AM
  • Prototype of .gitlab-ci.yml
  • Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
  • Fix parallel tests when there's only 1 available core
  • Dockerfile with Java & Python
  • What is running on port 8000 in the container?
  • Removed after_script
  • Cache Gradle dependencies
  • Remove pointless lsof
  • Cache wheels
  • Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
  • Assume API is not running when lsof is missing
  • Do not run tests with static analysis
  • Cleaning the Dockerfile
  • # Ceci est la combinaison de 2 commits.
  • Better cache for CI
  • Reordering dependencies for clarity
  • Pip cache, reports as artifacts, Gradle without daemon
  • Run Dokka alongside the unit tests, to speed up builds
  • Gradle cache
  • Fix query order (posts are not always in the same order)
  • Update the API
  • Upload JUnit results as artifacts
  • Test the Gradle cache before running the scripts
  • Documentation in .gitlab-ci.yml
  • Upload the JUnit results
  • Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log output)
  • Rename .java to .kt
  • Converting Internal to Kotlin
CLOVIS edited the summary of this revision. (Show Details)Wed, Apr 24, 9:55 AM
Hackintosh5 requested changes to this revision.Wed, Apr 24, 12:09 PM

Needs same changes as D246 and D247

This revision now requires changes to proceed.Wed, Apr 24, 12:09 PM