Page MenuHomePhabricator

Fix missing minimal-json is exported JAR
AbandonedPublic

Authored by CLOVIS on Feb 10 2019, 6:38 PM.

Details

Test Plan

Nothing

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Branch
T329-minimal-json (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 582
Build 582: arc lint + arc unit

Event Timeline

CLOVIS created this revision.Feb 10 2019, 6:38 PM
Hackintosh5 requested changes to this revision.Feb 10 2019, 8:59 PM

This is not the way to do it. Compile is deprecated and should not be used.

This revision now requires changes to proceed.Feb 10 2019, 8:59 PM

Todo: use "api"

CLOVIS updated this revision to Diff 786.Feb 13 2019, 8:07 AM
  • Changing to "API" scope
Hackintosh5 requested changes to this revision.Feb 13 2019, 10:51 AM

Findbugs should be compileonly.

This revision now requires changes to proceed.Feb 13 2019, 10:51 AM

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

Hackintosh5 added a comment.EditedFeb 13 2019, 12:17 PM
In D222#5368, @CLOVIS wrote:

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

You're right. But D217 is the way to go.

This didn't fix minimal-json exporting correctly anyway. I've tested it in D225 and it works. I think this can be abandoned.

CLOVIS abandoned this revision.Apr 18 2019, 4:10 PM