Page MenuHomePhabricator

Downgrade SpotBugs to remove deprecation warning
AbandonedPublic

Authored by Hackintosh5 on Mar 6 2019, 9:55 AM.

Details

Summary

It was fixed in https://github.com/spotbugs/spotbugs-gradle-plugin/pull/86 but broken again (shown in https://github.com/spotbugs/spotbugs-gradle-plugin/issues/95). The root issue will be fixed in the SpotBugs 2.0.0 release, so we will remain on this version unless there is a special need to upgrade.

Test Plan

Check if gradle spews deprecation warnings

Diff Detail

Repository
rLIBWFJVA WildFyre Java Libary
Branch
arcpatch-D225
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 592
Build 592: arc lint + arc unit

Event Timeline

Hackintosh5 created this revision.Mar 6 2019, 9:55 AM
Info-Screen accepted this revision.Mar 10 2019, 5:59 PM
This revision is now accepted and ready to land.Mar 10 2019, 5:59 PM

This diff originates from ac4b3f808ce91d2f252fb3af08d980e6d8f88b5d which I do not have. I cannot land it.

Again my source has been nuked. Can you just merge the diff?

Just tried to apply it against master and it was rejected:

Vérification du patch build.gradle...
error: pendant la recherche de :

plugins {
    id 'java'
    id 'com.github.spotbugs' version '1.6.10'
    id 'signing' // To GPG-sign the archives that will be published.
    id 'maven' // To export to Maven
    id 'io.codearte.nexus-staging' version '0.20.0' // Confirm publication to MavenCentral

error: le patch a échoué : build.gradle:2
Application du patch build.gradle avec 1 rejet...
Section n°1 rejetée.

 Patch Failed! 
Usage Exception: Unable to apply patch!

If you know which commit it was from, I should be able to do something

This comes from D223. I'll deal with it's issues now.

Is this still relevant?

In D227#6354, @CLOVIS wrote:

Is this still relevant?

Well yes but actually no. D247 covers most of this, but gradle upgrades are still needed (D253).

Hackintosh5 abandoned this revision.Sat, Sep 7, 1:09 PM

Superseded by D259