Page MenuHomePhabricator

Initial iosclient

Authored by WyldBot on Mar 17 2019, 6:01 PM.


Test Plan

Initial iosclient. Still has many bugs!!!

Diff Detail

rIOS iOS Client
Lint Errors
ErrorArchive/Buy Buttons.png:NAME1Bad Filename
ErrorArchive/Coin AmountBg.png:NAME1Bad Filename
ErrorArchive/Group 5.2.png:NAME1Bad Filename
ErrorArchive/Post Control.png:NAME1Bad Filename
ErrorArchive/Rectangle 2.26.png:NAME1Bad Filename
ErrorArchive/RectanglePostBackGround 2.15.png:NAME1Bad Filename
ErrorArchive/WildFyre Final/.DS_Store:NAME1Bad Filename
ErrorArchive/WildFyre Final/FireGradient.png:NAME1Bad Filename
ErrorArchive/WildFyre Final/WildFyre:NAME1Bad Filename
ErrorArchive/WildFyre Final/key.p12:NAME1Bad Filename
WarningArchive/Search.png:CHMOD1Invalid Executable
WarningArchive/SearchBarRec.png:CHMOD1Invalid Executable
No Test Coverage
Build Status
Buildable 594
Build 594: arc lint + arc unit

Event Timeline

WyldBot added a subscriber: CLOVIS.
WyldBot added a subscriber: Info-Screen.

That looks like a file that shouldn't be public?

Looks like we are 2 levels to deep

Do we really need the images in different colors.

They only have foreground in a single color.
Have the image with black solid foreground, and set the color in the code.

please add the xcuserdata folder to .gitignore

Refer to my comments in #dev-ios

WyldBot requested changes to this revision.Mar 17 2019, 7:10 PM
This revision now requires changes to proceed.Mar 17 2019, 7:10 PM
SweatyMushroomz marked an inline comment as done.
  • Fixed errors

I still don't see a reason for the Archive folders, as well as the .DS_Store files

This revision now requires changes to proceed.Mar 23 2019, 9:41 PM

This diff seams wrong.
Do you check what you are uploading before you do?

CLOVIS requested changes to this revision.Apr 24 2019, 8:27 AM

There are only 2 files in the diff at that point

This revision now requires changes to proceed.Apr 24 2019, 8:27 AM
WyldBot requested changes to this revision.May 14 2019, 3:37 AM
WyldBot abandoned this revision.
WyldBot edited reviewers, added: SweatyMushroomz; removed: WyldBot.