Page MenuHomePhabricator

Initial iosclient
AbandonedPublic

Authored by WyldBot on Mar 17 2019, 6:01 PM.

Details

Test Plan

Initial iosclient. Still has many bugs!!!

Diff Detail

Repository
rIOS iOS Client
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
ErrorArchive/Group 5.2.png:NAME1Bad Filename
ErrorArchive/Post Control.png:NAME1Bad Filename
ErrorArchive/Rectangle 2.26.png:NAME1Bad Filename
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:6TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:7TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:8TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:9TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:10TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:11TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:12TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:13TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:14TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:15TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:16TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:17TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:18TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:19TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:20TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:21TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:22TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:23TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:56TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:57TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:58TXT3Line Too Long
WarningArchive/WildFyre_Final/WildFyre/.idea/workspace.xml:59TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 595
Build 595: arc lint + arc unit

Event Timeline

WyldBot added a subscriber: CLOVIS.
WyldBot added a subscriber: Info-Screen.
Archive/CertificateSigningRequest.certSigningRequest
2

That looks like a file that shouldn't be public?

Looks like we are 2 levels to deep

Do we really need the images in different colors.

They only have foreground in a single color.
Have the image with black solid foreground, and set the color in the code.

please add the xcuserdata folder to .gitignore

Refer to my comments in #dev-ios

WyldBot requested changes to this revision.Mar 17 2019, 7:10 PM
This revision now requires changes to proceed.Mar 17 2019, 7:10 PM
SweatyMushroomz marked an inline comment as done.
  • Fixed errors

I still don't see a reason for the Archive folders, as well as the .DS_Store files

This revision now requires changes to proceed.Mar 23 2019, 9:41 PM

This diff seams wrong.
Do you check what you are uploading before you do?

CLOVIS requested changes to this revision.Apr 24 2019, 8:27 AM

There are only 2 files in the diff at that point

This revision now requires changes to proceed.Apr 24 2019, 8:27 AM
WyldBot requested changes to this revision.May 14 2019, 3:37 AM
WyldBot abandoned this revision.
WyldBot edited reviewers, added: SweatyMushroomz; removed: WyldBot.