Page MenuHomePhabricator

Create All Area
Needs RevisionPublic

Authored by Info-Screen on Mar 25 2019, 1:08 PM.
Tags
None
Referenced Files
F475806: D234.id816.diff
Wed, Dec 7, 8:24 PM
F475805: D234.id.diff
Wed, Dec 7, 8:24 PM
Unknown Object (File)
Tue, Dec 6, 4:56 PM
Unknown Object (File)
Mon, Dec 5, 12:51 PM
Unknown Object (File)
Sun, Dec 4, 12:12 PM
Unknown Object (File)
Sun, Dec 4, 12:12 PM
Unknown Object (File)
Sun, Dec 4, 6:43 AM
Unknown Object (File)
Fri, Dec 2, 4:32 AM
Subscribers

Details

Reviewers
WyldBot
Maniphest Tasks
T232: All area
Summary

When using _ as an area name, an virtual all area is accessed. The all area is read only, and contains posts form all other areas.

Test Plan
  • Access all area
  • Try to create post in all area

Diff Detail

Repository
rAPI Server API
Branch
all-area
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 603
Build 603: arc lint + arc unit

Event Timeline

Does this populate the area list from /areas/ ?

As the doc states the _ area is in addition to those listed in /areas/, so it is not listed on /areas/. It contains all posts in all areas from /areas/

Why is this done server side instead of client side?

This revision is now accepted and ready to land.Mar 28 2019, 3:58 PM

I'll probably going to abandon this.

This will be implemented differently in one of my next diffs.

WyldBot requested changes to this revision.May 18 2019, 7:27 PM

http://prntscr.com/nqaxeq
Trying to subscribe to a post in all area

This revision now requires changes to proceed.May 18 2019, 7:27 PM
This comment was removed by WyldBot.

Why make it read only?
They can endorse but not comment or subscribe seems weird