Page MenuHomePhabricator

Disable character validation on User.username
ClosedPublic

Authored by Info-Screen on Apr 7 2019, 8:26 PM.

Details

Summary

The User model had a validation on the username field, that disallowed certain chars.
But because django-rest-framework sadly doesn't use the model validation we now have users with usernames
that are invalid according to the model validation.
These users couldn't be edited in the admin interface (because the admin validates correctly).
This removes the validator form the username field, so that these users can be edited in the admin interface.

Test Plan

Create a user with a space char.

Diff Detail

Repository
rAPI Server API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Apr 7 2019, 8:26 PM
This revision was automatically updated to reflect the committed changes.