Page MenuHomePhabricator
Differential D244

Get repo code somewhat up to date with current app
AbandonedPublic
Actions

Authored by WyldBot on Apr 20 2019, 12:41 PM.

Details

Reviewers
Info-Screen
SweatyMushroomz
Summary

Original iOS repo

Fixes

Test Plan

Nothing, just review/accept

Diff Detail

Repository
rIOS iOS Client
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
ErrorWildFyre.xcodeproj\project.pbxproj:3TXT2Tab Literal
ErrorWildFyre.xcodeproj\xcuserdata\user909400.xcuserdatad\xcschemes\xcschememanagement.plist:5TXT2Tab Literal
WarningWildFyre.xcodeproj\project.pbxproj:10TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:11TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:12TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:13TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:14TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:15TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:16TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:17TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:18TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:39TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:40TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:41TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:42TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:43TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:44TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:45TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:46TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:47TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:48TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:49TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:50TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:51TXT3Line Too Long
WarningWildFyre.xcodeproj\project.pbxproj:170TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 633
Build 633: arc lint + arc unit

Event Timeline

WyldBot created this revision.Apr 20 2019, 12:41 PM
Harbormaster completed remote builds in B633: Diff 857.Apr 20 2019, 12:41 PM
WyldBot added a reviewer: SweatyMushroomz.Apr 20 2019, 12:42 PM
WyldBot added a subscriber: SweatyMushroomz.
Info-Screen accepted this revision.Apr 22 2019, 6:17 PM
This revision is now accepted and ready to land.Apr 22 2019, 6:17 PM
Info-Screen requested changes to this revision.Apr 22 2019, 6:18 PM

There is a big warning above the box and still I nearly missed it....

What is with lint?

This revision now requires changes to proceed.Apr 22 2019, 6:18 PM
SweatyMushroomz accepted this revision.Apr 22 2019, 11:42 PM
SweatyMushroomz commandeered this revision.Apr 22 2019, 11:45 PM
SweatyMushroomz edited reviewers, added: WyldBot; removed: SweatyMushroomz.
WyldBot requested changes to this revision.Apr 22 2019, 11:46 PM
SweatyMushroomz updated this revision to Diff 867.Apr 22 2019, 11:56 PM
  • New iosclient with code
  • New iosclient with code
  • New iosclient with code
  • Removed private files
  • Fixed errors
  1. Updating D244: Get repo code somewhat up to date with current app #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #

Current ios client
The one that's on the app store

Harbormaster completed remote builds in B637: Diff 867.Apr 22 2019, 11:56 PM
Harbormaster completed remote builds in B637: Diff 867.
Info-Screen commandeered this revision.Apr 23 2019, 12:11 AM
Info-Screen abandoned this revision.
Info-Screen reclaimed this revision.
Info-Screen edited reviewers, added: SweatyMushroomz; removed: Info-Screen.

Fu*k wrong revision too.....

Info-Screen added a comment.Apr 23 2019, 12:13 AM

@SweatyMushroomz please commandeer this revision.

SweatyMushroomz commandeered this revision.Apr 23 2019, 12:23 AM
SweatyMushroomz edited reviewers, added: Info-Screen; removed: SweatyMushroomz.
SweatyMushroomz updated this revision to Diff 870.Apr 23 2019, 12:43 AM
  • Fixed errors
Harbormaster completed remote builds in B639: Diff 870.Apr 23 2019, 12:43 AM
Harbormaster completed remote builds in B639: Diff 870.
SweatyMushroomz updated this revision to Diff 871.Apr 23 2019, 1:05 AM

-fix

Harbormaster completed remote builds in B640: Diff 871.Apr 23 2019, 1:05 AM
Harbormaster completed remote builds in B640: Diff 871.
SweatyMushroomz updated this revision to Diff 872.Apr 23 2019, 1:26 AM
  • forcing
Harbormaster completed remote builds in B641: Diff 872.Apr 23 2019, 1:26 AM
Harbormaster completed remote builds in B641: Diff 872.
SweatyMushroomz updated this revision to Diff 873.Apr 23 2019, 1:32 AM
  • forcing
Harbormaster completed remote builds in B642: Diff 873.Apr 23 2019, 1:32 AM
SweatyMushroomz updated this revision to Diff 874.Apr 23 2019, 1:34 AM
  • forcing
Harbormaster completed remote builds in B643: Diff 874.Apr 23 2019, 1:34 AM
Harbormaster completed remote builds in B643: Diff 874.
SweatyMushroomz updated this revision to Diff 875.Apr 23 2019, 1:47 AM
  • forcing
Harbormaster completed remote builds in B644: Diff 875.Apr 23 2019, 1:47 AM
SweatyMushroomz updated this revision to Diff 876.Apr 23 2019, 1:53 AM
  • forcing
Harbormaster completed remote builds in B645: Diff 876.Apr 23 2019, 1:53 AM
Harbormaster completed remote builds in B645: Diff 876.
Hackintosh5 added a subscriber: Hackintosh5.Apr 24 2019, 12:58 PM

Lint lines are too long. Check my inline comment in AlertChildPageViewController.xib:2

Pods/AlertOnboarding/Pod/Assets/AlertChildPageViewController.xib
2 ↗(On Diff #876)

Split the line at a convenient location. It's not hard, just press enter instead of space.
Repeat for all the other warnings

WyldBot requested changes to this revision.Apr 24 2019, 1:19 PM

Add a .gitignore to hide .DS_Store files and all files in the Pods folder

This revision now requires changes to proceed.Apr 24 2019, 1:19 PM
Hackintosh5 added a comment.Apr 24 2019, 1:25 PM
In D244#6038, @WyldBot wrote:

Add a .gitignore to hide .DS_Store files and all files in the Pods folder

Also Podfile.lock

WyldBot commandeered this revision.Apr 25 2019, 4:23 AM
WyldBot edited reviewers, added: SweatyMushroomz; removed: WyldBot.
This revision now requires review to proceed.Apr 25 2019, 4:23 AM
WyldBot updated this revision to Diff 883.Apr 25 2019, 4:42 AM
  • Git ignore
  • fixed untracked files
Harbormaster completed remote builds in B652: Diff 883.Apr 25 2019, 4:42 AM
WyldBot planned changes to this revision.Apr 25 2019, 4:54 AM
WyldBot abandoned this revision.May 12 2019, 2:23 PM

Revision Contents
Changeset List

Diff 857

View Options

WildFyre.xcodeproj/project.pbxproj

Loading...
View Options

WildFyre.xcodeproj/project.xcworkspace/contents.xcworkspacedata

Loading...
View Options

WildFyre.xcodeproj/project.xcworkspace/xcuserdata/user909400.xcuserdatad/UserInterfaceState.xcuserstate

Loading...
View Options

WildFyre.xcodeproj/xcuserdata/user909400.xcuserdatad/xcschemes/xcschememanagement.plist

Loading...
View Options

WildFyre/AppDelegate.swift

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Contents.json

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@1x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@2x-1.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-20x20@3x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@1x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@2x-1.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-29x29@3x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@1x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@2x-1.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-40x40@3x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-60x60@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-60x60@3x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-76x76@1x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-76x76@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/Icon-App-83.5x83.5@2x.png

Loading...
View Options

WildFyre/Assets.xcassets/AppIcon.appiconset/profile_picture_symbol10242.png

Loading...
View Options

WildFyre/Assets.xcassets/Contents.json

Loading...
View Options

WildFyre/Base.lproj/LaunchScreen.storyboard

Loading...
View Options

WildFyre/Base.lproj/Main.storyboard

Loading...
View Options

WildFyre/Info.plist

Loading...
View Options

WildFyre/ViewController.swift

Loading...
View Options

WildFyreTests/Info.plist

Loading...
View Options

WildFyreTests/WildFyreTests.swift

Loading...
View Options

WildFyreUITests/Info.plist

Loading...
View Options

WildFyreUITests/WildFyreUITests.swift

Loading...
Copyright WildFyre · Privacy Policy · Terms and Conditions