Details

Reviewers

Commits

Summary

Removed cropper tool, fixed ugly images, fixed image size problems
Informs user that additional images need to be added individually

Test Plan

Test the above

Diff Detail

Repository

rWCL Web Client

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 664
Build 664: arc lint + arc unit

Event Timeline

WyldBot created this revision.Apr 30 2019, 2:56 AM

Harbormaster completed remote builds in B662: Diff 898.Apr 30 2019, 2:56 AM

WyldBot edited the summary of this revision. (Show Details)Apr 30 2019, 2:57 AM

WyldBot edited the test plan for this revision. (Show Details)

CLOVIS added a subscriber: CLOVIS.Apr 30 2019, 6:42 AM

CLOVIS added inline comments.

package-lock.json
1547	Should this really be in the Git? It's a very big file that looks more like a cache than anything. I don't know Angular so maybe that's normal but just to check

Info-Screen added inline comments.Apr 30 2019, 1:11 PM

package-lock.json
1547	package-lock.json is from npm the file that locks the package.json to specific versions and paths to have the values retrieved from. The idea is that the build system uses the same resources than the developer. NPM explicitly states that this file should be checked into vcs.

Info-Screen added inline comments.Apr 30 2019, 1:13 PM

package-lock.json
1547	I'm however not rely convinced about that files usefulness.

2 features in one diff. Might want to split that up

Image fix
Scroll to top

Fix package.json

Harbormaster completed remote builds in B663: Diff 899.Apr 30 2019, 6:29 PM

Harbormaster completed remote builds in B663: Diff 899.

Would prefer to keep it in 1 diff, this is a quick fix for minor problems.

Fixed scroll to top, added new image logic to avatar comp

Harbormaster completed remote builds in B664: Diff 900.Apr 30 2019, 11:39 PM

Uncomment comments

Harbormaster completed remote builds in B665: Diff 901.Apr 30 2019, 11:39 PM

Forgot styles

Harbormaster completed remote builds in B666: Diff 902.Apr 30 2019, 11:42 PM

In D249#6144, @Info-Screen wrote:

2 features in one diff. Might want to split that up

Image fix

Scroll to top

This revision now requires changes to proceed.May 5 2019, 1:23 PM

2 diffs

Harbormaster completed remote builds in B667: Diff 903.May 6 2019, 6:04 PM

WyldBot edited the summary of this revision. (Show Details)May 6 2019, 6:04 PM

WyldBot retitled this revision from Image fixes, and scroll to top to Image fixes.

WyldBot mentioned this in D250: Scroll to top.May 6 2019, 6:07 PM

Info-Screen requested changes to this revision.May 10 2019, 9:24 PM

Info-Screen added inline comments.

src/app/_dialogs/picture.dialog.component.ts
4	Does this really need to be of type any. If there are no typings available, you might want to search for some at DefinitelyTyped.
src/app/_dialogs/pictures.dialog.component.ts
5	same as above

This revision now requires changes to proceed.May 10 2019, 9:24 PM

Theres no definitely typed package

Info-Screen accepted this revision.May 12 2019, 2:35 PM

This revision is now accepted and ready to land.May 12 2019, 2:35 PM

Closed by commit rWCL9944cb22e661: Image fixes (authored by WyldBot). · Explain WhyMay 12 2019, 2:37 PM

This revision was automatically updated to reflect the committed changes.

WyldBot mentioned this in rWCL3bb6d21334db: Scroll to top.May 13 2019, 12:02 PM

Image fixes
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 900

.angular-cli.json

package-lock.json

package.json

src/app/_dialogs/avatar.dialog.component.ts

src/app/_dialogs/imageUpload.component.scss

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_services/authentication.service.ts

src/app/_services/http.service.ts

src/app/app.component.ts

src/app/app.module.ts

src/app/home/home.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.ts

src/styles.css

Image fixesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 900

.angular-cli.json

package-lock.json

package.json

src/app/_dialogs/avatar.dialog.component.ts

src/app/_dialogs/imageUpload.component.scss

src/app/_dialogs/picture.dialog.component.ts

src/app/_dialogs/pictures.dialog.component.ts

src/app/_services/authentication.service.ts

src/app/_services/http.service.ts

src/app/app.component.ts

src/app/app.module.ts

src/app/home/home.component.ts

src/app/postView/postView.component.html

src/app/postView/postView.component.ts

src/styles.css

Image fixes
ClosedPublic
Actions

Revision Contents
Changeset List