Fix bad logic in Draft isOnlyLocal
ClosedPublic
Actions

Authored by Hackintosh5 on Jul 2 2019, 9:05 AM.

Details

Reviewers

WyldBot
CLOVIS

Maniphest Tasks

T378: Logic error in Draft isOnlyLocal

Commits

rLIBWFJVA025a348e23e6: Fix bad logic in Draft isOnlyLocal
rLIBWFJVA344d2676a81c: Fix bad logic in Draft isOnlyLocal

Summary

Resolves T378

Test Plan

Manual

Diff Detail

Repository

rLIBWFJVA WildFyre Java Libary

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 690
Build 690: arc lint + arc unit

Event Timeline

Hackintosh5 created this revision.Jul 2 2019, 9:05 AM

Harbormaster completed remote builds in B690: Diff 948.Jul 2 2019, 9:05 AM

Tests pass but an exception is suppressed. I've fixed that exception and I'm fixing the next one, I'll update the diff later. The exceptions are due to errors in main not in the test

Fix tests

Don't require active property in JSON as it's not present for Drafts
Fix draft deletion

Harbormaster completed remote builds in B691: Diff 950.Jul 2 2019, 9:26 AM

Hackintosh5 added a child revision: D256: Increase coverage to 70%.Jul 2 2019, 11:08 AM

WyldBot accepted this revision.Jul 2 2019, 8:25 PM

This revision is now accepted and ready to land.Jul 2 2019, 8:25 PM

Closed by commit rLIBWFJVA344d2676a81c: Fix bad logic in Draft isOnlyLocal (authored by Hackintosh5). · Explain WhySep 7 2019, 1:11 PM

This revision was automatically updated to reflect the committed changes.

Hackintosh 5 <hackintosh5@wildfyre.net> added a commit: rLIBWFJVA344d2676a81c: Fix bad logic in Draft isOnlyLocal.

Hackintosh 5 <hackintosh5@wildfyre.net> added a commit: rLIBWFJVA025a348e23e6: Fix bad logic in Draft isOnlyLocal.

Revision Contents
Changeset List

Path

Size

src/

main/

java/

net/

wildfyre/

posts/

Draft.java

7 lines

Diff 948

View Options

src/main/java/net/wildfyre/posts/Draft.java

Fix bad logic in Draft isOnlyLocalClosedPublicActions