Page MenuHomePhabricator

Fix Android ANR's
ClosedPublic

Authored by WyldBot on Jul 3 2019, 4:05 AM.

Details

Summary

Fixes android ANR's based on this link: https://github.com/react-native-community/react-native-webview/issues/429

Changes 2 properties for a hidden container, which is likely crashing the app on Android 9

Plus updates our package.lock for newer dependencies

Test Plan

Check CSS

Diff Detail

Repository
rWCL Web Client
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

WyldBot created this revision.Jul 3 2019, 4:05 AM
WyldBot edited the summary of this revision. (Show Details)Jul 3 2019, 4:07 AM
WyldBot edited the test plan for this revision. (Show Details)
WyldBot added reviewers: CLOVIS, Hackintosh5.
WyldBot edited the summary of this revision. (Show Details)
WyldBot added subscribers: CLOVIS, Hackintosh5.
WyldBot updated this revision to Diff 955.Jul 3 2019, 4:08 AM

Added opacity

Hackintosh5 resigned from this revision.Jul 3 2019, 6:27 AM

Wait, we have an Android app now? And it uses React?

Wait, we have an Android app now? And it uses React?

I think it's about the currently used webapp?

CLOVIS accepted this revision.Jul 3 2019, 11:47 AM

Looks good to me but I honestly don't understand half of it, so I'm trusting you on that one

This revision is now accepted and ready to land.Jul 3 2019, 11:47 AM
In D258#6561, @CLOVIS wrote:

Wait, we have an Android app now? And it uses React?

I think it's about the currently used webapp?

AFAIK the webapp is not React Native. Just a webview.

Oh, I understand. It's committed to webcl (web client), but its a fix for the webview app, which loads webcl.

It's an issue with a specific chrome browaer version, this is a hack that ahould fix the issue for now

This revision was automatically updated to reflect the committed changes.