Page MenuHomePhabricator

Fix HTTP service issue
AbandonedPublic

Authored by WyldBot on Fri, Oct 4, 7:05 PM.

Details

Reviewers
Info-Screen
Summary

Ensures API requests end in a trailing slash

Test Plan

Test client

Diff Detail

Repository
rWCL Web Client
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 702
Build 702: arc lint + arc unit

Event Timeline

WyldBot created this revision.Fri, Oct 4, 7:05 PM
WyldBot updated this revision to Diff 975.Fri, Oct 4, 7:06 PM

Fix imports

WyldBot updated this revision to Diff 976.Fri, Oct 4, 7:08 PM

another fix

Hackintosh5 added inline comments.
src/app/_services/http.service.ts
28

Is a format string sensible? I think in this case it's more sensible to just append a '/', although I don't know TypeScript

181–182

This seems very wrong. Shouldn't this be done by creating a dictionary and setting a key if the token is present?

WyldBot abandoned this revision.Fri, Oct 4, 7:19 PM