Page MenuHomePhabricator

Logic error in Draft isOnlyLocal
Closed, ResolvedPublic

Event Timeline

Hackintosh5 triaged this task as High priority.Jul 2 2019, 7:37 AM
Hackintosh5 created this task.

Damn I can't read

Hackintosh5 closed this task as Invalid.Jul 2 2019, 8:06 AM
Hackintosh5 reopened this task as Open.Jul 2 2019, 9:03 AM

No, this is valid

CLOVIS added a subscriber: CLOVIS.Jul 2 2019, 2:34 PM

Can you explain what the problem exactly is? I don't see it

isLocalOnly is only set to false in the else clause.
So it's set to false (meaning uploaded to server) only if we edit the server draft. And we only edit the server draft if it's set to false! So it's never changed.

Try making a test to edit the server draft (.save().setText().save()) and check the coverage. The method to edit server draft is never called.