Page MenuHomePhabricator
Feed All Stories

Sat, Feb 16

CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • No more parallel unit tests (the testing server can't handle them)
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Sat, Feb 16, 10:59 AM
CLOVIS updated the summary of D210: Moving the user package to Kotlin.
Sat, Feb 16, 10:53 AM

Wed, Feb 13

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

https://stackoverflow.com/questions/44413952/gradle-implementation-vs-api-configuration suggests that findBugs should be implementation not api.

Wed, Feb 13, 2:51 PM
Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.
In D222#5368, @CLOVIS wrote:

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

You're right. But D217 is the way to go.

Wed, Feb 13, 12:17 PM
CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 11:03 AM
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 10:51 AM
CLOVIS committed rLIBWFJVA21af00520a64: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS committed rLIBWFJVA46200011c189: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS accepted D213: Fix for Ubuntu 18.04.

I just tested it, it works, so that's getting landed.

Wed, Feb 13, 8:13 AM
CLOVIS committed rLIBWFJVA64d73b1528ba: Updating server API (authored by CLOVIS).
Updating server API
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVAc5ce043fa261: Conforming to new password requirements in D203 (authored by CLOVIS).
Conforming to new password requirements in D203
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVA85d49f0b1e31: Mise à jour de l'API (authored by CLOVIS).
Mise à jour de l'API
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203 as Resolved by committing rLIBWFJVA64d73b1528ba: Updating server API.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203, a subtask of T311: Link the lib version with the API version, as Resolved.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS updated the diff for D222: Fix missing minimal-json is exported JAR.
  • Changing to "API" scope
Wed, Feb 13, 8:07 AM

Mon, Feb 11

CLOVIS added a comment to T328: Add a code coverage tool.

Basically a tool that looks at what your unit tests do and tries to find cases you might have forgotten

Mon, Feb 11, 6:38 AM · LibWF-java
CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Todo: use "api"

Mon, Feb 11, 6:34 AM

Sun, Feb 10

Hackintosh5 accepted D220: Updating server API.
Sun, Feb 10, 9:04 PM
Hackintosh5 added a comment to T328: Add a code coverage tool.

I can add it probably, but I have to admit, I don't even know what coverage is!

Sun, Feb 10, 9:00 PM · LibWF-java
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

This is not the way to do it. Compile is deprecated and should not be used.

Sun, Feb 10, 8:59 PM
CLOVIS updated subscribers of T328: Add a code coverage tool.

@Hackintosh5 would you know how to include this in your gradle engine?

Sun, Feb 10, 6:39 PM · LibWF-java
CLOVIS claimed T329: Minimal-json is missing from the archive.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM
CLOVIS added a revision to T329: Minimal-json is missing from the archive: D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM
CLOVIS added a revision to T272: Convert API to Kotlin: D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM · LibWF-java
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

I know how to squash with a rebase if that's what you mean?

Sun, Feb 10, 5:58 PM

Sat, Feb 9

CLOVIS requested changes to D211: Fix test password.

I can't close the revision, so I'm just going to request changes :/

Sat, Feb 9, 9:46 PM
CLOVIS added a comment to D211: Fix test password.

Because that revision requires submodule meddling, I've made D220. This one won't be merged.

Sat, Feb 9, 9:46 PM
CLOVIS created D220: Updating server API.
Sat, Feb 9, 9:41 PM
CLOVIS added a revision to T313: Update tests after D203: D220: Updating server API.
Sat, Feb 9, 9:41 PM · LibWF-java
CLOVIS added a comment to D210: Moving the user package to Kotlin.

@Info-Screen this was thrown by the API during testing for this diff:

Sat, Feb 9, 9:00 PM
CLOVIS updated the diff for D212: Copyright update.

Rebasing to master to get the new unit tester that is not buggy

Sat, Feb 9, 8:45 PM
CLOVIS committed rLIBWFJVA10a3e6ad57c4: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM
CLOVIS committed rLIBWFJVA3a9c702df40f: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM
CLOVIS closed T315: Better unit tests for Phabricator as Resolved by committing rLIBWFJVA10a3e6ad57c4: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM · LibWF-java
CLOVIS closed T315: Better unit tests for Phabricator as Resolved by committing rLIBWFJVA3a9c702df40f: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM · LibWF-java
CLOVIS closed D218: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM
CLOVIS closed D218: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5293, @CLOVIS wrote:

Is this ready for landing? Or do you plan to change other things

Sat, Feb 9, 5:27 PM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

Is this ready for landing? Or do you plan to change other things

Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVAcde5faba4b79: Fix compilation for users without nexus authentication (authored by Hackintosh5).
Fix compilation for users without nexus authentication
Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVAf8ceb343daaf: Fix compilation for users without nexus authentication (authored by Hackintosh5).
Fix compilation for users without nexus authentication
Sat, Feb 9, 10:11 AM
CLOVIS closed D216: Fix compilation for users without nexus authentication.
Sat, Feb 9, 10:11 AM
CLOVIS closed D216: Fix compilation for users without nexus authentication.
Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVA4684b374d255: Increase test timeout to prevent occasional failures (authored by Hackintosh5).
Increase test timeout to prevent occasional failures
Sat, Feb 9, 10:09 AM
CLOVIS committed rLIBWFJVAb0b25b7d8dd9: Increase test timeout to prevent occasional failures (authored by Hackintosh5).
Increase test timeout to prevent occasional failures
Sat, Feb 9, 10:09 AM
CLOVIS closed D219: Increase test timeout to prevent occasional failures.
Sat, Feb 9, 10:09 AM
CLOVIS closed D219: Increase test timeout to prevent occasional failures.
Sat, Feb 9, 10:09 AM
CLOVIS accepted D218: Add arc unit engine for gradle.
Sat, Feb 9, 9:39 AM

Fri, Feb 8

WyldBot added members for Marketing: laker, Info-Screen.
Fri, Feb 8, 11:01 PM
WyldBot added a watcher for Marketing: WyldBot.
Fri, Feb 8, 11:01 PM

Wed, Feb 6

Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug code and fix API running detection
Wed, Feb 6, 11:06 AM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Don't kill the API if we didn't start it
Wed, Feb 6, 11:01 AM
Info-Screen renamed T319: Multi factor Auth from Two factor Auth to Multi factor Auth.
Wed, Feb 6, 10:12 AM · Web, Server API
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Wed, Feb 6, 9:22 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:22 AM · LibWF-java
Hackintosh5 added a revision to T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM · LibWF-java
Hackintosh5 updated the summary of D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Wed, Feb 6, 9:21 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM · LibWF-java
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5267, @CLOVIS wrote:

They sounds odd to me. I'll need to benchmark this on my machine to see exactly. You didn't forget to do the migrations, download the dependencies, etc?

Wed, Feb 6, 8:23 AM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5270, @CLOVIS wrote:

Oh. Okay, remove the "fixes t..." from the description here, otherwise pantocrator will close the task. I'm probably going to test all your diffs this week end.

Wed, Feb 6, 8:16 AM
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

Oh. Okay, remove the "fixes t..." from the description here, otherwise pantocrator will close the task. I'm probably going to test all your diffs this week end.

Wed, Feb 6, 7:10 AM
CLOVIS updated subscribers of D213: Fix for Ubuntu 18.04.

Blocking means I'm a mandatory reviewer ^^

Wed, Feb 6, 7:06 AM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

They sounds odd to me. I'll need to benchmark this on my machine to see exactly. You didn't forget to do the migrations, download the dependencies, etc?

Wed, Feb 6, 7:03 AM

Tue, Feb 5

Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:26 PM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5248, @CLOVIS wrote:

Looks good to me so far, but you need to do the Internal class too (in the same way).

Please tell me if you have a better name for it, "internal" doesn't record what it's for clearly enough in my opinion

Tue, Feb 5, 8:23 PM
Hackintosh5 added a comment to D213: Fix for Ubuntu 18.04.
In D213#5247, @CLOVIS wrote:

@CLOVIS why have you rejected this?

I didn't so far, I just added myself as a reviewer. Are you sure this change works everywhere?

Tue, Feb 5, 8:22 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Cleanup code
Tue, Feb 5, 8:20 PM
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5234, @CLOVIS wrote:
  • Autostart the development API if it's not running already, and stop it again when we're done.

That's really not a good idea, the API takes 2-4 minutes to launch. Just abort if it doesn't run, that'll be much more convenient.

Tue, Feb 5, 8:16 PM
CLOVIS added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:13 PM
CLOVIS updated subscribers of D219: Increase test timeout to prevent occasional failures.

I've tried to land things before, it says I don't have access (403)...

Tue, Feb 5, 8:12 PM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:08 PM
Hackintosh5 added a comment to D219: Increase test timeout to prevent occasional failures.

I've tried to land things before, it says I don't have access (403)...

Tue, Feb 5, 8:06 PM
CLOVIS requested changes to D214: Convert WildFyre.java to Kotlin.

Looks good to me so far, but you need to do the Internal class too (in the same way).

Tue, Feb 5, 6:04 PM
CLOVIS added a comment to D213: Fix for Ubuntu 18.04.

@CLOVIS why have you rejected this?

Tue, Feb 5, 6:01 PM
CLOVIS added a comment to T265: Unable to login with provided credentials.

It would be better to check for the http sttlatus code, instead of trying to parse the json.

Tue, Feb 5, 5:56 PM · LibWF-java
CLOVIS added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 5:52 PM
CLOVIS added a comment to D219: Increase test timeout to prevent occasional failures.

To push such a small modification, use "Arc land --squashed". This will not clutter the history as much

Tue, Feb 5, 5:49 PM
CLOVIS accepted D219: Increase test timeout to prevent occasional failures.
Tue, Feb 5, 5:48 PM
Hackintosh5 created D219: Increase test timeout to prevent occasional failures.
Tue, Feb 5, 3:33 PM
CLOVIS added a comment to D218: Add arc unit engine for gradle.
  • Autostart the development API if it's not running already, and stop it again when we're done.
Tue, Feb 5, 2:41 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug and unused code
Tue, Feb 5, 1:40 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Autostart the development API if it's not running already, and stop it again when we're done.
Tue, Feb 5, 1:06 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.

Push accidental code, now removed

Tue, Feb 5, 12:58 PM
Info-Screen added a comment to T265: Unable to login with provided credentials.

It would be better to check for the http sttlatus code, instead of trying to parse the json.

Tue, Feb 5, 10:32 AM · LibWF-java
Hackintosh5 added a comment to T265: Unable to login with provided credentials.

Uff. No-one wants to parse a string JSON, how about an error code?

Tue, Feb 5, 10:05 AM · LibWF-java
Hackintosh5 added reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.
Tue, Feb 5, 10:00 AM
Hackintosh5 removed reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.

@CLOVIS why have you rejected this?

Tue, Feb 5, 10:00 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Simplify companion object syntax
Tue, Feb 5, 9:56 AM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 9:50 AM
CLOVIS requested changes to D214: Convert WildFyre.java to Kotlin.
Tue, Feb 5, 6:43 AM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

I need to test this locally before accepting, just to be sure. Sorry, it might take a few days before I have the time.

Tue, Feb 5, 6:40 AM
CLOVIS accepted D216: Fix compilation for users without nexus authentication.
Tue, Feb 5, 6:38 AM