Page MenuHomePhabricator
Feed All Stories

Mon, Jul 8

CLOVIS added a comment to T319: Multi factor Auth.

TOTP should be prioritized.

Mon, Jul 8, 6:40 PM · Client, Server API
WyldBot added a comment to T319: Multi factor Auth.

Use email over username for admin login

Mon, Jul 8, 4:01 PM · Client, Server API

Wed, Jul 3

Hackintosh5 added a comment to T291: Cache management V2.

I meant a callback. So you pass a callback into the code to request an object, and it is called with the new object as the only parameter when the cache update is complete, if and only if the object is actually different

Wed, Jul 3, 4:23 PM · LibWF-java
CLOVIS added a comment to T291: Cache management V2.

Maybe a variable could be added to the objects to get its new version if there is one? So the UI can know when a new one is created

Wed, Jul 3, 4:06 PM · LibWF-java
CLOVIS added a comment to T291: Cache management V2.

The idea here would be to never modify the objects, but instead just generate a new one and discard the old one, this way it can be done in parallel extremely easily

Wed, Jul 3, 4:05 PM · LibWF-java
Hackintosh5 added a comment to T291: Cache management V2.

Tbh I think we need some system to inform the client when an object has been updated. So that the UI can be updated when an update is performed without closing and reopening something (if you close and reopen a page the old data is displayed because the UI is loaded before the cache is refreshed

Wed, Jul 3, 4:02 PM · LibWF-java
CLOVIS updated subscribers of T291: Cache management V2.

@Hackintosh5 you didn't comment on this yet, what do you think?

Wed, Jul 3, 3:56 PM · LibWF-java
WyldBot accepted D256: Increase coverage to 70%.
Wed, Jul 3, 1:37 PM
WyldBot committed rWCL18485a47ac5c: Fix Android ANR's (authored by WyldBot).
Fix Android ANR's
Wed, Jul 3, 1:35 PM
WyldBot closed D258: Fix Android ANR's.
Wed, Jul 3, 1:35 PM
CLOVIS accepted D256: Increase coverage to 70%.
Wed, Jul 3, 1:33 PM
WyldBot added a comment to D258: Fix Android ANR's.

It's an issue with a specific chrome browaer version, this is a hack that ahould fix the issue for now

Wed, Jul 3, 12:12 PM
Hackintosh5 added a comment to D256: Increase coverage to 70%.

All resolved.

Wed, Jul 3, 12:10 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Wed, Jul 3, 12:03 PM
Hackintosh5 added a comment to D258: Fix Android ANR's.

Oh, I understand. It's committed to webcl (web client), but its a fix for the webview app, which loads webcl.

Wed, Jul 3, 12:00 PM
CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Good catch

Wed, Jul 3, 11:59 AM · LibWF-java
Hackintosh5 added a comment to D258: Fix Android ANR's.
In D258#6561, @CLOVIS wrote:

Wait, we have an Android app now? And it uses React?

I think it's about the currently used webapp?

Wed, Jul 3, 11:59 AM
CLOVIS requested changes to D256: Increase coverage to 70%.

After these it'll be OK for me

Wed, Jul 3, 11:57 AM
CLOVIS accepted D258: Fix Android ANR's.

Looks good to me but I honestly don't understand half of it, so I'm trusting you on that one

Wed, Jul 3, 11:47 AM
CLOVIS added a comment to D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Wed, Jul 3, 11:46 AM
Hackintosh5 abandoned D257: Ignore captcha failures in development mode.

Anyway this doesn't actually fix the issue. Other stuff fails and I won't bother.

Wed, Jul 3, 7:37 AM
Hackintosh5 updated the diff for D256: Increase coverage to 70%.
  • Remove extraneous System.out.println
Wed, Jul 3, 7:27 AM
Hackintosh5 resigned from D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Wed, Jul 3, 6:27 AM
WyldBot updated the diff for D258: Fix Android ANR's.

Added opacity

Wed, Jul 3, 4:08 AM
WyldBot updated the summary of D258: Fix Android ANR's.
Wed, Jul 3, 4:08 AM
WyldBot updated the summary of D258: Fix Android ANR's.
Wed, Jul 3, 4:07 AM
WyldBot created D258: Fix Android ANR's.
Wed, Jul 3, 4:05 AM

Tue, Jul 2

Hackintosh5 removed 1 blocking reviewer(s) for D254: Able to retrieve queue of posts: Info-Screen.
Tue, Jul 2, 8:43 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Tue, Jul 2, 8:39 PM
WyldBot accepted D254: Able to retrieve queue of posts.
Tue, Jul 2, 8:25 PM
WyldBot accepted D255: Fix bad logic in Draft isOnlyLocal.
Tue, Jul 2, 8:25 PM
WyldBot accepted D247: Migrating from FindBugs to SpotBugs.
Tue, Jul 2, 8:24 PM
WyldBot requested changes to D256: Increase coverage to 70%.
Tue, Jul 2, 8:23 PM
Hackintosh5 added a comment to D257: Ignore captcha failures in development mode.

Because I'm lazy

Tue, Jul 2, 8:21 PM
WyldBot accepted D253: Update gradle to 5.5.
Tue, Jul 2, 8:21 PM
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

Try making a test to edit the server draft (.save().setText().save()) and check the coverage. The method to edit server draft is never called.

Tue, Jul 2, 8:21 PM · LibWF-java
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

isLocalOnly is only set to false in the else clause.
So it's set to false (meaning uploaded to server) only if we edit the server draft. And we only edit the server draft if it's set to false! So it's never changed.

Tue, Jul 2, 8:20 PM · LibWF-java
CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Can you explain what the problem exactly is? I don't see it

Tue, Jul 2, 2:34 PM · LibWF-java
Info-Screen requested changes to D257: Ignore captcha failures in development mode.
Tue, Jul 2, 2:27 PM
Hackintosh5 closed T329: Minimal-json is missing from the archive as Resolved.

Fixed in D225

Tue, Jul 2, 12:46 PM · LibWF-java
Hackintosh5 added a comment to D227: Downgrade SpotBugs to remove deprecation warning.
In D227#6354, @CLOVIS wrote:

Is this still relevant?

Tue, Jul 2, 12:44 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Tue, Jul 2, 12:11 PM
Hackintosh5 abandoned D214: Convert WildFyre.java to Kotlin.
Tue, Jul 2, 12:08 PM
Hackintosh5 created D257: Ignore captcha failures in development mode.
Tue, Jul 2, 12:03 PM
Hackintosh5 created D256: Increase coverage to 70%.
Tue, Jul 2, 11:08 AM
Hackintosh5 updated the diff for D255: Fix bad logic in Draft isOnlyLocal.

Fix tests

  • Don't require active property in JSON as it's not present for Drafts
  • Fix draft deletion
Tue, Jul 2, 9:26 AM
Hackintosh5 added a comment to D255: Fix bad logic in Draft isOnlyLocal.

Tests pass but an exception is suppressed. I've fixed that exception and I'm fixing the next one, I'll update the diff later. The exceptions are due to errors in main not in the test

Tue, Jul 2, 9:14 AM
Hackintosh5 added a revision to T378: Logic error in Draft isOnlyLocal: D255: Fix bad logic in Draft isOnlyLocal.
Tue, Jul 2, 9:05 AM · LibWF-java
Hackintosh5 created D255: Fix bad logic in Draft isOnlyLocal.
Tue, Jul 2, 9:05 AM
Hackintosh5 claimed T378: Logic error in Draft isOnlyLocal.
Tue, Jul 2, 9:04 AM · LibWF-java
Hackintosh5 reopened T378: Logic error in Draft isOnlyLocal as "Open".

No, this is valid

Tue, Jul 2, 9:03 AM · LibWF-java
Hackintosh5 closed T378: Logic error in Draft isOnlyLocal as Invalid.
Tue, Jul 2, 8:06 AM · LibWF-java
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

Damn I can't read

Tue, Jul 2, 8:06 AM · LibWF-java
Hackintosh5 triaged T378: Logic error in Draft isOnlyLocal as High priority.
Tue, Jul 2, 7:37 AM · LibWF-java

Mon, Jul 1

Hackintosh5 claimed T376: Telegram Bot.

Authentication might be difficult.

Mon, Jul 1, 12:16 PM
Hackintosh5 updated the diff for D254: Able to retrieve queue of posts.
  • Remove extraneous character in comment
Mon, Jul 1, 11:45 AM
Hackintosh5 updated the diff for D254: Able to retrieve queue of posts.
  • Remove test code
Mon, Jul 1, 11:44 AM
Hackintosh5 added a revision to T377: Able to get queue of posts: D254: Able to retrieve queue of posts.
Mon, Jul 1, 10:06 AM · LibWF-java
Hackintosh5 added a task to D254: Able to retrieve queue of posts: T377: Able to get queue of posts.
Mon, Jul 1, 10:06 AM
Hackintosh5 created D254: Able to retrieve queue of posts.
Mon, Jul 1, 10:06 AM
Hackintosh5 created D253: Update gradle to 5.5.
Mon, Jul 1, 10:03 AM
Hackintosh5 added a subtask for T363: Release 1.0: T377: Able to get queue of posts.
Mon, Jul 1, 10:02 AM · LibWF-java
Hackintosh5 added a parent task for T377: Able to get queue of posts: T363: Release 1.0.
Mon, Jul 1, 10:02 AM · LibWF-java
Hackintosh5 created T377: Able to get queue of posts.
Mon, Jul 1, 10:01 AM · LibWF-java
Hackintosh5 abandoned D223: Update gradle wrapper and fix dependencies. Fixes T331..
In D223#6352, @CLOVIS wrote:

It looks like the changes here are mainly the same as D247... I know this one was made earlier but D247 is up to date with master and with the new CI system so I think it should be prioritized (unless there's something important here)

Mon, Jul 1, 9:56 AM
Hackintosh5 accepted D247: Migrating from FindBugs to SpotBugs.

Can we get this or something similar in please, I've been trying for months and these deprecation warnings are annoying me

Mon, Jul 1, 9:42 AM

Sat, Jun 29

WyldBot created T376: Telegram Bot.
Sat, Jun 29, 5:30 AM

Wed, Jun 26

Herald added 1 required legal document(s) to D251: Reboot the Android client: Restricted Legalpad Document.
Wed, Jun 26, 9:00 PM

May 27 2019

WyldBot added a comment to D234: Create All Area.

Why make it read only?
They can endorse but not comment or subscribe seems weird

May 27 2019, 10:34 PM

May 26 2019

Info-Screen triaged T375: Swagger API Docs as Normal priority.
May 26 2019, 4:50 PM · Documentation, Server API
Info-Screen created Documentation.
May 26 2019, 4:50 PM
WyldBot added a comment to D234: Create All Area.
May 26 2019, 3:56 PM
Info-Screen added a comment to D234: Create All Area.

All area is read only

May 26 2019, 3:53 PM

May 20 2019

CLOVIS added inline comments to D247: Migrating from FindBugs to SpotBugs.
May 20 2019, 5:15 PM
CLOVIS updated the diff for D247: Migrating from FindBugs to SpotBugs.
May 20 2019, 5:14 PM
WyldBot accepted D210: Moving the user package to Kotlin.
May 20 2019, 4:14 PM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
May 20 2019, 4:13 PM
CLOVIS added a comment to D210: Moving the user package to Kotlin.
In D210#6427, @WyldBot wrote:

May need rebase again though

May 20 2019, 4:10 PM

May 19 2019

WyldBot accepted D210: Moving the user package to Kotlin.

May need rebase again though

May 19 2019, 1:45 PM
WyldBot requested changes to D251: Reboot the Android client.
May 19 2019, 1:42 PM
WyldBot requested changes to D247: Migrating from FindBugs to SpotBugs.
May 19 2019, 1:41 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:55 PM
CLOVIS committed rLIBWFJVAb45c94b2d988: Integration JaCoCo into the Continuous Integration jobs (authored by CLOVIS).
Integration JaCoCo into the Continuous Integration jobs
May 19 2019, 12:55 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS closed T328: Add a code coverage tool as Resolved by committing rLIBWFJVA0d086f2c5cf0: Setup JaCoCo.
May 19 2019, 12:50 PM · LibWF-java
CLOVIS committed rLIBWFJVA0d086f2c5cf0: Setup JaCoCo (authored by CLOVIS).
Setup JaCoCo
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAafbb0c4c3e57: Setting the mandatory coverage ratio to 50% because the current app is only at… (authored by CLOVIS).
Setting the mandatory coverage ratio to 50% because the current app is only at…
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAf8caeba997e5: Catch cases in which the JSON returned by the API cannot be parsed, and replace… (authored by CLOVIS).
Catch cases in which the JSON returned by the API cannot be parsed, and replace…
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAad14b88ec977: Make Method & Request public (the tests can't find them if they are internal) (authored by CLOVIS).
Make Method & Request public (the tests can't find them if they are internal)
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA32b59e6dd908: Update the API (authored by CLOVIS).
Update the API
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA6d5dbf34b1c9: Remove parallel unit testing (the API doesn't handle them) (authored by CLOVIS).
Remove parallel unit testing (the API doesn't handle them)
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA8f34c18fb0f7: Cleaning the build.gradle (authored by CLOVIS).
Cleaning the build.gradle
May 19 2019, 12:50 PM
CLOVIS closed D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAf74cfc14eaeb: Setup JaCoCo (authored by CLOVIS).
Setup JaCoCo
May 19 2019, 12:50 PM