Page MenuHomePhabricator

Needs Triage (15)

Sat, Feb 16

CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • No more parallel unit tests (the testing server can't handle them)
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Sat, Feb 16, 10:59 AM
CLOVIS updated the summary of D210: Moving the user package to Kotlin.
Sat, Feb 16, 10:53 AM

Wed, Feb 13

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

https://stackoverflow.com/questions/44413952/gradle-implementation-vs-api-configuration suggests that findBugs should be implementation not api.

Wed, Feb 13, 2:51 PM
Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.
In D222#5368, @CLOVIS wrote:

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

You're right. But D217 is the way to go.

Wed, Feb 13, 12:17 PM
CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 11:03 AM
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 10:51 AM
CLOVIS committed rLIBWFJVA21af00520a64: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS committed rLIBWFJVA46200011c189: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS accepted D213: Fix for Ubuntu 18.04.

I just tested it, it works, so that's getting landed.

Wed, Feb 13, 8:13 AM
CLOVIS committed rLIBWFJVA64d73b1528ba: Updating server API (authored by CLOVIS).
Updating server API
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVAc5ce043fa261: Conforming to new password requirements in D203 (authored by CLOVIS).
Conforming to new password requirements in D203
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVA85d49f0b1e31: Mise à jour de l'API (authored by CLOVIS).
Mise à jour de l'API
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203 as Resolved by committing rLIBWFJVA64d73b1528ba: Updating server API.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203, a subtask of T311: Link the lib version with the API version, as Resolved.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS updated the diff for D222: Fix missing minimal-json is exported JAR.
  • Changing to "API" scope
Wed, Feb 13, 8:07 AM

Mon, Feb 11

CLOVIS added a comment to T328: Add a code coverage tool.

Basically a tool that looks at what your unit tests do and tries to find cases you might have forgotten

Mon, Feb 11, 6:38 AM · LibWF-java
CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Todo: use "api"

Mon, Feb 11, 6:34 AM

Sun, Feb 10

Hackintosh5 accepted D220: Updating server API.
Sun, Feb 10, 9:04 PM
Hackintosh5 added a comment to T328: Add a code coverage tool.

I can add it probably, but I have to admit, I don't even know what coverage is!

Sun, Feb 10, 9:00 PM · LibWF-java
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

This is not the way to do it. Compile is deprecated and should not be used.

Sun, Feb 10, 8:59 PM
CLOVIS updated subscribers of T328: Add a code coverage tool.

@Hackintosh5 would you know how to include this in your gradle engine?

Sun, Feb 10, 6:39 PM · LibWF-java
CLOVIS claimed T329: Minimal-json is missing from the archive.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM
CLOVIS added a revision to T329: Minimal-json is missing from the archive: D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM
CLOVIS added a revision to T272: Convert API to Kotlin: D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM · LibWF-java
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

I know how to squash with a rebase if that's what you mean?

Sun, Feb 10, 5:58 PM

Sat, Feb 9

CLOVIS requested changes to D211: Fix test password.

I can't close the revision, so I'm just going to request changes :/

Sat, Feb 9, 9:46 PM
CLOVIS added a comment to D211: Fix test password.

Because that revision requires submodule meddling, I've made D220. This one won't be merged.

Sat, Feb 9, 9:46 PM
CLOVIS created D220: Updating server API.
Sat, Feb 9, 9:41 PM
CLOVIS added a revision to T313: Update tests after D203: D220: Updating server API.
Sat, Feb 9, 9:41 PM · LibWF-java
CLOVIS added a comment to D210: Moving the user package to Kotlin.

@Info-Screen this was thrown by the API during testing for this diff:

Sat, Feb 9, 9:00 PM
CLOVIS updated the diff for D212: Copyright update.

Rebasing to master to get the new unit tester that is not buggy

Sat, Feb 9, 8:45 PM
CLOVIS committed rLIBWFJVA10a3e6ad57c4: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM
CLOVIS committed rLIBWFJVA3a9c702df40f: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM