Page MenuHomePhabricator

CLOVIS (Ivan Canet)
Android & Java dev, responsible of the Java lib and the Android app

Projects

User Details

User Since
Apr 22 2018, 5:40 PM (52 w, 3 d)

Recent Activity

Today

CLOVIS added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 3:07 PM
CLOVIS added a subtask for T368: Enable Kotlin multiplatform: T363: Release 1.0.
Wed, Apr 24, 3:04 PM · LibWF-java
CLOVIS added a parent task for T363: Release 1.0: T368: Enable Kotlin multiplatform.
Wed, Apr 24, 3:04 PM · LibWF-java
CLOVIS triaged T368: Enable Kotlin multiplatform as Normal priority.
Wed, Apr 24, 3:04 PM · LibWF-java
CLOVIS added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 1:38 PM
CLOVIS merged T366: Shadow Bans into T365: Shadow Banning.
Wed, Apr 24, 1:30 PM · Abuse
CLOVIS merged task T366: Shadow Bans into T365: Shadow Banning.
Wed, Apr 24, 1:30 PM · Server API
CLOVIS added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 1:07 PM
CLOVIS added inline comments to D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 12:59 PM
CLOVIS added a parent task for T363: Release 1.0: T291: Cache management V2.
Wed, Apr 24, 9:56 AM · LibWF-java
CLOVIS added a subtask for T291: Cache management V2: T363: Release 1.0.
Wed, Apr 24, 9:56 AM · LibWF-java
CLOVIS updated the summary of D221: Internal to Kotlin.
Wed, Apr 24, 9:55 AM
CLOVIS updated the summary of D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 9:54 AM
CLOVIS added a task to D246: Setup Continuous Integration via GitLab: T357: CI for the lib.
Wed, Apr 24, 9:54 AM
CLOVIS added a revision to T357: CI for the lib: D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 9:54 AM · LibWF-java
CLOVIS added a comment to D221: Internal to Kotlin.

CI: https://gitlab.com/wildfyre/lib/pipelines/58137002

Wed, Apr 24, 9:41 AM
CLOVIS updated the diff for D221: Internal to Kotlin.
  • Prototype of .gitlab-ci.yml
  • Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
  • Fix parallel tests when there's only 1 available core
  • Dockerfile with Java & Python
  • What is running on port 8000 in the container?
  • Removed after_script
  • Cache Gradle dependencies
  • Remove pointless lsof
  • Cache wheels
  • Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
  • Assume API is not running when lsof is missing
  • Do not run tests with static analysis
  • Cleaning the Dockerfile
  • # Ceci est la combinaison de 2 commits.
  • Better cache for CI
  • Reordering dependencies for clarity
  • Pip cache, reports as artifacts, Gradle without daemon
  • Run Dokka alongside the unit tests, to speed up builds
  • Gradle cache
  • Fix query order (posts are not always in the same order)
  • Update the API
  • Upload JUnit results as artifacts
  • Test the Gradle cache before running the scripts
  • Documentation in .gitlab-ci.yml
  • Upload the JUnit results
  • Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log output)
  • Rename .java to .kt
  • Converting Internal to Kotlin
Wed, Apr 24, 9:40 AM
CLOVIS added a comment to D210: Moving the user package to Kotlin.

CI: https://gitlab.com/wildfyre/lib/pipelines/58135786

Wed, Apr 24, 9:37 AM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Prototype of .gitlab-ci.yml
  • Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
  • Fix parallel tests when there's only 1 available core
  • Dockerfile with Java & Python
  • What is running on port 8000 in the container?
  • Removed after_script
  • Cache Gradle dependencies
  • Remove pointless lsof
  • Cache wheels
  • Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
  • Assume API is not running when lsof is missing
  • Do not run tests with static analysis
  • Cleaning the Dockerfile
  • # Ceci est la combinaison de 2 commits.
  • Better cache for CI
  • Reordering dependencies for clarity
  • Pip cache, reports as artifacts, Gradle without daemon
  • Run Dokka alongside the unit tests, to speed up builds
  • Gradle cache
  • Fix query order (posts are not always in the same order)
  • Update the API
  • Upload JUnit results as artifacts
  • Test the Gradle cache before running the scripts
  • Documentation in .gitlab-ci.yml
  • Upload the JUnit results
  • Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log output)
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Wed, Apr 24, 9:36 AM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Updating copyrights
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • No more parallel unit tests (the testing server can't handle them)
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Wed, Apr 24, 9:33 AM
CLOVIS created D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 9:27 AM
CLOVIS triaged T364: Fix Gradle depreciation warnings as Normal priority.
Wed, Apr 24, 9:23 AM · LibWF-java
CLOVIS added a subtask for T331: Kotlin-based projects cannot use libwf-java: T363: Release 1.0.
Wed, Apr 24, 9:20 AM · LibWF-java
CLOVIS added a parent task for T363: Release 1.0: T331: Kotlin-based projects cannot use libwf-java.
Wed, Apr 24, 9:20 AM · LibWF-java
CLOVIS removed a subtask for T363: Release 1.0: T331: Kotlin-based projects cannot use libwf-java.
Wed, Apr 24, 9:20 AM · LibWF-java
CLOVIS removed a parent task for T331: Kotlin-based projects cannot use libwf-java: T363: Release 1.0.
Wed, Apr 24, 9:20 AM · LibWF-java
CLOVIS added a parent task for T363: Release 1.0: T329: Minimal-json is missing from the archive.
Wed, Apr 24, 9:19 AM · LibWF-java
CLOVIS added a subtask for T329: Minimal-json is missing from the archive: T363: Release 1.0.
Wed, Apr 24, 9:19 AM · LibWF-java
CLOVIS added a subtask for T363: Release 1.0: T331: Kotlin-based projects cannot use libwf-java.
Wed, Apr 24, 9:19 AM · LibWF-java
CLOVIS added a parent task for T331: Kotlin-based projects cannot use libwf-java: T363: Release 1.0.
Wed, Apr 24, 9:19 AM · LibWF-java
CLOVIS moved T358: CD for the lib: auto deploy to MavenCentral from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Wed, Apr 24, 9:18 AM · LibWF-java
CLOVIS moved T357: CI for the lib from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Wed, Apr 24, 9:18 AM · LibWF-java
CLOVIS moved T361: CI for the lib: check for versions of dependencies from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Wed, Apr 24, 9:18 AM · LibWF-java
CLOVIS moved T362: Remove INSTANCE statements from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Wed, Apr 24, 9:18 AM · LibWF-java
CLOVIS added a subtask for T268: Kotlin + Java 7: T363: Release 1.0.
Wed, Apr 24, 9:17 AM · LibWF-java
CLOVIS added a subtask for T362: Remove INSTANCE statements: T363: Release 1.0.
Wed, Apr 24, 9:17 AM · LibWF-java
CLOVIS added parent tasks for T363: Release 1.0: T268: Kotlin + Java 7, T362: Remove INSTANCE statements.
Wed, Apr 24, 9:17 AM · LibWF-java
CLOVIS triaged T363: Release 1.0 as Wishlist priority.
Wed, Apr 24, 9:17 AM · LibWF-java
CLOVIS added a subtask for T268: Kotlin + Java 7: T362: Remove INSTANCE statements.
Wed, Apr 24, 9:15 AM · LibWF-java
CLOVIS added a parent task for T362: Remove INSTANCE statements: T268: Kotlin + Java 7.
Wed, Apr 24, 9:15 AM · LibWF-java
CLOVIS triaged T362: Remove INSTANCE statements as Normal priority.
Wed, Apr 24, 9:15 AM · LibWF-java
CLOVIS updated the diff for D221: Internal to Kotlin.
  • Updating copyrights
  • Rename .java to .kt
  • Converting Internal to Kotlin
Wed, Apr 24, 9:12 AM
CLOVIS triaged T361: CI for the lib: check for versions of dependencies as Low priority.
Wed, Apr 24, 9:02 AM · LibWF-java
CLOVIS requested changes to D229: Initial iosclient.

There are only 2 files in the diff at that point

Wed, Apr 24, 8:27 AM
CLOVIS created D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 8:26 AM
CLOVIS raised the priority of T328: Add a code coverage tool from Normal to High.
Wed, Apr 24, 8:07 AM · LibWF-java
CLOVIS added a comment to D245: Catch race conditions when multiple processes try to create the profile for a user.

After updating the API to master, the error doesn't appear anymore. I'm not sure why that is. Logs on GitLab

Wed, Apr 24, 7:05 AM

Yesterday

CLOVIS added a comment to D245: Catch race conditions when multiple processes try to create the profile for a user.

About the testing part, the current CI script I have for the lib consistently raises it, that could be used for testing. Once this is landed I'll update the API version and see if it still throws the exception

Tue, Apr 23, 2:25 AM

Mon, Apr 22

CLOVIS added a parent task for T360: CD for Android: T359: CI for Android.
Mon, Apr 22, 7:03 AM · Android
CLOVIS added a subtask for T359: CI for Android: T360: CD for Android.
Mon, Apr 22, 7:03 AM · Android
CLOVIS triaged T360: CD for Android as High priority.
Mon, Apr 22, 7:02 AM · Android
CLOVIS triaged T359: CI for Android as High priority.
Mon, Apr 22, 7:02 AM · Android
CLOVIS added a subtask for T357: CI for the lib: T358: CD for the lib: auto deploy to MavenCentral.
Mon, Apr 22, 7:01 AM · LibWF-java
CLOVIS added a parent task for T358: CD for the lib: auto deploy to MavenCentral: T357: CI for the lib.
Mon, Apr 22, 7:01 AM · LibWF-java
CLOVIS triaged T358: CD for the lib: auto deploy to MavenCentral as High priority.
Mon, Apr 22, 7:01 AM · LibWF-java
CLOVIS triaged T357: CI for the lib as High priority.
Mon, Apr 22, 7:00 AM · LibWF-java
CLOVIS added a comment to D225: Fix minimal-json JAR not being included..

Can you explain why this is important? Also, the dependencies are duplicated now (implementation and fatJar), it this really needed?

Mon, Apr 22, 6:58 AM

Sat, Apr 20

CLOVIS added a comment to T355: Disable (not inactive) a post after a flag gets accepted.
Sat, Apr 20, 5:25 PM · Server API
CLOVIS added a comment to T324: Implement new area system.

@Pregenun
Sorry if it wasn't clear, what I meant was that anyone would have 2 "virtual" areas: "world" which is just everything without sorting, and "subscriptions" that would be every area the user is interested in. Because the posts that are very popular would spread to neighbor areas, you would discover areas that are similar to the ones you know that way. By default, the user would be subscribed to the main ones, but they would slowly discover other ones.

Sat, Apr 20, 3:52 PM · Client, Server API

Fri, Apr 19

CLOVIS added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

Just tried to apply it against master and it was rejected:

Fri, Apr 19, 8:20 AM
CLOVIS added a comment to D225: Fix minimal-json JAR not being included..

If you remember around where it was from (eg. around which commit on the master branch), I should be able to apply it :)

Fri, Apr 19, 8:17 AM
CLOVIS added a comment to D226: We don't need spotbugs on the tests since they aren't used in production..

Sorry for the unclear explanation. Because of the problems with Arc and the time it wastes for us, we will stop using arc unit completely, and instead will implement CI via the GitLab mirror.

Fri, Apr 19, 8:16 AM
CLOVIS added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

This diff originates from ac4b3f808ce91d2f252fb3af08d980e6d8f88b5d which I do not have. I cannot land it.

Fri, Apr 19, 2:24 AM
CLOVIS added a comment to D225: Fix minimal-json JAR not being included..

This diff originates from beb6067caf9de614852fd499083d28871c270d43 which I do not have. I cannot land it.

Fri, Apr 19, 2:23 AM
CLOVIS abandoned D224: Fix unit tester.

This is not needed anymore

Fri, Apr 19, 2:22 AM
CLOVIS commandeered D224: Fix unit tester.
Fri, Apr 19, 2:22 AM
CLOVIS abandoned D226: We don't need spotbugs on the tests since they aren't used in production..

This is not needed anymore

Fri, Apr 19, 2:20 AM
CLOVIS commandeered D226: We don't need spotbugs on the tests since they aren't used in production..
Fri, Apr 19, 2:19 AM
CLOVIS closed T308: Update Copyrights as Resolved.
Fri, Apr 19, 2:17 AM · Android, LibWF-java
CLOVIS committed rLIBWFJVA4abf82c445d0: Copyright update (authored by CLOVIS).
Copyright update
Fri, Apr 19, 2:09 AM
CLOVIS committed rLIBWFJVA3aa3e3e7920c: Updating copyrights for 2019 (authored by CLOVIS).
Updating copyrights for 2019
Fri, Apr 19, 2:09 AM
CLOVIS closed D212: Copyright update.
Fri, Apr 19, 2:09 AM
CLOVIS committed rLIBWFJVA6aabd463f8f8: Remove Arc Unit from the workflow (authored by CLOVIS).
Remove Arc Unit from the workflow
Fri, Apr 19, 2:07 AM
CLOVIS committed rLIBWFJVAa21e0bb904d1: Removed Arc Unit (authored by CLOVIS).
Removed Arc Unit
Fri, Apr 19, 2:07 AM
CLOVIS closed D243: Remove Arc Unit from the workflow.
Fri, Apr 19, 2:07 AM
CLOVIS closed D243: Remove Arc Unit from the workflow.
Fri, Apr 19, 2:07 AM

Thu, Apr 18

CLOVIS added a comment to D212: Copyright update.

GitLab too confirms that the diff shown by @Info-Screen is buggy: RequestTest.kt and UserTest.java

Thu, Apr 18, 4:17 PM
CLOVIS updated the diff for D212: Copyright update.
  • Trying to update the diff to see if the display bug is fixed
Thu, Apr 18, 4:13 PM
CLOVIS abandoned D222: Fix missing minimal-json is exported JAR.
Thu, Apr 18, 4:10 PM
CLOVIS updated the diff for D221: Internal to Kotlin.
  • Rename .java to .kt
  • Converting Internal to Kotlin
Thu, Apr 18, 4:05 PM
CLOVIS created D243: Remove Arc Unit from the workflow.
Thu, Apr 18, 3:48 PM

Thu, Apr 11

CLOVIS added a comment to D212: Copyright update.

That's weird because the files do have the file definitely has the expected year: https://phabricator-wildfyre-net.info-screen-usercontent.me/file/data/mrntat352z5t7wakas3l/PHID-FILE-me5u4evgkfoqlch3pkrh/src_test_java_net_wildfyre_users_UserTest.java

Thu, Apr 11, 7:21 AM

Wed, Apr 10

CLOVIS requested review of D212: Copyright update.
Wed, Apr 10, 3:05 AM
CLOVIS added a comment to D212: Copyright update.

Why the change back to 2018 in src/test/java/net/wildfyre/http/RequestTest.kt and src/test/java/net/wildfyre/users/UserTest.java.

Wed, Apr 10, 3:05 AM

Mon, Apr 8

CLOVIS updated the diff for D212: Copyright update.

Rebasing on master

Mon, Apr 8, 11:33 AM

Tue, Apr 2

CLOVIS resigned from D236: User blocking - Apple Revision.

Sorry, I can't read any of this. I'm okay with the changes as you shown on Telegram, but I'm not qualified to find bugs

Tue, Apr 2, 7:23 PM

Wed, Mar 27

CLOVIS added a comment to D234: Create All Area.

Why is this done server side instead of client side?

Wed, Mar 27, 4:40 PM

Mar 20 2019

CLOVIS added a comment to T256: Limit the use of nested serializes to a minimum.

Okay. I thought about the other because it's not breaking (and more detailed)

Mar 20 2019, 1:36 PM · Client, Server API
CLOVIS added a comment to T200: Unknown User Interface.

Wait, is this for the Client (web) or app?

Mar 20 2019, 10:58 AM · Client, Server API
CLOVIS added a comment to T98: Ability to edit posts and comments after creation.

Why would we restrict editing?

Mar 20 2019, 10:56 AM · Client, Server API
CLOVIS added a comment to T256: Limit the use of nested serializes to a minimum.
In T256#4663, @CLOVIS wrote:

This could be replaced by T290, which gets the same results in a non-breaking way.

Mar 20 2019, 10:46 AM · Client, Server API
CLOVIS added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Mar 20 2019, 10:45 AM

Mar 17 2019

CLOVIS added inline comments to D229: Initial iosclient.
Mar 17 2019, 6:28 PM

Feb 28 2019

CLOVIS added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:13 PM
CLOVIS added a comment to T331: Kotlin-based projects cannot use libwf-java.

The lib is NOT ready to be used before 1.0. There's no point trying, there are multiple things that are not ready.

Feb 28 2019, 2:32 PM · LibWF-java
CLOVIS added a comment to D223: Update gradle wrapper and fix dependencies. Fixes T331..

I don't understand what you're trying to do with the resource handling.

Feb 28 2019, 2:30 PM

Feb 27 2019

CLOVIS added a comment to T330: Use error codes in the API, rather than error messages.

Server API already sends a code (known as http status code) errors start with 4 (client errors, e.g. invalid input) or 5 (server errors, e.g. database unavailable)

Feb 27 2019, 1:22 PM · LibWF

Feb 16 2019

CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • No more parallel unit tests (the testing server can't handle them)
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Feb 16 2019, 10:59 AM
CLOVIS updated the summary of D210: Moving the user package to Kotlin.
Feb 16 2019, 10:53 AM

Feb 13 2019

CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Feb 13 2019, 11:03 AM