Page MenuHomePhabricator

CLOVIS (Ivan Canet)
Android & Java dev, responsible of the Java lib and the Android app

Projects

User Details

User Since
Apr 22 2018, 5:40 PM (68 w, 6 d)

Recent Activity

Jul 8 2019

CLOVIS added a comment to T319: Multi factor Auth.

TOTP should be prioritized.

Jul 8 2019, 6:40 PM · Client, Server API

Jul 3 2019

CLOVIS added a comment to T291: Cache management V2.

Maybe a variable could be added to the objects to get its new version if there is one? So the UI can know when a new one is created

Jul 3 2019, 4:06 PM · LibWF-java
CLOVIS added a comment to T291: Cache management V2.

The idea here would be to never modify the objects, but instead just generate a new one and discard the old one, this way it can be done in parallel extremely easily

Jul 3 2019, 4:05 PM · LibWF-java
CLOVIS updated subscribers of T291: Cache management V2.

@Hackintosh5 you didn't comment on this yet, what do you think?

Jul 3 2019, 3:56 PM · LibWF-java
CLOVIS accepted D256: Increase coverage to 70%.
Jul 3 2019, 1:33 PM
CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Good catch

Jul 3 2019, 11:59 AM · LibWF-java
CLOVIS requested changes to D256: Increase coverage to 70%.

After these it'll be OK for me

Jul 3 2019, 11:57 AM
CLOVIS accepted D258: Fix Android ANR's.

Looks good to me but I honestly don't understand half of it, so I'm trusting you on that one

Jul 3 2019, 11:47 AM
CLOVIS added a comment to D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Jul 3 2019, 11:46 AM

Jul 2 2019

CLOVIS added a comment to T378: Logic error in Draft isOnlyLocal.

Can you explain what the problem exactly is? I don't see it

Jul 2 2019, 2:34 PM · LibWF-java

May 20 2019

CLOVIS added inline comments to D247: Migrating from FindBugs to SpotBugs.
May 20 2019, 5:15 PM
CLOVIS updated the diff for D247: Migrating from FindBugs to SpotBugs.
May 20 2019, 5:14 PM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
May 20 2019, 4:13 PM
CLOVIS added a comment to D210: Moving the user package to Kotlin.
In D210#6427, @WyldBot wrote:

May need rebase again though

May 20 2019, 4:10 PM

May 19 2019

CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:55 PM
CLOVIS committed rLIBWFJVAb45c94b2d988: Integration JaCoCo into the Continuous Integration jobs (authored by CLOVIS).
Integration JaCoCo into the Continuous Integration jobs
May 19 2019, 12:55 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS closed T328: Add a code coverage tool as Resolved by committing rLIBWFJVA0d086f2c5cf0: Setup JaCoCo.
May 19 2019, 12:50 PM · LibWF-java
CLOVIS committed rLIBWFJVA0d086f2c5cf0: Setup JaCoCo (authored by CLOVIS).
Setup JaCoCo
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAafbb0c4c3e57: Setting the mandatory coverage ratio to 50% because the current app is only at… (authored by CLOVIS).
Setting the mandatory coverage ratio to 50% because the current app is only at…
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAf8caeba997e5: Catch cases in which the JSON returned by the API cannot be parsed, and replace… (authored by CLOVIS).
Catch cases in which the JSON returned by the API cannot be parsed, and replace…
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAad14b88ec977: Make Method & Request public (the tests can't find them if they are internal) (authored by CLOVIS).
Make Method & Request public (the tests can't find them if they are internal)
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA32b59e6dd908: Update the API (authored by CLOVIS).
Update the API
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA6d5dbf34b1c9: Remove parallel unit testing (the API doesn't handle them) (authored by CLOVIS).
Remove parallel unit testing (the API doesn't handle them)
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS updated the diff for D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVA8f34c18fb0f7: Cleaning the build.gradle (authored by CLOVIS).
Cleaning the build.gradle
May 19 2019, 12:50 PM
CLOVIS closed D252: Setup JaCoCo.
May 19 2019, 12:50 PM
CLOVIS committed rLIBWFJVAf74cfc14eaeb: Setup JaCoCo (authored by CLOVIS).
Setup JaCoCo
May 19 2019, 12:50 PM
CLOVIS added inline comments to D252: Setup JaCoCo.
May 19 2019, 8:53 AM

May 16 2019

CLOVIS updated the summary of D252: Setup JaCoCo.
May 16 2019, 1:10 PM
CLOVIS added a revision to T328: Add a code coverage tool: D252: Setup JaCoCo.
May 16 2019, 1:08 PM · LibWF-java
CLOVIS created D252: Setup JaCoCo.
May 16 2019, 1:08 PM
CLOVIS triaged T374: Bug report: timeout as High priority.
May 16 2019, 12:03 PM · Server API
CLOVIS triaged T373: Bug report: HTML instead of JSON as High priority.
May 16 2019, 11:58 AM · Server API
CLOVIS committed rLIBWFJVAfc43a8407b9c: Gradle cache (authored by CLOVIS).
Gradle cache
May 16 2019, 12:01 AM

May 15 2019

CLOVIS committed rLIBWFJVA47daf60995ab: Pip cache, reports as artifacts, Gradle without daemon (authored by CLOVIS).
Pip cache, reports as artifacts, Gradle without daemon
May 15 2019, 10:29 PM
CLOVIS updated the diff for D247: Migrating from FindBugs to SpotBugs.

Rebasing everything on master

May 15 2019, 8:58 PM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
May 15 2019, 8:51 PM
CLOVIS committed rLIBWFJVA78e53107fd6e: Setup Continuous Integration via GitLab (authored by CLOVIS).
Setup Continuous Integration via GitLab
May 15 2019, 8:30 PM
CLOVIS closed T357: CI for the lib as Resolved by committing rLIBWFJVA78e53107fd6e: Setup Continuous Integration via GitLab.
May 15 2019, 8:30 PM · LibWF-java
CLOVIS committed rLIBWFJVAca0f5204d59a: Remove copyright in Gradle file (authored by CLOVIS).
Remove copyright in Gradle file
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA2342782a67ee: Use rm -f instead of a test (authored by CLOVIS).
Use rm -f instead of a test
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA52d384c2b052: Do not apply copyright on Gradle and other generated files (authored by CLOVIS).
Do not apply copyright on Gradle and other generated files
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAb09dfa42cb26: Clarify log error when api.sh doesn't find `lsof` (authored by CLOVIS).
Clarify log error when api.sh doesn't find `lsof`
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAef1b5d1b214a: Upload the JUnit results (authored by CLOVIS).
Upload the JUnit results
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA8af41a5f02e9: Fix broken api.sh for Python versions about 3.6 (authored by CLOVIS).
Fix broken api.sh for Python versions about 3.6
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA3bdb3ba4894f: Upgrade the Gradle wrapper to 5.2.1 (authored by CLOVIS).
Upgrade the Gradle wrapper to 5.2.1
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAe492584e7c6c: Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log… (authored by CLOVIS).
Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log…
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA3034004ca9d7: Test the Gradle cache before running the scripts (authored by CLOVIS).
Test the Gradle cache before running the scripts
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAdfcaf585a45f: Documentation in .gitlab-ci.yml (authored by CLOVIS).
Documentation in .gitlab-ci.yml
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA888cbde3b040: Upload JUnit results as artifacts (authored by CLOVIS).
Upload JUnit results as artifacts
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA4124365fcd96: Update the API (authored by CLOVIS).
Update the API
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA42b7ac828515: Fix query order (posts are not always in the same order) (authored by CLOVIS).
Fix query order (posts are not always in the same order)
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA6e7f9c43c340: Run Dokka alongside the unit tests, to speed up builds (authored by CLOVIS).
Run Dokka alongside the unit tests, to speed up builds
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA789e274a5a60: Reordering dependencies for clarity (authored by CLOVIS).
Reordering dependencies for clarity
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAd8130880130a: Better cache for CI (authored by CLOVIS).
Better cache for CI
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA15832588efd0: # Ceci est la combinaison de 2 commits. # Ceci est le premier message de… (authored by CLOVIS).
# Ceci est la combinaison de 2 commits. # Ceci est le premier message de…
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA064405b12051: Assume API is not running when lsof is missing (authored by CLOVIS).
Assume API is not running when lsof is missing
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA6a626246fdc6: Cleaning the Dockerfile (authored by CLOVIS).
Cleaning the Dockerfile
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAf65d2cd7e335: Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container (authored by CLOVIS).
Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA0a2c6f80b862: Do not run tests with static analysis (authored by CLOVIS).
Do not run tests with static analysis
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA618f3e84980d: Cache wheels (authored by CLOVIS).
Cache wheels
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA2cdfe42f23cf: Remove pointless lsof (authored by CLOVIS).
Remove pointless lsof
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA5445ba44e87b: Cache Gradle dependencies (authored by CLOVIS).
Cache Gradle dependencies
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAd992085f926d: Removed after_script (authored by CLOVIS).
Removed after_script
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAe956045e9f87: What is running on port 8000 in the container? (authored by CLOVIS).
What is running on port 8000 in the container?
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA57057d4fe334: Fix parallel tests when there's only 1 available core (authored by CLOVIS).
Fix parallel tests when there's only 1 available core
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA34b0db819cb4: Dockerfile with Java & Python (authored by CLOVIS).
Dockerfile with Java & Python
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA4f30c126f49b: Clone the submodule with HTTPS instead of SSH (no keys on CI servers) (authored by CLOVIS).
Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAf9e0a8491e06: Prototype of .gitlab-ci.yml (authored by CLOVIS).
Prototype of .gitlab-ci.yml
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVA887649ebdfe8: Merge branch 'master' of ssh://phabricator.wildfyre.net/source/libwf-java (authored by CLOVIS).
Merge branch 'master' of ssh://phabricator.wildfyre.net/source/libwf-java
May 15 2019, 8:29 PM
CLOVIS committed rLIBWFJVAe179e9044b78: Updating copyrights (authored by CLOVIS).
Updating copyrights
May 15 2019, 8:29 PM
CLOVIS closed D221: Internal to Kotlin.
May 15 2019, 8:29 PM
CLOVIS closed D246: Setup Continuous Integration via GitLab.
May 15 2019, 8:29 PM
CLOVIS updated the diff for D246: Setup Continuous Integration via GitLab.
  • Merge branch 'master' of ssh://phabricator.wildfyre.net/source/libwf-java
  • Prototype of .gitlab-ci.yml
  • Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
  • Fix parallel tests when there's only 1 available core
  • Dockerfile with Java & Python
  • What is running on port 8000 in the container?
  • Removed after_script
  • Cache Gradle dependencies
  • Remove pointless lsof
  • Cache wheels
  • Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
  • Assume API is not running when lsof is missing
  • Do not run tests with static analysis
  • Cleaning the Dockerfile
  • # Ceci est la combinaison de 2 commits.
  • Better cache for CI
  • Reordering dependencies for clarity
  • Pip cache, reports as artifacts, Gradle without daemon
  • Run Dokka alongside the unit tests, to speed up builds
  • Gradle cache
  • Fix query order (posts are not always in the same order)
  • Update the API
  • Upload JUnit results as artifacts
  • Test the Gradle cache before running the scripts
  • Documentation in .gitlab-ci.yml
  • Upload the JUnit results
  • Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log output)
  • Fix broken api.sh for Python versions about 3.6
  • Upgrade the Gradle wrapper to 5.2.1
  • Clarify log error when api.sh doesn't find lsof
  • Do not apply copyright on Gradle and other generated files
  • Use rm -f instead of a test
  • Remove copyright in Gradle file
May 15 2019, 8:13 PM
CLOVIS requested review of D221: Internal to Kotlin.

Please review without taking into account changes introduced by D246, it will be rebased when D246 is landed

May 15 2019, 7:28 PM
CLOVIS added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

Is this still relevant?

May 15 2019, 7:27 PM
CLOVIS added a comment to D223: Update gradle wrapper and fix dependencies. Fixes T331..

It looks like the changes here are mainly the same as D247... I know this one was made earlier but D247 is up to date with master and with the new CI system so I think it should be prioritized (unless there's something important here)

May 15 2019, 7:24 PM
CLOVIS requested review of D247: Migrating from FindBugs to SpotBugs.
May 15 2019, 7:23 PM
CLOVIS requested review of D246: Setup Continuous Integration via GitLab.
May 15 2019, 7:20 PM
CLOVIS added inline comments to D251: Reboot the Android client.
May 15 2019, 8:08 AM

May 14 2019

CLOVIS added a comment to D246: Setup Continuous Integration via GitLab.
In D246#6277, @WyldBot wrote:

You can actually probably gitignore all .idea folders/files

May 14 2019, 10:59 AM
CLOVIS requested changes to D251: Reboot the Android client.
May 14 2019, 10:40 AM
CLOVIS added a comment to D251: Reboot the Android client.
In D251#6285, @TCGman wrote:
  • For _body: this came from webcl, where it seemed to be where error messages are stored
May 14 2019, 10:39 AM
CLOVIS added inline comments to D251: Reboot the Android client.
May 14 2019, 10:34 AM
CLOVIS added a comment to D251: Reboot the Android client.
In D251#6261, @WyldBot wrote:

Gitignore all .idea folders/files

May 14 2019, 9:32 AM

May 13 2019

CLOVIS committed rLIBWFJVAe4446d5119fe: Fix minimal-json JAR not being included. (authored by Hackintosh 5 <hackintosh5@wildfyre.net>).
Fix minimal-json JAR not being included.
May 13 2019, 9:19 PM
CLOVIS committed rLIBWFJVA1a738f562e42: Fix minimal-json JAR not being included. (authored by Hackintosh 5 <hackintosh5@wildfyre.net>).
Fix minimal-json JAR not being included.
May 13 2019, 9:19 PM
CLOVIS closed D225: Fix minimal-json JAR not being included..
May 13 2019, 9:19 PM
CLOVIS closed D225: Fix minimal-json JAR not being included..
May 13 2019, 9:19 PM
CLOVIS added a comment to D251: Reboot the Android client.
In D251#6235, @TCGman wrote:

Technically I didn't "rewrite" the Git history; I just added mine on top of it... But it did erase every file, yes.

May 13 2019, 9:14 PM
CLOVIS planned changes to D210: Moving the user package to Kotlin.

This diff is based on D246, which was modified. This will need to be updated when D246 is landed.

May 13 2019, 9:12 PM
CLOVIS updated the diff for D246: Setup Continuous Integration via GitLab.
  • Remove copyright in Gradle file
May 13 2019, 9:02 PM
CLOVIS updated the diff for D246: Setup Continuous Integration via GitLab.
  • Use rm -f instead of a test
May 13 2019, 8:59 PM
CLOVIS updated the diff for D246: Setup Continuous Integration via GitLab.
  • Fix Arcanist f*ck up
May 13 2019, 8:55 PM