TOTP should be prioritized.

Maybe a variable could be added to the objects to get its new version if there is one? So the UI can know when a new one is created

The idea here would be to never modify the objects, but instead just generate a new one and discard the old one, this way it can be done in parallel extremely easily

@Hackintosh5 you didn't comment on this yet, what do you think?

Good catch

After these it'll be OK for me

Looks good to me but I honestly don't understand half of it, so I'm trusting you on that one

In D258#6553, @Hackintosh5 wrote:

Wait, we have an Android app now? And it uses React?

Can you explain what the problem exactly is? I don't see it

• Migrate from FindBugs to SpotBugs, following the steps at https://spotbugs.readthedocs.io/en/stable/migration.html
• Replace compile by api in spotbugs config

• Moving User from Java to Kotlin
• Rename .java to .kt
• Moving Users from Java to Kotlin
• Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
• Rename .java to .kt
• Converting LoggedUser to Kotlin
• Added JsonValue.minimalString & JsonValue.prettyString
• Adding LoggedUser.postsList so that Java code can access the posts
• IssueInTransferException is now able to report on messages that do not parse to JSON
• Better Kotlin integration

In D210#6427, @WyldBot wrote:

May need rebase again though

Rebasing everything on master

• Moving User from Java to Kotlin
• Rename .java to .kt
• Moving Users from Java to Kotlin
• Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
• Rename .java to .kt
• Converting LoggedUser to Kotlin
• Added JsonValue.minimalString & JsonValue.prettyString
• Adding LoggedUser.postsList so that Java code can access the posts
• IssueInTransferException is now able to report on messages that do not parse to JSON
• Better Kotlin integration

• Merge branch 'master' of ssh://phabricator.wildfyre.net/source/libwf-java
• Prototype of .gitlab-ci.yml
• Clone the submodule with HTTPS instead of SSH (no keys on CI servers)
• Fix parallel tests when there's only 1 available core
• Dockerfile with Java & Python
• What is running on port 8000 in the container?
• Removed after_script
• Cache Gradle dependencies
• Remove pointless lsof
• Cache wheels
• Add virtualenv, PostGresQL, Git, OpenJDK sources, GCC to the container
• Assume API is not running when lsof is missing
• Do not run tests with static analysis
• Cleaning the Dockerfile
• # Ceci est la combinaison de 2 commits.
• Better cache for CI
• Reordering dependencies for clarity
• Pip cache, reports as artifacts, Gradle without daemon
• Run Dokka alongside the unit tests, to speed up builds
• Gradle cache
• Fix query order (posts are not always in the same order)
• Update the API
• Upload JUnit results as artifacts
• Test the Gradle cache before running the scripts
• Documentation in .gitlab-ci.yml
• Upload the JUnit results
• Do not delete the file db.sqlite3 if it doesn't exists (to have a cleaner log output)
• Fix broken api.sh for Python versions about 3.6
• Upgrade the Gradle wrapper to 5.2.1
• Clarify log error when api.sh doesn't find lsof
• Do not apply copyright on Gradle and other generated files
• Use rm -f instead of a test
• Remove copyright in Gradle file

Please review without taking into account changes introduced by D246, it will be rebased when D246 is landed

Is this still relevant?

It looks like the changes here are mainly the same as D247... I know this one was made earlier but D247 is up to date with master and with the new CI system so I think it should be prioritized (unless there's something important here)

In D246#6277, @WyldBot wrote:

You can actually probably gitignore all .idea folders/files

In D251#6285, @TCGman wrote:

• For _body: this came from webcl, where it seemed to be where error messages are stored

In D251#6261, @WyldBot wrote:

Gitignore all .idea folders/files

In D251#6235, @TCGman wrote:

Technically I didn't "rewrite" the Git history; I just added mine on top of it... But it did erase every file, yes.

This diff is based on D246, which was modified. This will need to be updated when D246 is landed.

• Remove copyright in Gradle file

• Use rm -f instead of a test

• Fix Arcanist f*ck up