Page MenuHomePhabricator

CLOVIS (Ivan Canet)
Android & Java dev, responsible of the Java lib and the Android app

Projects

User Details

User Since
Apr 22 2018, 5:40 PM (43 w, 2 d)

Recent Activity

Sat, Feb 16

CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Moving User from Java to Kotlin
  • Rename .java to .kt
  • Moving Users from Java to Kotlin
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • Added JsonValue.minimalString & JsonValue.prettyString
  • Adding LoggedUser.postsList so that Java code can access the posts
  • No more parallel unit tests (the testing server can't handle them)
  • IssueInTransferException is now able to report on messages that do not parse to JSON
  • Better Kotlin integration
Sat, Feb 16, 10:59 AM
CLOVIS updated the summary of D210: Moving the user package to Kotlin.
Sat, Feb 16, 10:53 AM

Wed, Feb 13

CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 11:03 AM
CLOVIS committed rLIBWFJVA21af00520a64: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS committed rLIBWFJVA46200011c189: Fix for Ubuntu 18.04 (authored by Hackintosh5).
Fix for Ubuntu 18.04
Wed, Feb 13, 8:14 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS closed D213: Fix for Ubuntu 18.04.
Wed, Feb 13, 8:13 AM
CLOVIS accepted D213: Fix for Ubuntu 18.04.

I just tested it, it works, so that's getting landed.

Wed, Feb 13, 8:13 AM
CLOVIS committed rLIBWFJVA64d73b1528ba: Updating server API (authored by CLOVIS).
Updating server API
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVAc5ce043fa261: Conforming to new password requirements in D203 (authored by CLOVIS).
Conforming to new password requirements in D203
Wed, Feb 13, 8:10 AM
CLOVIS committed rLIBWFJVA85d49f0b1e31: Mise à jour de l'API (authored by CLOVIS).
Mise à jour de l'API
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203 as Resolved by committing rLIBWFJVA64d73b1528ba: Updating server API.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS closed D220: Updating server API.
Wed, Feb 13, 8:10 AM
CLOVIS closed T313: Update tests after D203, a subtask of T311: Link the lib version with the API version, as Resolved.
Wed, Feb 13, 8:10 AM · LibWF-java
CLOVIS updated the diff for D222: Fix missing minimal-json is exported JAR.
  • Changing to "API" scope
Wed, Feb 13, 8:07 AM

Mon, Feb 11

CLOVIS added a comment to T328: Add a code coverage tool.

Basically a tool that looks at what your unit tests do and tries to find cases you might have forgotten

Mon, Feb 11, 6:38 AM · LibWF-java
CLOVIS added a comment to D222: Fix missing minimal-json is exported JAR.

Todo: use "api"

Mon, Feb 11, 6:34 AM

Sun, Feb 10

CLOVIS updated subscribers of T328: Add a code coverage tool.

@Hackintosh5 would you know how to include this in your gradle engine?

Sun, Feb 10, 6:39 PM · LibWF-java
CLOVIS claimed T329: Minimal-json is missing from the archive.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM
CLOVIS added a revision to T329: Minimal-json is missing from the archive: D222: Fix missing minimal-json is exported JAR.
Sun, Feb 10, 6:38 PM · LibWF-java
CLOVIS created D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM
CLOVIS added a revision to T272: Convert API to Kotlin: D221: Internal to Kotlin.
Sun, Feb 10, 6:31 PM · LibWF-java
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

I know how to squash with a rebase if that's what you mean?

Sun, Feb 10, 5:58 PM

Sat, Feb 9

CLOVIS requested changes to D211: Fix test password.

I can't close the revision, so I'm just going to request changes :/

Sat, Feb 9, 9:46 PM
CLOVIS added a comment to D211: Fix test password.

Because that revision requires submodule meddling, I've made D220. This one won't be merged.

Sat, Feb 9, 9:46 PM
CLOVIS created D220: Updating server API.
Sat, Feb 9, 9:41 PM
CLOVIS added a revision to T313: Update tests after D203: D220: Updating server API.
Sat, Feb 9, 9:41 PM · LibWF-java
CLOVIS added a comment to D210: Moving the user package to Kotlin.

@Info-Screen this was thrown by the API during testing for this diff:

Sat, Feb 9, 9:00 PM
CLOVIS updated the diff for D212: Copyright update.

Rebasing to master to get the new unit tester that is not buggy

Sat, Feb 9, 8:45 PM
CLOVIS committed rLIBWFJVA10a3e6ad57c4: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM
CLOVIS committed rLIBWFJVA3a9c702df40f: Add arc unit engine for gradle (authored by Hackintosh5).
Add arc unit engine for gradle
Sat, Feb 9, 8:05 PM
CLOVIS closed T315: Better unit tests for Phabricator as Resolved by committing rLIBWFJVA10a3e6ad57c4: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM · LibWF-java
CLOVIS closed T315: Better unit tests for Phabricator as Resolved by committing rLIBWFJVA3a9c702df40f: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM · LibWF-java
CLOVIS closed D218: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM
CLOVIS closed D218: Add arc unit engine for gradle.
Sat, Feb 9, 8:05 PM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

Is this ready for landing? Or do you plan to change other things

Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVAcde5faba4b79: Fix compilation for users without nexus authentication (authored by Hackintosh5).
Fix compilation for users without nexus authentication
Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVAf8ceb343daaf: Fix compilation for users without nexus authentication (authored by Hackintosh5).
Fix compilation for users without nexus authentication
Sat, Feb 9, 10:11 AM
CLOVIS closed D216: Fix compilation for users without nexus authentication.
Sat, Feb 9, 10:11 AM
CLOVIS closed D216: Fix compilation for users without nexus authentication.
Sat, Feb 9, 10:11 AM
CLOVIS committed rLIBWFJVA4684b374d255: Increase test timeout to prevent occasional failures (authored by Hackintosh5).
Increase test timeout to prevent occasional failures
Sat, Feb 9, 10:09 AM
CLOVIS committed rLIBWFJVAb0b25b7d8dd9: Increase test timeout to prevent occasional failures (authored by Hackintosh5).
Increase test timeout to prevent occasional failures
Sat, Feb 9, 10:09 AM
CLOVIS closed D219: Increase test timeout to prevent occasional failures.
Sat, Feb 9, 10:09 AM
CLOVIS closed D219: Increase test timeout to prevent occasional failures.
Sat, Feb 9, 10:09 AM
CLOVIS accepted D218: Add arc unit engine for gradle.
Sat, Feb 9, 9:39 AM

Wed, Feb 6

CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

Oh. Okay, remove the "fixes t..." from the description here, otherwise pantocrator will close the task. I'm probably going to test all your diffs this week end.

Wed, Feb 6, 7:10 AM
CLOVIS updated subscribers of D213: Fix for Ubuntu 18.04.

Blocking means I'm a mandatory reviewer ^^

Wed, Feb 6, 7:06 AM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

They sounds odd to me. I'll need to benchmark this on my machine to see exactly. You didn't forget to do the migrations, download the dependencies, etc?

Wed, Feb 6, 7:03 AM

Tue, Feb 5

CLOVIS added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:13 PM
CLOVIS updated subscribers of D219: Increase test timeout to prevent occasional failures.

I've tried to land things before, it says I don't have access (403)...

Tue, Feb 5, 8:12 PM
CLOVIS requested changes to D214: Convert WildFyre.java to Kotlin.

Looks good to me so far, but you need to do the Internal class too (in the same way).

Tue, Feb 5, 6:04 PM
CLOVIS added a comment to D213: Fix for Ubuntu 18.04.

@CLOVIS why have you rejected this?

Tue, Feb 5, 6:01 PM
CLOVIS added a comment to T265: Unable to login with provided credentials.

It would be better to check for the http sttlatus code, instead of trying to parse the json.

Tue, Feb 5, 5:56 PM · LibWF-java
CLOVIS added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 5:52 PM
CLOVIS added a comment to D219: Increase test timeout to prevent occasional failures.

To push such a small modification, use "Arc land --squashed". This will not clutter the history as much

Tue, Feb 5, 5:49 PM
CLOVIS accepted D219: Increase test timeout to prevent occasional failures.
Tue, Feb 5, 5:48 PM
CLOVIS added a comment to D218: Add arc unit engine for gradle.
  • Autostart the development API if it's not running already, and stop it again when we're done.
Tue, Feb 5, 2:41 PM
CLOVIS requested changes to D214: Convert WildFyre.java to Kotlin.
Tue, Feb 5, 6:43 AM
CLOVIS added a comment to D218: Add arc unit engine for gradle.

I need to test this locally before accepting, just to be sure. Sorry, it might take a few days before I have the time.

Tue, Feb 5, 6:40 AM
CLOVIS accepted D216: Fix compilation for users without nexus authentication.
Tue, Feb 5, 6:38 AM
CLOVIS added a comment to D216: Fix compilation for users without nexus authentication.
In D216#5160, @CLOVIS wrote:

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Otherwise there's a parse time error; gradle is evaluating the ext.nexusUsername and since it can't be resolved, it fails to parse the build.gradle, leading to me being unable to build. This just delays that error until deployment time (which is impossible without nexusUsername/Password)

Tue, Feb 5, 6:37 AM
CLOVIS added 1 blocking reviewer(s) for D218: Add arc unit engine for gradle: CLOVIS.
Tue, Feb 5, 6:36 AM
CLOVIS added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 6:35 AM

Mon, Feb 4

CLOVIS added a comment to D216: Fix compilation for users without nexus authentication.

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Mon, Feb 4, 12:39 PM
CLOVIS added reviewers for D216: Fix compilation for users without nexus authentication: CLOVIS, WyldBot, Info-Screen.
Mon, Feb 4, 12:38 PM

Sun, Feb 3

CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

You will also need to convert Internal, in the same way

Sun, Feb 3, 9:15 PM
CLOVIS added a revision to T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Sun, Feb 3, 9:14 PM · LibWF-java
CLOVIS updated the summary of D214: Convert WildFyre.java to Kotlin.
Sun, Feb 3, 9:14 PM
CLOVIS updated the summary of D214: Convert WildFyre.java to Kotlin.
Sun, Feb 3, 9:14 PM
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

When you create a diff, please remember to add "Fix [task]" in the summary. I'll do it this time, but try to remember for next time.

Sun, Feb 3, 9:13 PM
CLOVIS added inline comments to D214: Convert WildFyre.java to Kotlin.
Sun, Feb 3, 9:12 PM
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5119, @CLOVIS wrote:

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

I don't like having global methods though, it's just not clean

Mhm, I'll move to a companion object tonight then.

Sun, Feb 3, 9:11 PM
CLOVIS added a comment to D214: Convert WildFyre.java to Kotlin.

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

Sun, Feb 3, 3:18 PM
CLOVIS requested changes to D214: Convert WildFyre.java to Kotlin.

You removed the "WildFyre" class...

Sun, Feb 3, 11:31 AM

Sat, Feb 2

CLOVIS planned changes to D212: Copyright update.

You can accept it if you want, but arc lint reports some errors for some reason, this is not getting merged until I completely understand where that comes from.

Sat, Feb 2, 6:20 PM
CLOVIS added a reviewer for D213: Fix for Ubuntu 18.04: CLOVIS.
Sat, Feb 2, 8:18 AM

Fri, Feb 1

CLOVIS raised the priority of T315: Better unit tests for Phabricator from Low to High.

I'm really tired of Arcanist doing incomprehensible things with the unit tests, so I'm doing this *right now*.

Fri, Feb 1, 10:05 PM · LibWF-java
CLOVIS moved T315: Better unit tests for Phabricator from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Fri, Feb 1, 10:04 PM · LibWF-java
CLOVIS added a comment to D211: Fix test password.

Yes and no, because of how Arc works, unit tests are categorized as "lint", it's normal (as of now, I will try to change that someday if I get time). It's possible that it doesn't run tests because you only modified tests? I need to check into that.

Fri, Feb 1, 9:29 PM
CLOVIS created D212: Copyright update.
Fri, Feb 1, 8:06 PM
CLOVIS added a revision to T308: Update Copyrights: D212: Copyright update.
Fri, Feb 1, 8:06 PM · Android, LibWF-java
CLOVIS added a subtask for T329: Minimal-json is missing from the archive: T268: Kotlin + Java 7.
Fri, Feb 1, 5:05 PM · LibWF-java
CLOVIS added a parent task for T268: Kotlin + Java 7: T329: Minimal-json is missing from the archive.
Fri, Feb 1, 5:05 PM · LibWF-java
CLOVIS triaged T329: Minimal-json is missing from the archive as High priority.
Fri, Feb 1, 5:04 PM · LibWF-java
CLOVIS added a comment to D211: Fix test password.

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

Fri, Feb 1, 1:53 PM

Thu, Jan 31

CLOVIS planned changes to D210: Moving the user package to Kotlin.
Thu, Jan 31, 10:20 PM
CLOVIS added inline comments to D210: Moving the user package to Kotlin.
Thu, Jan 31, 10:20 PM
CLOVIS updated the diff for D210: Moving the user package to Kotlin.
  • Explaining why the let is ?.let and not !!.let & fixing broken Dokka link
  • Rename .java to .kt
  • Converting LoggedUser to Kotlin
  • TEMPORARY, TO BE REMOVED BEFORE LANDING
Thu, Jan 31, 10:17 PM
CLOVIS added a subtask for T235: Fix Not a String exception: T268: Kotlin + Java 7.
Thu, Jan 31, 9:01 PM · LibWF-java
CLOVIS added a parent task for T268: Kotlin + Java 7: T235: Fix Not a String exception.
Thu, Jan 31, 9:01 PM · LibWF-java
CLOVIS closed T263: Code duplication in the Cache, a subtask of T269: Convert users to Kotlin, as Invalid.
Thu, Jan 31, 9:00 PM · LibWF-java
CLOVIS closed T263: Code duplication in the Cache as Invalid.

Pointless now that T291 has that many changes

Thu, Jan 31, 9:00 PM · LibWF-java
CLOVIS closed T263: Code duplication in the Cache, a subtask of T270: Convert posts to Kotlin, as Invalid.
Thu, Jan 31, 9:00 PM · LibWF-java
CLOVIS closed T263: Code duplication in the Cache, a subtask of T271: Convert areas to kotlin, as Invalid.
Thu, Jan 31, 9:00 PM · LibWF-java
CLOVIS closed T263: Code duplication in the Cache, a subtask of T273: Convert descriptors to Kotlin, as Invalid.
Thu, Jan 31, 9:00 PM · LibWF-java
CLOVIS moved T291: Cache management V2 from Pending / Unconfirmed to Internals: Descriptors & Requests on the LibWF-java board.
Thu, Jan 31, 8:59 PM · LibWF-java
CLOVIS moved T328: Add a code coverage tool from Pending / Unconfirmed to Miscellaneous on the LibWF-java board.
Thu, Jan 31, 8:59 PM · LibWF-java