Page MenuHomePhabricator

Hackintosh5 (Hackintosh5)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2019, 5:32 PM (28 w, 5 d)

Recent Activity

Jul 3 2019

Hackintosh5 added a comment to T291: Cache management V2.

I meant a callback. So you pass a callback into the code to request an object, and it is called with the new object as the only parameter when the cache update is complete, if and only if the object is actually different

Jul 3 2019, 4:23 PM · LibWF-java
Hackintosh5 added a comment to T291: Cache management V2.

Tbh I think we need some system to inform the client when an object has been updated. So that the UI can be updated when an update is performed without closing and reopening something (if you close and reopen a page the old data is displayed because the UI is loaded before the cache is refreshed

Jul 3 2019, 4:02 PM · LibWF-java
Hackintosh5 added a comment to D256: Increase coverage to 70%.

All resolved.

Jul 3 2019, 12:10 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Jul 3 2019, 12:03 PM
Hackintosh5 added a comment to D258: Fix Android ANR's.

Oh, I understand. It's committed to webcl (web client), but its a fix for the webview app, which loads webcl.

Jul 3 2019, 12:00 PM
Hackintosh5 added a comment to D258: Fix Android ANR's.
In D258#6561, @CLOVIS wrote:

Wait, we have an Android app now? And it uses React?

I think it's about the currently used webapp?

Jul 3 2019, 11:59 AM
Hackintosh5 abandoned D257: Ignore captcha failures in development mode.

Anyway this doesn't actually fix the issue. Other stuff fails and I won't bother.

Jul 3 2019, 7:37 AM
Hackintosh5 updated the diff for D256: Increase coverage to 70%.
  • Remove extraneous System.out.println
Jul 3 2019, 7:27 AM
Hackintosh5 resigned from D258: Fix Android ANR's.

Wait, we have an Android app now? And it uses React?

Jul 3 2019, 6:27 AM

Jul 2 2019

Hackintosh5 removed 1 blocking reviewer(s) for D254: Able to retrieve queue of posts: Info-Screen.
Jul 2 2019, 8:43 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Jul 2 2019, 8:39 PM
Hackintosh5 added a comment to D257: Ignore captcha failures in development mode.

Because I'm lazy

Jul 2 2019, 8:21 PM
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

Try making a test to edit the server draft (.save().setText().save()) and check the coverage. The method to edit server draft is never called.

Jul 2 2019, 8:21 PM · LibWF-java
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

isLocalOnly is only set to false in the else clause.
So it's set to false (meaning uploaded to server) only if we edit the server draft. And we only edit the server draft if it's set to false! So it's never changed.

Jul 2 2019, 8:20 PM · LibWF-java
Hackintosh5 closed T329: Minimal-json is missing from the archive as Resolved.

Fixed in D225

Jul 2 2019, 12:46 PM · LibWF-java
Hackintosh5 added a comment to D227: Downgrade SpotBugs to remove deprecation warning.
In D227#6354, @CLOVIS wrote:

Is this still relevant?

Jul 2 2019, 12:44 PM
Hackintosh5 added inline comments to D256: Increase coverage to 70%.
Jul 2 2019, 12:11 PM
Hackintosh5 abandoned D214: Convert WildFyre.java to Kotlin.
Jul 2 2019, 12:08 PM
Hackintosh5 created D257: Ignore captcha failures in development mode.
Jul 2 2019, 12:03 PM
Hackintosh5 created D256: Increase coverage to 70%.
Jul 2 2019, 11:08 AM
Hackintosh5 updated the diff for D255: Fix bad logic in Draft isOnlyLocal.

Fix tests

  • Don't require active property in JSON as it's not present for Drafts
  • Fix draft deletion
Jul 2 2019, 9:26 AM
Hackintosh5 added a comment to D255: Fix bad logic in Draft isOnlyLocal.

Tests pass but an exception is suppressed. I've fixed that exception and I'm fixing the next one, I'll update the diff later. The exceptions are due to errors in main not in the test

Jul 2 2019, 9:14 AM
Hackintosh5 added a revision to T378: Logic error in Draft isOnlyLocal: D255: Fix bad logic in Draft isOnlyLocal.
Jul 2 2019, 9:05 AM · LibWF-java
Hackintosh5 created D255: Fix bad logic in Draft isOnlyLocal.
Jul 2 2019, 9:05 AM
Hackintosh5 claimed T378: Logic error in Draft isOnlyLocal.
Jul 2 2019, 9:04 AM · LibWF-java
Hackintosh5 reopened T378: Logic error in Draft isOnlyLocal as "Open".

No, this is valid

Jul 2 2019, 9:03 AM · LibWF-java
Hackintosh5 closed T378: Logic error in Draft isOnlyLocal as Invalid.
Jul 2 2019, 8:06 AM · LibWF-java
Hackintosh5 added a comment to T378: Logic error in Draft isOnlyLocal.

Damn I can't read

Jul 2 2019, 8:06 AM · LibWF-java
Hackintosh5 triaged T378: Logic error in Draft isOnlyLocal as High priority.
Jul 2 2019, 7:37 AM · LibWF-java

Jul 1 2019

Hackintosh5 claimed T376: Telegram Bot.

Authentication might be difficult.

Jul 1 2019, 12:16 PM
Hackintosh5 updated the diff for D254: Able to retrieve queue of posts.
  • Remove extraneous character in comment
Jul 1 2019, 11:45 AM
Hackintosh5 updated the diff for D254: Able to retrieve queue of posts.
  • Remove test code
Jul 1 2019, 11:44 AM
Hackintosh5 added a revision to T377: Able to get queue of posts: D254: Able to retrieve queue of posts.
Jul 1 2019, 10:06 AM · LibWF-java
Hackintosh5 added a task to D254: Able to retrieve queue of posts: T377: Able to get queue of posts.
Jul 1 2019, 10:06 AM
Hackintosh5 created D254: Able to retrieve queue of posts.
Jul 1 2019, 10:06 AM
Hackintosh5 created D253: Update gradle to 5.5.
Jul 1 2019, 10:03 AM
Hackintosh5 added a subtask for T363: Release 1.0: T377: Able to get queue of posts.
Jul 1 2019, 10:02 AM · LibWF-java
Hackintosh5 added a parent task for T377: Able to get queue of posts: T363: Release 1.0.
Jul 1 2019, 10:02 AM · LibWF-java
Hackintosh5 created T377: Able to get queue of posts.
Jul 1 2019, 10:01 AM · LibWF-java
Hackintosh5 abandoned D223: Update gradle wrapper and fix dependencies. Fixes T331..
In D223#6352, @CLOVIS wrote:

It looks like the changes here are mainly the same as D247... I know this one was made earlier but D247 is up to date with master and with the new CI system so I think it should be prioritized (unless there's something important here)

Jul 1 2019, 9:56 AM
Hackintosh5 accepted D247: Migrating from FindBugs to SpotBugs.

Can we get this or something similar in please, I've been trying for months and these deprecation warnings are annoying me

Jul 1 2019, 9:42 AM

May 18 2019

Hackintosh5 resigned from D252: Setup JaCoCo.
May 18 2019, 7:24 AM

May 13 2019

Hackintosh5 added a comment to D251: Reboot the Android client.

WyldBot, why not fix the library then? I was going to do that but y'all told me the server isn't stable yet. So why aren't we versioning the api server endpoints?

May 13 2019, 6:07 AM

May 12 2019

Hackintosh5 requested changes to D251: Reboot the Android client.

I think you should focus on using wflib rather than rewriting the array.

May 12 2019, 7:45 PM

Apr 27 2019

Hackintosh5 added a comment to D246: Setup Continuous Integration via GitLab.

Wel I have no idea how that works. You can commandeer this and fix it as I don't know what's wrong or how to fix it

Apr 27 2019, 9:23 AM

Apr 26 2019

Hackintosh5 added a comment to D246: Setup Continuous Integration via GitLab.

So there was never a PGP signature anyway? It only ever existed on your local machine?

Apr 26 2019, 7:03 AM

Apr 25 2019

Hackintosh5 added a comment to D246: Setup Continuous Integration via GitLab.

Dude. That commit was never signed. I just checked out arc revision 877 which is your original commit. I ran git show HEAD but there's no signature below the commit message.

Apr 25 2019, 12:59 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..

Remove programming by exception

Apr 25 2019, 12:47 PM
Hackintosh5 added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

This comes from D223. I'll deal with it's issues now.

Apr 25 2019, 12:03 PM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

Right, it applies over master now.

Apr 25 2019, 11:50 AM
Hackintosh5 updated the diff for D225: Fix minimal-json JAR not being included..

Fix minimal-json JAR not being included.

Apr 25 2019, 11:49 AM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

Arc broke. I didn't update the copyrights.

Apr 25 2019, 11:47 AM
Hackintosh5 added a comment to D246: Setup Continuous Integration via GitLab.

I haven't removed your commits....

Apr 25 2019, 11:25 AM
Hackintosh5 updated the diff for D225: Fix minimal-json JAR not being included..

Fix minimal-json JAR not being included.

Apr 25 2019, 10:20 AM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

I just searched phabricator the commit is not here, even in unmerged diffs. I'll abandon this and open a new one against master, I suppose

Apr 25 2019, 10:11 AM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

I have no idea when no.
And yes, they must be duplicated.

Apr 25 2019, 9:57 AM
Hackintosh5 updated the diff for D246: Setup Continuous Integration via GitLab.

Fix background invocation

Apr 25 2019, 9:52 AM
Hackintosh5 updated the diff for D246: Setup Continuous Integration via GitLab.

Fix stuff

  • Fix bad copyrights
  • Don't start API when --norun is specified
  • Use rm -f instead of test -f
Apr 25 2019, 9:50 AM
Hackintosh5 commandeered D246: Setup Continuous Integration via GitLab.
Apr 25 2019, 7:51 AM

Apr 24 2019

Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Apr 24 2019, 2:33 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Apr 24 2019, 2:22 PM
Hackintosh5 added a comment to D244: Get repo code somewhat up to date with current app.
In D244#6038, @WyldBot wrote:

Add a .gitignore to hide .DS_Store files and all files in the Pods folder

Apr 24 2019, 1:25 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Apr 24 2019, 1:14 PM
Hackintosh5 added inline comments to D246: Setup Continuous Integration via GitLab.
Apr 24 2019, 1:02 PM
Hackintosh5 added a comment to D244: Get repo code somewhat up to date with current app.

Lint lines are too long. Check my inline comment in AlertChildPageViewController.xib:2

Apr 24 2019, 12:58 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Apr 24 2019, 12:54 PM
Hackintosh5 abandoned D226: We don't need spotbugs on the tests since they aren't used in production..

Oh ok.

Apr 24 2019, 12:47 PM
Hackintosh5 requested changes to D221: Internal to Kotlin.

Needs same changes as D246 and D247

Apr 24 2019, 12:09 PM
Hackintosh5 requested changes to D246: Setup Continuous Integration via GitLab.
Apr 24 2019, 12:06 PM
Hackintosh5 added inline comments to D246: Setup Continuous Integration via GitLab.
Apr 24 2019, 12:06 PM
Hackintosh5 requested changes to D247: Migrating from FindBugs to SpotBugs.
Apr 24 2019, 11:51 AM

Apr 23 2019

Hackintosh5 abandoned D224: Fix unit tester.
Apr 23 2019, 9:56 AM
Hackintosh5 commandeered D224: Fix unit tester.
Apr 23 2019, 9:56 AM

Apr 20 2019

Hackintosh5 requested changes to D221: Internal to Kotlin.

Can you check that the unit tests pass? Gradle skipped them so I guess they do but just to be sure

Apr 20 2019, 2:31 AM

Apr 19 2019

Hackintosh5 added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

Again my source has been nuked. Can you just merge the diff?

Apr 19 2019, 3:19 AM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

Hmmm I've nuked my source tree so if it's not there it's not there. Is there a way to just apply the diff?

Apr 19 2019, 3:18 AM
Hackintosh5 reclaimed D226: We don't need spotbugs on the tests since they aren't used in production..

Something is needed, at least. check is the wrong command; we should use either spotbugsMain spotbugsTest or spotbugsMain.

Apr 19 2019, 3:07 AM
Hackintosh5 commandeered D226: We don't need spotbugs on the tests since they aren't used in production..
Apr 19 2019, 3:03 AM

Apr 3 2019

Hackintosh5 accepted D237: Fix split error.

Tested by manually setting localStorage.blockedUsers = "", now it works.

Apr 3 2019, 7:44 PM
Hackintosh5 triaged T343: Firefox clients cannot use WildFyre as Unbreak Now! priority.
Apr 3 2019, 7:36 PM · Web

Mar 17 2019

Hackintosh5 added a comment to T200: Unknown User Interface.

Wait, is this for the Client (web) or app?
And IMO the anonymous token should not be a token but a username/password combo that's only usable on /anonymous endpoints, and you don't register an anonymous account but change the username and password to a new one.

Mar 17 2019, 4:25 PM · Client, Server API

Mar 6 2019

Hackintosh5 created D227: Downgrade SpotBugs to remove deprecation warning.
Mar 6 2019, 9:56 AM
Hackintosh5 created D226: We don't need spotbugs on the tests since they aren't used in production..
Mar 6 2019, 9:42 AM

Mar 1 2019

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

This didn't fix minimal-json exporting correctly anyway. I've tested it in D225 and it works. I think this can be abandoned.

Mar 1 2019, 2:30 PM
Hackintosh5 created D225: Fix minimal-json JAR not being included..
Mar 1 2019, 2:27 PM
Hackintosh5 added a comment to T331: Kotlin-based projects cannot use libwf-java.

I know.

Mar 1 2019, 2:24 PM · LibWF-java

Feb 28 2019

Hackintosh5 added a comment to D224: Fix unit tester.

Note that task.state.executed does not check if the task ran, but if the task ran or was already up to date. That means that if a dependency failed, it will return false.

Feb 28 2019, 5:03 PM
Hackintosh5 added a comment to D223: Update gradle wrapper and fix dependencies. Fixes T331..

Made spotbugs ignore these security errors in the tests. In IssueWithTransferException, it is absolutely correct, that could *in some extreme cases where someone is abusing the API*, cause a crash.

Feb 28 2019, 5:02 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Make SpotBugs sad :(
  • Make SpotBugs ignore security errors in the RequestTest
Feb 28 2019, 4:58 PM
Hackintosh5 created D224: Fix unit tester.
Feb 28 2019, 3:47 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Derp 2
Feb 28 2019, 3:28 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:16 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Derp
Feb 28 2019, 3:13 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:10 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:01 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:57 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:55 PM
Hackintosh5 added a task to D223: Update gradle wrapper and fix dependencies. Fixes T331.: T331: Kotlin-based projects cannot use libwf-java.
Feb 28 2019, 2:24 PM
Hackintosh5 added a revision to T331: Kotlin-based projects cannot use libwf-java: D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:24 PM · LibWF-java
Hackintosh5 created D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:22 PM