- User Since
- Jan 28 2019, 5:32 PM (36 w, 6 d)
Fri, Oct 4
Sep 7 2019
Superseded by D259
Jul 3 2019
I meant a callback. So you pass a callback into the code to request an object, and it is called with the new object as the only parameter when the cache update is complete, if and only if the object is actually different
Tbh I think we need some system to inform the client when an object has been updated. So that the UI can be updated when an update is performed without closing and reopening something (if you close and reopen a page the old data is displayed because the UI is loaded before the cache is refreshed
Oh, I understand. It's committed to webcl (web client), but its a fix for the webview app, which loads webcl.
Anyway this doesn't actually fix the issue. Other stuff fails and I won't bother.
- Remove extraneous System.out.println
Wait, we have an Android app now? And it uses React?
Jul 2 2019
Because I'm lazy
Try making a test to edit the server draft (.save().setText().save()) and check the coverage. The method to edit server draft is never called.
isLocalOnly is only set to false in the else clause.
So it's set to false (meaning uploaded to server) only if we edit the server draft. And we only edit the server draft if it's set to false! So it's never changed.
Fixed in D225
- Don't require active property in JSON as it's not present for Drafts
- Fix draft deletion
Tests pass but an exception is suppressed. I've fixed that exception and I'm fixing the next one, I'll update the diff later. The exceptions are due to errors in main not in the test
No, this is valid
Damn I can't read
Jul 1 2019
- Remove extraneous character in comment
- Remove test code
Can we get this or something similar in please, I've been trying for months and these deprecation warnings are annoying me
May 18 2019
May 13 2019
WyldBot, why not fix the library then? I was going to do that but y'all told me the server isn't stable yet. So why aren't we versioning the api server endpoints?
May 12 2019
I think you should focus on using wflib rather than rewriting the array.
Apr 27 2019
Wel I have no idea how that works. You can commandeer this and fix it as I don't know what's wrong or how to fix it
Apr 26 2019
So there was never a PGP signature anyway? It only ever existed on your local machine?
Apr 25 2019
Dude. That commit was never signed. I just checked out arc revision 877 which is your original commit. I ran git show HEAD but there's no signature below the commit message.
Remove programming by exception
This comes from D223. I'll deal with it's issues now.
Right, it applies over master now.
Fix minimal-json JAR not being included.
Arc broke. I didn't update the copyrights.
I haven't removed your commits....
Fix minimal-json JAR not being included.
I just searched phabricator the commit is not here, even in unmerged diffs. I'll abandon this and open a new one against master, I suppose
I have no idea when no.
And yes, they must be duplicated.
Fix background invocation
- Fix bad copyrights
- Don't start API when --norun is specified
- Use rm -f instead of test -f
Apr 24 2019
Lint lines are too long. Check my inline comment in AlertChildPageViewController.xib:2
Apr 23 2019
Apr 20 2019
Can you check that the unit tests pass? Gradle skipped them so I guess they do but just to be sure
Apr 19 2019
Again my source has been nuked. Can you just merge the diff?
Hmmm I've nuked my source tree so if it's not there it's not there. Is there a way to just apply the diff?
Something is needed, at least. check is the wrong command; we should use either spotbugsMain spotbugsTest or spotbugsMain.
Apr 3 2019
Tested by manually setting localStorage.blockedUsers = "", now it works.
Mar 17 2019
Wait, is this for the Client (web) or app?
And IMO the anonymous token should not be a token but a username/password combo that's only usable on /anonymous endpoints, and you don't register an anonymous account but change the username and password to a new one.
Mar 6 2019
Mar 1 2019
This didn't fix minimal-json exporting correctly anyway. I've tested it in D225 and it works. I think this can be abandoned.
Feb 28 2019
Note that task.state.executed does not check if the task ran, but if the task ran or was already up to date. That means that if a dependency failed, it will return false.
Made spotbugs ignore these security errors in the tests. In IssueWithTransferException, it is absolutely correct, that could *in some extreme cases where someone is abusing the API*, cause a crash.
- Make SpotBugs sad :(
- Make SpotBugs ignore security errors in the RequestTest
- Derp 2