- User Since
- Jan 28 2019, 5:32 PM (12 w, 2 d)
Lint lines are too long. Check my inline comment in AlertChildPageViewController.xib:2
Sat, Apr 20
Can you check that the unit tests pass? Gradle skipped them so I guess they do but just to be sure
Fri, Apr 19
Again my source has been nuked. Can you just merge the diff?
Hmmm I've nuked my source tree so if it's not there it's not there. Is there a way to just apply the diff?
Something is needed, at least. check is the wrong command; we should use either spotbugsMain spotbugsTest or spotbugsMain.
Wed, Apr 3
Tested by manually setting localStorage.blockedUsers = "", now it works.
Mar 17 2019
Wait, is this for the Client (web) or app?
And IMO the anonymous token should not be a token but a username/password combo that's only usable on /anonymous endpoints, and you don't register an anonymous account but change the username and password to a new one.
Mar 6 2019
Mar 1 2019
This didn't fix minimal-json exporting correctly anyway. I've tested it in D225 and it works. I think this can be abandoned.
Feb 28 2019
Note that task.state.executed does not check if the task ran, but if the task ran or was already up to date. That means that if a dependency failed, it will return false.
Made spotbugs ignore these security errors in the tests. In IssueWithTransferException, it is absolutely correct, that could *in some extreme cases where someone is abusing the API*, cause a crash.
- Make SpotBugs sad :(
- Make SpotBugs ignore security errors in the RequestTest
- Derp 2
It no longer merges onto master, and it doesn't work anyway. New revision incoming, as well as a bug report.
Feb 27 2019
Feb 20 2019
Feb 13 2019
https://stackoverflow.com/questions/44413952/gradle-implementation-vs-api-configuration suggests that findBugs should be implementation not api.
You're right. But D217 is the way to go.
Findbugs should be compileonly.
Feb 10 2019
I can add it probably, but I have to admit, I don't even know what coverage is!
This is not the way to do it. Compile is deprecated and should not be used.
Feb 9 2019
Feb 6 2019
- Remove debug code and fix API running detection
- Don't kill the API if we didn't start it
Feb 5 2019
- Cleanup code
I've tried to land things before, it says I don't have access (403)...
- Remove debug and unused code
- Autostart the development API if it's not running already, and stop it again when we're done.
Push accidental code, now removed
Uff. No-one wants to parse a string JSON, how about an error code?
@CLOVIS why have you rejected this?
- Simplify companion object syntax
Feb 4 2019
- Bring back the linters
Undo accidental push, I'm still a noob
- Remove debug code
Fix arcanist being weird and pushing random unrelated code
- Fix accidental upload of changed from another Diff
- Refactor WildFyre.kt to use a Java class and companion object
Feb 3 2019
This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...
Feb 2 2019
Feb 1 2019
Fixed locally, I'll submit a diff in the morning.
Jan 31 2019
Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.