Page MenuHomePhabricator

Hackintosh5 (Hackintosh5)
User

Projects

User does not belong to any projects.

User Details

User Since
Mon, Jan 28, 5:32 PM (3 w, 23 h)

Recent Activity

Wed, Feb 13

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

https://stackoverflow.com/questions/44413952/gradle-implementation-vs-api-configuration suggests that findBugs should be implementation not api.

Wed, Feb 13, 2:51 PM
Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.
In D222#5368, @CLOVIS wrote:

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

You're right. But D217 is the way to go.

Wed, Feb 13, 12:17 PM
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Wed, Feb 13, 10:51 AM

Sun, Feb 10

Hackintosh5 accepted D220: Updating server API.
Sun, Feb 10, 9:04 PM
Hackintosh5 added a comment to T328: Add a code coverage tool.

I can add it probably, but I have to admit, I don't even know what coverage is!

Sun, Feb 10, 9:00 PM · LibWF-java
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

This is not the way to do it. Compile is deprecated and should not be used.

Sun, Feb 10, 8:59 PM

Sat, Feb 9

Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5293, @CLOVIS wrote:

Is this ready for landing? Or do you plan to change other things

Sat, Feb 9, 5:27 PM

Wed, Feb 6

Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug code and fix API running detection
Wed, Feb 6, 11:06 AM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Don't kill the API if we didn't start it
Wed, Feb 6, 11:01 AM
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Wed, Feb 6, 9:22 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:22 AM · LibWF-java
Hackintosh5 added a revision to T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM · LibWF-java
Hackintosh5 updated the summary of D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Wed, Feb 6, 9:21 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Wed, Feb 6, 9:21 AM · LibWF-java
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5267, @CLOVIS wrote:

They sounds odd to me. I'll need to benchmark this on my machine to see exactly. You didn't forget to do the migrations, download the dependencies, etc?

Wed, Feb 6, 8:23 AM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5270, @CLOVIS wrote:

Oh. Okay, remove the "fixes t..." from the description here, otherwise pantocrator will close the task. I'm probably going to test all your diffs this week end.

Wed, Feb 6, 8:16 AM

Tue, Feb 5

Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:26 PM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5248, @CLOVIS wrote:

Looks good to me so far, but you need to do the Internal class too (in the same way).

Please tell me if you have a better name for it, "internal" doesn't record what it's for clearly enough in my opinion

Tue, Feb 5, 8:23 PM
Hackintosh5 added a comment to D213: Fix for Ubuntu 18.04.
In D213#5247, @CLOVIS wrote:

@CLOVIS why have you rejected this?

I didn't so far, I just added myself as a reviewer. Are you sure this change works everywhere?

Tue, Feb 5, 8:22 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Cleanup code
Tue, Feb 5, 8:20 PM
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5234, @CLOVIS wrote:
  • Autostart the development API if it's not running already, and stop it again when we're done.

That's really not a good idea, the API takes 2-4 minutes to launch. Just abort if it doesn't run, that'll be much more convenient.

Tue, Feb 5, 8:16 PM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 8:08 PM
Hackintosh5 added a comment to D219: Increase test timeout to prevent occasional failures.

I've tried to land things before, it says I don't have access (403)...

Tue, Feb 5, 8:06 PM
Hackintosh5 created D219: Increase test timeout to prevent occasional failures.
Tue, Feb 5, 3:33 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug and unused code
Tue, Feb 5, 1:40 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Autostart the development API if it's not running already, and stop it again when we're done.
Tue, Feb 5, 1:06 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.

Push accidental code, now removed

Tue, Feb 5, 12:58 PM
Hackintosh5 added a comment to T265: Unable to login with provided credentials.

Uff. No-one wants to parse a string JSON, how about an error code?

Tue, Feb 5, 10:05 AM · LibWF-java
Hackintosh5 added reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.
Tue, Feb 5, 10:00 AM
Hackintosh5 removed reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.

@CLOVIS why have you rejected this?

Tue, Feb 5, 10:00 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Simplify companion object syntax
Tue, Feb 5, 9:56 AM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Tue, Feb 5, 9:50 AM

Mon, Feb 4

Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Bring back the linters
Mon, Feb 4, 8:36 PM
Hackintosh5 added a comment to D216: Fix compilation for users without nexus authentication.
In D216#5160, @CLOVIS wrote:

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Mon, Feb 4, 8:30 PM
Hackintosh5 updated the diff for D216: Fix compilation for users without nexus authentication.

Undo accidental push, I'm still a noob

Mon, Feb 4, 8:28 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug code
Mon, Feb 4, 8:21 PM
Hackintosh5 updated the diff for D216: Fix compilation for users without nexus authentication.
Mon, Feb 4, 8:19 PM
Hackintosh5 created D218: Add arc unit engine for gradle.
Mon, Feb 4, 8:12 PM
Hackintosh5 added a revision to T315: Better unit tests for Phabricator: D218: Add arc unit engine for gradle.
Mon, Feb 4, 8:12 PM · LibWF-java
Hackintosh5 created D217: Update gradle wrapper.
Mon, Feb 4, 2:41 PM
Hackintosh5 created D216: Fix compilation for users without nexus authentication.
Mon, Feb 4, 12:37 PM
Hackintosh5 updated the diff for D215: Add test for WildFyre.kt.

Fix arcanist being weird and pushing random unrelated code

Mon, Feb 4, 10:19 AM
Hackintosh5 updated the diff for D215: Add test for WildFyre.kt.
  • Typo
Mon, Feb 4, 10:18 AM
Hackintosh5 created D215: Add test for WildFyre.kt.
Mon, Feb 4, 10:18 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Fix accidental upload of changed from another Diff
Mon, Feb 4, 9:36 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Refactor WildFyre.kt to use a Java class and companion object
Mon, Feb 4, 9:33 AM

Sun, Feb 3

Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5119, @CLOVIS wrote:

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

I don't like having global methods though, it's just not clean

Sun, Feb 3, 5:59 PM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

Sun, Feb 3, 11:57 AM
Hackintosh5 created D214: Convert WildFyre.java to Kotlin.
Sun, Feb 3, 11:17 AM

Sat, Feb 2

Hackintosh5 created D213: Fix for Ubuntu 18.04.
Sat, Feb 2, 8:01 AM

Fri, Feb 1

Hackintosh5 claimed T329: Minimal-json is missing from the archive.

Fixed locally, I'll submit a diff in the morning.

Fri, Feb 1, 9:09 PM · LibWF-java
Hackintosh5 added a comment to D211: Fix test password.
In D211#5079, @CLOVIS wrote:

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

That's weird. How did you manage to push this diff then? Arcanist doesn't normally let you diff when the tests do not pass. Please tell me what you did, there might a bug there.

Other than that, the procedure for the lib on Linux is:

  • ./api.sh (let it run in the background)
  • ./gradlew build

    On Windows:
  • git submodule init
  • git submodule update
  • Run the API by following the steps on the wiki (or the contents of the script api.sh)
  • gradlew.bat build

    Again, if you did not do this, there's a big problem because it shouldn't be possible to diff without doing those.
Fri, Feb 1, 9:08 PM

Thu, Jan 31

Hackintosh5 added a comment to D211: Fix test password.

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

Thu, Jan 31, 10:00 PM
Hackintosh5 created D211: Fix test password.
Thu, Jan 31, 8:20 PM