Page MenuHomePhabricator

Hackintosh5 (Hackintosh5)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2019, 5:32 PM (12 w, 2 d)

Recent Activity

Today

Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 2:33 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 2:22 PM
Hackintosh5 added a comment to D244: Get repo code somewhat up to date with current app.
In D244#6038, @WyldBot wrote:

Add a .gitignore to hide .DS_Store files and all files in the Pods folder

Wed, Apr 24, 1:25 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 1:14 PM
Hackintosh5 added inline comments to D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 1:02 PM
Hackintosh5 added a comment to D244: Get repo code somewhat up to date with current app.

Lint lines are too long. Check my inline comment in AlertChildPageViewController.xib:2

Wed, Apr 24, 12:58 PM
Hackintosh5 added inline comments to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 12:54 PM
Hackintosh5 abandoned D226: We don't need spotbugs on the tests since they aren't used in production..

Oh ok.

Wed, Apr 24, 12:47 PM
Hackintosh5 requested changes to D221: Internal to Kotlin.

Needs same changes as D246 and D247

Wed, Apr 24, 12:09 PM
Hackintosh5 requested changes to D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 12:06 PM
Hackintosh5 added inline comments to D246: Setup Continuous Integration via GitLab.
Wed, Apr 24, 12:06 PM
Hackintosh5 requested changes to D247: Migrating from FindBugs to SpotBugs.
Wed, Apr 24, 11:51 AM

Yesterday

Hackintosh5 abandoned D224: Fix unit tester.
Tue, Apr 23, 9:56 AM
Hackintosh5 commandeered D224: Fix unit tester.
Tue, Apr 23, 9:56 AM

Sat, Apr 20

Hackintosh5 requested changes to D221: Internal to Kotlin.

Can you check that the unit tests pass? Gradle skipped them so I guess they do but just to be sure

Sat, Apr 20, 2:31 AM

Fri, Apr 19

Hackintosh5 added a comment to D227: Downgrade SpotBugs to remove deprecation warning.

Again my source has been nuked. Can you just merge the diff?

Fri, Apr 19, 3:19 AM
Hackintosh5 added a comment to D225: Fix minimal-json JAR not being included..

Hmmm I've nuked my source tree so if it's not there it's not there. Is there a way to just apply the diff?

Fri, Apr 19, 3:18 AM
Hackintosh5 reclaimed D226: We don't need spotbugs on the tests since they aren't used in production..

Something is needed, at least. check is the wrong command; we should use either spotbugsMain spotbugsTest or spotbugsMain.

Fri, Apr 19, 3:07 AM
Hackintosh5 commandeered D226: We don't need spotbugs on the tests since they aren't used in production..
Fri, Apr 19, 3:03 AM

Wed, Apr 3

Hackintosh5 accepted D237: Fix split error.

Tested by manually setting localStorage.blockedUsers = "", now it works.

Wed, Apr 3, 7:44 PM
Hackintosh5 triaged T343: Firefox clients cannot use WildFyre as Unbreak Now! priority.
Wed, Apr 3, 7:36 PM · Web

Mar 17 2019

Hackintosh5 added a comment to T200: Unknown User Interface.

Wait, is this for the Client (web) or app?
And IMO the anonymous token should not be a token but a username/password combo that's only usable on /anonymous endpoints, and you don't register an anonymous account but change the username and password to a new one.

Mar 17 2019, 4:25 PM · Client, Server API

Mar 6 2019

Hackintosh5 created D227: Downgrade SpotBugs to remove deprecation warning.
Mar 6 2019, 9:56 AM
Hackintosh5 created D226: We don't need spotbugs on the tests since they aren't used in production..
Mar 6 2019, 9:42 AM

Mar 1 2019

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

This didn't fix minimal-json exporting correctly anyway. I've tested it in D225 and it works. I think this can be abandoned.

Mar 1 2019, 2:30 PM
Hackintosh5 created D225: Fix minimal-json JAR not being included..
Mar 1 2019, 2:27 PM
Hackintosh5 added a comment to T331: Kotlin-based projects cannot use libwf-java.

I know.

Mar 1 2019, 2:24 PM · LibWF-java

Feb 28 2019

Hackintosh5 added a comment to D224: Fix unit tester.

Note that task.state.executed does not check if the task ran, but if the task ran or was already up to date. That means that if a dependency failed, it will return false.

Feb 28 2019, 5:03 PM
Hackintosh5 added a comment to D223: Update gradle wrapper and fix dependencies. Fixes T331..

Made spotbugs ignore these security errors in the tests. In IssueWithTransferException, it is absolutely correct, that could *in some extreme cases where someone is abusing the API*, cause a crash.

Feb 28 2019, 5:02 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Make SpotBugs sad :(
  • Make SpotBugs ignore security errors in the RequestTest
Feb 28 2019, 4:58 PM
Hackintosh5 created D224: Fix unit tester.
Feb 28 2019, 3:47 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Derp 2
Feb 28 2019, 3:28 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:16 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
  • Derp
Feb 28 2019, 3:13 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:10 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 3:01 PM
Hackintosh5 added inline comments to D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:57 PM
Hackintosh5 updated the diff for D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:55 PM
Hackintosh5 added a task to D223: Update gradle wrapper and fix dependencies. Fixes T331.: T331: Kotlin-based projects cannot use libwf-java.
Feb 28 2019, 2:24 PM
Hackintosh5 added a revision to T331: Kotlin-based projects cannot use libwf-java: D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:24 PM · LibWF-java
Hackintosh5 created D223: Update gradle wrapper and fix dependencies. Fixes T331..
Feb 28 2019, 2:22 PM
Hackintosh5 triaged T331: Kotlin-based projects cannot use libwf-java as Unbreak Now! priority.
Feb 28 2019, 1:49 PM · LibWF-java
Hackintosh5 abandoned D217: Update gradle wrapper.

It no longer merges onto master, and it doesn't work anyway. New revision incoming, as well as a bug report.

Feb 28 2019, 1:42 PM

Feb 27 2019

Hackintosh5 triaged T330: Use error codes in the API, rather than error messages as High priority.
Feb 27 2019, 8:58 AM · LibWF

Feb 20 2019

Hackintosh5 abandoned D211: Fix test password.
Feb 20 2019, 9:05 PM

Feb 13 2019

Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.

https://stackoverflow.com/questions/44413952/gradle-implementation-vs-api-configuration suggests that findBugs should be implementation not api.

Feb 13 2019, 2:51 PM
Hackintosh5 added a comment to D222: Fix missing minimal-json is exported JAR.
In D222#5368, @CLOVIS wrote:

Findbugs should be compileonly.

That's what I thought but findbugs works on the generated JAR, if it's compileOnly findbugs cannot access it

You're right. But D217 is the way to go.

Feb 13 2019, 12:17 PM
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

Findbugs should be compileonly.

Feb 13 2019, 10:51 AM

Feb 10 2019

Hackintosh5 accepted D220: Updating server API.
Feb 10 2019, 9:04 PM
Hackintosh5 added a comment to T328: Add a code coverage tool.

I can add it probably, but I have to admit, I don't even know what coverage is!

Feb 10 2019, 9:00 PM · LibWF-java
Hackintosh5 requested changes to D222: Fix missing minimal-json is exported JAR.

This is not the way to do it. Compile is deprecated and should not be used.

Feb 10 2019, 8:59 PM

Feb 9 2019

Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5293, @CLOVIS wrote:

Is this ready for landing? Or do you plan to change other things

Feb 9 2019, 5:27 PM

Feb 6 2019

Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug code and fix API running detection
Feb 6 2019, 11:06 AM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Don't kill the API if we didn't start it
Feb 6 2019, 11:01 AM
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Feb 6 2019, 9:22 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Feb 6 2019, 9:22 AM · LibWF-java
Hackintosh5 added a revision to T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Feb 6 2019, 9:21 AM · LibWF-java
Hackintosh5 updated the summary of D214: Convert WildFyre.java to Kotlin.
Feb 6 2019, 9:21 AM
Hackintosh5 removed a task from D214: Convert WildFyre.java to Kotlin: T272: Convert API to Kotlin.
Feb 6 2019, 9:21 AM
Hackintosh5 removed a revision from T272: Convert API to Kotlin: D214: Convert WildFyre.java to Kotlin.
Feb 6 2019, 9:21 AM · LibWF-java
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5267, @CLOVIS wrote:

They sounds odd to me. I'll need to benchmark this on my machine to see exactly. You didn't forget to do the migrations, download the dependencies, etc?

Feb 6 2019, 8:23 AM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5270, @CLOVIS wrote:

Oh. Okay, remove the "fixes t..." from the description here, otherwise pantocrator will close the task. I'm probably going to test all your diffs this week end.

Feb 6 2019, 8:16 AM

Feb 5 2019

Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Feb 5 2019, 8:26 PM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5248, @CLOVIS wrote:

Looks good to me so far, but you need to do the Internal class too (in the same way).
Please tell me if you have a better name for it, "internal" doesn't record what it's for clearly enough in my opinion

Feb 5 2019, 8:23 PM
Hackintosh5 added a comment to D213: Fix for Ubuntu 18.04.
In D213#5247, @CLOVIS wrote:

@CLOVIS why have you rejected this?

I didn't so far, I just added myself as a reviewer. Are you sure this change works everywhere?

Feb 5 2019, 8:22 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Cleanup code
Feb 5 2019, 8:20 PM
Hackintosh5 added a comment to D218: Add arc unit engine for gradle.
In D218#5234, @CLOVIS wrote:
  • Autostart the development API if it's not running already, and stop it again when we're done.

That's really not a good idea, the API takes 2-4 minutes to launch. Just abort if it doesn't run, that'll be much more convenient.

Feb 5 2019, 8:16 PM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Feb 5 2019, 8:08 PM
Hackintosh5 added a comment to D219: Increase test timeout to prevent occasional failures.

I've tried to land things before, it says I don't have access (403)...

Feb 5 2019, 8:06 PM
Hackintosh5 created D219: Increase test timeout to prevent occasional failures.
Feb 5 2019, 3:33 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug and unused code
Feb 5 2019, 1:40 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Autostart the development API if it's not running already, and stop it again when we're done.
Feb 5 2019, 1:06 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.

Push accidental code, now removed

Feb 5 2019, 12:58 PM
Hackintosh5 added a comment to T265: Unable to login with provided credentials.

Uff. No-one wants to parse a string JSON, how about an error code?

Feb 5 2019, 10:05 AM · LibWF-java
Hackintosh5 added reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.
Feb 5 2019, 10:00 AM
Hackintosh5 removed reviewers for D213: Fix for Ubuntu 18.04: CLOVIS, WyldBot.

@CLOVIS why have you rejected this?

Feb 5 2019, 10:00 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Simplify companion object syntax
Feb 5 2019, 9:56 AM
Hackintosh5 added inline comments to D218: Add arc unit engine for gradle.
Feb 5 2019, 9:50 AM

Feb 4 2019

Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Bring back the linters
Feb 4 2019, 8:36 PM
Hackintosh5 added a comment to D216: Fix compilation for users without nexus authentication.
In D216#5160, @CLOVIS wrote:

What are you even trying to do? The Nexus account is only used for deployment and you don't have the key anyway. It makes no sense to try to connect to an empty username and password

Feb 4 2019, 8:30 PM
Hackintosh5 updated the diff for D216: Fix compilation for users without nexus authentication.

Undo accidental push, I'm still a noob

Feb 4 2019, 8:28 PM
Hackintosh5 updated the diff for D218: Add arc unit engine for gradle.
  • Remove debug code
Feb 4 2019, 8:21 PM
Hackintosh5 updated the diff for D216: Fix compilation for users without nexus authentication.
Feb 4 2019, 8:19 PM
Hackintosh5 created D218: Add arc unit engine for gradle.
Feb 4 2019, 8:12 PM
Hackintosh5 added a revision to T315: Better unit tests for Phabricator: D218: Add arc unit engine for gradle.
Feb 4 2019, 8:12 PM · LibWF-java
Hackintosh5 created D217: Update gradle wrapper.
Feb 4 2019, 2:41 PM
Hackintosh5 created D216: Fix compilation for users without nexus authentication.
Feb 4 2019, 12:37 PM
Hackintosh5 updated the diff for D215: Add test for WildFyre.kt.

Fix arcanist being weird and pushing random unrelated code

Feb 4 2019, 10:19 AM
Hackintosh5 updated the diff for D215: Add test for WildFyre.kt.
  • Typo
Feb 4 2019, 10:18 AM
Hackintosh5 created D215: Add test for WildFyre.kt.
Feb 4 2019, 10:18 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Fix accidental upload of changed from another Diff
Feb 4 2019, 9:36 AM
Hackintosh5 updated the diff for D214: Convert WildFyre.java to Kotlin.
  • Refactor WildFyre.kt to use a Java class and companion object
Feb 4 2019, 9:33 AM

Feb 3 2019

Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.
In D214#5119, @CLOVIS wrote:

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

I don't like having global methods though, it's just not clean

Feb 3 2019, 5:59 PM
Hackintosh5 added a comment to D214: Convert WildFyre.java to Kotlin.

This is (from reading the Kt docs) the "correct" way... It's true, it would break existing clients except there is no-one using this library yet...

Feb 3 2019, 11:57 AM
Hackintosh5 created D214: Convert WildFyre.java to Kotlin.
Feb 3 2019, 11:17 AM

Feb 2 2019

Hackintosh5 created D213: Fix for Ubuntu 18.04.
Feb 2 2019, 8:01 AM

Feb 1 2019

Hackintosh5 claimed T329: Minimal-json is missing from the archive.

Fixed locally, I'll submit a diff in the morning.

Feb 1 2019, 9:09 PM · LibWF-java
Hackintosh5 added a comment to D211: Fix test password.
In D211#5079, @CLOVIS wrote:

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

That's weird. How did you manage to push this diff then? Arcanist doesn't normally let you diff when the tests do not pass. Please tell me what you did, there might a bug there.
Other than that, the procedure for the lib on Linux is:

  • ./api.sh (let it run in the background)
  • ./gradlew build

On Windows:

  • git submodule init
  • git submodule update
  • Run the API by following the steps on the wiki (or the contents of the script api.sh)
  • gradlew.bat build

Again, if you did not do this, there's a big problem because it shouldn't be possible to diff without doing those.

Feb 1 2019, 9:08 PM

Jan 31 2019

Hackintosh5 added a comment to D211: Fix test password.

Um, idk how to run the tests. I *could* look it up if I weren't about to sleep. I'll look in the morning, but I assumed that it was simply a missing $, because that's what changed in D203.

Jan 31 2019, 10:00 PM
Hackintosh5 created D211: Fix test password.
Jan 31 2019, 8:20 PM