Page MenuHomePhabricator

TCGman (Laurent Tréguier)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 11:49 AM (6 w, 23 h)

Recent Activity

Tue, May 14

TCGman added inline comments to D251: Reboot the Android client.
Tue, May 14, 12:57 PM
TCGman updated the diff for D251: Reboot the Android client.
  • Tune ignored files according to Jetbrains recommendations
  • Move .editorconfig to project root
  • Rename main Application class to WildFyreApplication
  • Comment on WildFyreApplication instance
  • Better format AUTOMATIC theme definition
  • Add explicit returns
  • Reduce potential NPEs
  • Explain null assertion usage in then extension function
  • Remove useless ApiItem parent class
  • Move inner model classes to global Models.kt scope
Tue, May 14, 12:26 PM
TCGman added a comment to D251: Reboot the Android client.
  • For _body: this came from webcl, where it seemed to be where error messages are stored
  • WildFyre grey: it would require adapting the rest of the color palette, it's too blue-ish compared to the rest of the app in night mode
  • strings.xml: Android needs default values, so that one should not change (the app doesn't build without a default strings.xml file)
  • Username and password: they stay in memory only, and the LoginFragmentViewModel is disposed of as soon as the login step is finished and the LoginFragment is destroyed; these variables won't keep credentials info any longer than the UI EditTexts themselves will anyway
Tue, May 14, 9:30 AM
TCGman updated the diff for D251: Reboot the Android client.
  • Remove unnecessary authentication token usage
  • Use template literals
  • Merge .gitignore files, fully ignore /.idea
  • Use official WildFyre orange hue
  • Add .editorconfig, reformat project
Tue, May 14, 9:22 AM

Mon, May 13

TCGman added a comment to D251: Reboot the Android client.

Technically I didn't "rewrite" the Git history; I just added mine on top of it... But it did erase every file, yes.
I've updated the revision after cherry-picking your commit adding automated versioning, and updated the plugin to its latest version.

Mon, May 13, 4:08 PM
TCGman updated the diff for D251: Reboot the Android client.

Automated release, upgrading, automated version number, private signing

Mon, May 13, 4:04 PM

Sun, May 12

TCGman added a reviewer for D251: Reboot the Android client: Hackintosh5.
Sun, May 12, 5:23 PM
TCGman updated the summary of D251: Reboot the Android client.
Sun, May 12, 5:13 PM
TCGman created D251: Reboot the Android client.
Sun, May 12, 5:12 PM