HomePhabricator

Bugfixes for 4a7948365433
Concern Raised497b23a6ad60

Description

Bugfixes for 4a7948365433

Summary:
Fixes bugs introduced in 4a7948365433 (D163)

Fixes people being unable to register
Fixes login logic, instead of freezing on incorrect credentials we now respond with a generic error message.

Fixes a lot of minor bugs:
Fixes asterisks on input fields
Adds Open Source link to side navbar
Implements somewhat of a fix for flashing back button (Still performs slowly on post view)
Fixes bottom navbar highlight(sometimes the highlight was on the wrong section(or not working))
Fixes notification archive and user posts not taking into account its main image(for image icon)
Fixes weird offset background color
Fixes 2px space between navbar and top navbar(desktop only)
Removes odd highlight to the left of pictures(desktop only)
Fully center aligns area drop down
Changes pointer cursor on back button to better reflect its use
Fixes offset comment send button(desktop only)

Fixes T163, T203

Test Plan: Look at fixes?

Reviewers: Info-Screen, CLOVIS

Reviewed By: Info-Screen

Subscribers: CLOVIS, WyldBot, Info-Screen

Maniphest Tasks: T203, T163

Differential Revision: https://phabricator.wildfyre.net/D179

Details

Auditors
Info-Screen
Provenance
WyldBotAuthored on Jul 14 2018, 5:33 PM
Reviewer
Info-Screen
Differential Revision
D179: Bugfixes for 4a7948365433
Parents
rWCL4a7948365433: Angular 5
Branches
Unknown
Tags
Unknown
Tasks
T163: Fix asterisks on input fields
T203: Add phabricator link to social icons

Event Timeline

Info-Screen added a subscriber: Info-Screen.

Add testcases for the bugs fixed in this commit, so they don't happen again

This commit now has outstanding concerns.Jul 18 2018, 9:31 PM